From d155dfdecb7f5ab0e05f84610f63e58b5874d0b0 Mon Sep 17 00:00:00 2001
From: Robert Kaussow <mail@thegeeklab.de>
Date: Tue, 29 Aug 2023 15:06:56 +0200
Subject: [PATCH] Use html list for changed files list (#2346)

![image](https://github.com/woodpecker-ci/woodpecker/assets/3391958/743317fa-cce6-4eb5-aaa4-7f38aadfcb66)
---
 web/src/views/repo/pipeline/PipelineChangedFiles.vue | 11 ++++-------
 web/src/views/repo/pipeline/PipelineWrapper.vue      |  8 ++++++--
 2 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/web/src/views/repo/pipeline/PipelineChangedFiles.vue b/web/src/views/repo/pipeline/PipelineChangedFiles.vue
index 766c375f4..0f3eac2e3 100644
--- a/web/src/views/repo/pipeline/PipelineChangedFiles.vue
+++ b/web/src/views/repo/pipeline/PipelineChangedFiles.vue
@@ -1,11 +1,8 @@
 <template>
-  <Panel v-if="pipeline">
-    <div v-if="pipeline.changed_files === undefined || pipeline.changed_files.length < 1" class="w-full">
-      <span class="text-wp-text-100">{{ $t('repo.pipeline.no_files') }}</span>
-    </div>
-    <div v-for="file in pipeline.changed_files" v-else :key="file" class="w-full">
-      <div>- {{ file }}</div>
-    </div>
+  <Panel>
+    <ul class="list-disc list-inside w-full">
+      <li v-for="file in pipeline.changed_files" :key="file">{{ file }}</li>
+    </ul>
   </Panel>
 </template>
 
diff --git a/web/src/views/repo/pipeline/PipelineWrapper.vue b/web/src/views/repo/pipeline/PipelineWrapper.vue
index f8a53238a..87f0100a9 100644
--- a/web/src/views/repo/pipeline/PipelineWrapper.vue
+++ b/web/src/views/repo/pipeline/PipelineWrapper.vue
@@ -61,9 +61,13 @@
       <Tab id="tasks" :title="$t('repo.pipeline.tasks')" />
       <Tab id="config" :title="$t('repo.pipeline.config')" />
       <Tab
-        v-if="pipeline.event === 'push' || pipeline.event === 'pull_request'"
+        v-if="
+          (pipeline.event === 'push' || pipeline.event === 'pull_request') &&
+          pipeline.changed_files &&
+          pipeline.changed_files.length > 0
+        "
         id="changed-files"
-        :title="$t('repo.pipeline.files', { files: pipeline.changed_files?.length || 0 })"
+        :title="$t('repo.pipeline.files', { files: pipeline.changed_files.length })"
       />
       <router-view />
     </Scaffold>