qwerty287
b9f6f3f9fb
Replace goimports with gci ( #3202 )
...
`gci` seems to be much more strict.
2024-01-14 18:22:06 +01:00
qwerty287
45bf8600ef
Remove multipart logger ( #3200 )
2024-01-14 10:54:02 +01:00
Robert Kaussow
685907ddf6
Fix spelling in test description ( #3198 )
2024-01-13 15:24:13 +01:00
Thomas Anderson
0611fa9b32
Added protocol in port configuration ( #2993 )
...
Closes #2727
2024-01-12 23:57:24 +01:00
Thomas Anderson
9bbc446009
Kubernetes AppArmor and seccomp ( #3123 )
...
Closes #2545
seccomp
https://kubernetes.io/docs/tutorials/security/seccomp/
https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/135-seccomp/README.md
AppArmor
https://kubernetes.io/docs/tutorials/security/apparmor/
fddcbb9cbf/keps/sig-node/24-apparmor/README.md
2024-01-12 23:32:24 +01:00
Robert Kaussow
9bbba4441d
Enable golangci linter forcetypeassert ( #3168 )
...
Split out from https://github.com/woodpecker-ci/woodpecker/pull/2960
2024-01-12 02:01:02 +01:00
Robert Kaussow
f813badcf9
Enable golangci linter contextcheck ( #3170 )
...
Split out from https://github.com/woodpecker-ci/woodpecker/pull/2960
2024-01-11 22:15:15 +01:00
6543
f8fb28e651
More docker backend test remove more undocumented ( #3156 )
...
remove Sysctls and IpcMode
2024-01-11 19:30:13 +01:00
qwerty287
b0a2b1cf2d
Lowercase all log strings ( #3173 )
...
from #3161
---------
Co-authored-by: 6543 <6543@obermui.de>
2024-01-11 19:17:07 +01:00
qwerty287
f56f9cb1c0
Cleanups + prefer .yaml ( #3069 )
...
Co-authored-by: Robert Kaussow <xoxys@rknet.org>
2024-01-11 18:43:54 +01:00
6543
d1fe86b7be
Use UUID as podName and cleanup arguments for Kubernetes backend ( #3135 )
...
to much args are just horrible to maintain. And we already have it nice
structured stored as step.
2024-01-11 16:32:37 +01:00
Robert Kaussow
7756c60a33
Enable golangci linter stylecheck ( #3167 )
...
This PR only fixes error string formatting, log message strings are
still mixed upper/lowercase (see
https://github.com/woodpecker-ci/woodpecker/pull/3161#issuecomment-1885140649 )
and I'm not aware of a linter to enforce it.
2024-01-10 22:56:42 +01:00
qwerty287
00df53e941
Clean up logging ( #3161 )
...
- use `Err` method instead of format strings
- use `Msg` if no format string is used
2024-01-10 20:57:12 +01:00
qwerty287
12c40eb957
Enable gocritic and don't ignore globally ( #3159 )
...
Use `nolint` directives instead.
From #2960
2024-01-10 15:34:44 +01:00
qwerty287
1b380ff4b4
Enable nolintlint ( #3158 )
2024-01-10 12:11:18 +01:00
qwerty287
768fd71841
Enable some linters ( #3129 )
...
Mostly those that did not require much work.
From #2960
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-01-09 21:35:37 +01:00
6543
c91c6fbe9e
TestToConfigSmall ignore sort order of env vars ( #3154 )
...
so this https://ci.woodpecker-ci.org/repos/3780/pipeline/11803/30 can
not randomly happen
2024-01-09 18:34:11 +01:00
6543
e3cf7b212c
fix also test of #3137
2024-01-09 16:36:17 +01:00
6543
06538504f8
fix regression: save env into configEnv
...
introduced by #3137
2024-01-09 16:28:10 +01:00
6543
aab2f0e675
Use step uuid instead of name in GRPC status calls ( #3143 )
...
close #3109
~~also fix start time of steps to be set correctly~~ edgecase do not hit
anymore as we have a clear sepperation between workflows and steps now
:)
---------
Co-authored-by: Anbraten <anton@ju60.de>
2024-01-09 15:39:09 +01:00
6543
cd59a85230
Use name in backend types instead of alias ( #3142 )
2024-01-09 15:22:59 +01:00
6543
1eacf74376
Remove duplicate assignment of CI_STEP_NAME ( #3139 )
...
Co-authored-by: Anbraten <anton@ju60.de>
2024-01-09 08:56:28 +01:00
6543
12df59d0ec
Add step name as label to docker containers ( #3137 )
...
and add a test
2024-01-09 06:01:34 +01:00
6543
c64340cf8f
Use UUID instead of step name where possible ( #3136 )
...
things I found while looking at #3109
2024-01-09 05:43:03 +01:00
6543
31614d0e38
Use step type to detect services in Kubernetes backend ( #3141 )
...
and use the correct name for tail log
---------
Co-authored-by: Anbraten <anton@ju60.de>
2024-01-09 05:42:36 +01:00
Thomas Anderson
c0fc4828ff
Flexible image pull secret reference ( #3016 )
...
Co-authored-by: pat-s <patrick.schratz@gmail.com>
2024-01-05 08:33:56 +01:00
qwerty287
5517d87dd6
Fix step depends_on as string in schema ( #3099 )
2024-01-01 12:16:36 +01:00
Anbraten
6fbf98f1b9
Fix slice unmarshaling ( #3097 )
...
closes #3055
2024-01-01 11:03:31 +01:00
6543
8b47b3a978
make event in pipeline schema also a constraint_list ( #3082 )
2023-12-31 08:49:46 +01:00
6543
2cb7669413
add just more dag tests ( #3083 )
2023-12-30 16:45:11 +01:00
qwerty287
c74dc9ce92
Remove old files ( #3077 )
...
from https://github.com/woodpecker-ci/woodpecker/pull/3069
- `.changelog.yml`: no longer used
- `pipeline/samples`
2023-12-30 15:10:31 +01:00
qwerty287
a37af3eeac
Add imports checks to linter ( #3056 )
...
supersedes https://github.com/woodpecker-ci/woodpecker/pull/874
---------
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2023-12-29 21:19:42 +01:00
qwerty287
7e2ea306c4
Remove workflow version again ( #3052 )
2023-12-28 14:34:13 +01:00
Kamila Borowska
4bc2fed550
Fix DAG cycle detection ( #3049 )
...
Previously a graph like this.
a <- b
^ ^
| |
c <- d
Was incorrectly recognized as having a cycle.
Fixes #3048 .
2023-12-28 00:14:28 +01:00
6543
840fca198e
make backend step dag generation deterministic ( #3037 )
...
the the generation for backend steps if a dag is used deterministic.
this also fix where the test randomly fail like in:
- https://ci.woodpecker-ci.org/repos/3780/pipeline/11057/30
- https://ci.woodpecker-ci.org/repos/3780/pipeline/11076/25
2023-12-27 12:38:33 +02:00
qwerty287
e575ffe72d
Add some tests ( #3030 )
2023-12-27 10:36:49 +01:00
Anbraten
f01ac3f0a3
Add pull request closed event ( #2684 )
...
- [x] updates docs
- [x] adjust UI
- [x] show correct icon
- [x] show correct link (to pr)
- [x] add as option in secret edit
- [x] parse webhook
- [x] update tests
- [x] github merged
- [x] github closed
- [x] gitea merged
- [x] gitea closed
- [x] bitbucket merged
- [x] bitbucket closed
- [x] gitlab merged
- [x] gitlab closed
closes #286
2023-12-26 19:22:52 +01:00
Anbraten
2b1e5f35de
Add depends_on support for steps ( #2771 )
...
Co-authored-by: 6543 <6543@obermui.de>
2023-12-24 12:14:30 +01:00
qwerty287
9d9bcbf363
Hide PR tab if PRs are disabled ( #3004 )
...
Closes https://github.com/woodpecker-ci/woodpecker/issues/2988
2023-12-24 11:04:18 +02:00
Thomas Anderson
253d702bc7
Fix IPv6 host aliases for kubernetes ( #2992 )
...
Closes #2991
[Tests](https://github.com/woodpecker-ci/woodpecker/pull/2993#issuecomment-1868048169 )
---------
Co-authored-by: 6543 <6543@obermui.de>
2023-12-23 00:42:30 +01:00
6543
cd9d425a0d
Fix cli lint throwing error on warnings ( #2995 )
...
split out from #2771
---------
Co-authored-by: Anbraten <anton@ju60.de>
2023-12-23 00:34:17 +02:00
qwerty287
ce4f952b50
Switch to ULID ( #2986 )
...
Closes https://github.com/woodpecker-ci/woodpecker/discussions/2156
2023-12-21 20:23:51 +01:00
Thomas Anderson
01a955ed0e
Kubernetes refactor ( #2794 )
...
Kubernetes backend refactoring and tests
---------
Co-authored-by: 6543 <6543@obermui.de>
2023-12-19 04:53:52 +01:00
Nikolai Rodionov
f7f78b2a3f
feat(k8s): Add a port name to service definition ( #2933 )
...
It should cover this issue: https://github.com/woodpecker-ci/woodpecker/issues/2931
To sum up, when several ports need to be specified, they must be named
2023-12-19 02:38:18 +01:00
6543
936c9bdb0d
Export changed files via builtin environment variables ( #2935 )
...
add **`CI_PIPELINE_FILES`** to builtin env vars
close #853
---
*Sponsored by Kithara Software GmbH*
2023-12-18 22:37:38 +01:00
renovate[bot]
b66f6cb118
fix(deps): update golang (packages) ( #2958 )
...
[](https://renovatebot.com )
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
|
[github.com/caddyserver/certmagic](https://togithub.com/caddyserver/certmagic )
| require | minor | `v0.19.2` -> `v0.20.0` |
| [github.com/expr-lang/expr](https://togithub.com/expr-lang/expr ) |
require | patch | `v1.15.6` -> `v1.15.7` |
| [github.com/google/uuid](https://togithub.com/google/uuid ) | require |
minor | `v1.4.0` -> `v1.5.0` |
|
[github.com/jellydator/ttlcache/v3](https://togithub.com/jellydator/ttlcache )
| require | patch | `v3.1.0` -> `v3.1.1` |
| [github.com/mattn/go-sqlite3](https://togithub.com/mattn/go-sqlite3 ) |
require | patch | `v1.14.18` -> `v1.14.19` |
| [github.com/xanzy/go-gitlab](https://togithub.com/xanzy/go-gitlab ) |
require | minor | `v0.94.0` -> `v0.95.2` |
| [google.golang.org/grpc](https://togithub.com/grpc/grpc-go ) | require
| minor | `v1.59.0` -> `v1.60.0` |
| [k8s.io/api](https://togithub.com/kubernetes/api ) | require | minor |
`v0.28.4` -> `v0.29.0` |
| [k8s.io/apimachinery](https://togithub.com/kubernetes/apimachinery ) |
require | minor | `v0.28.4` -> `v0.29.0` |
| [k8s.io/client-go](https://togithub.com/kubernetes/client-go ) |
require | minor | `v0.28.4` -> `v0.29.0` |
---
### Release Notes
<details>
<summary>caddyserver/certmagic
(github.com/caddyserver/certmagic)</summary>
###
[`v0.20.0`](https://togithub.com/caddyserver/certmagic/releases/tag/v0.20.0 )
[Compare
Source](https://togithub.com/caddyserver/certmagic/compare/v0.19.2...v0.20.0 )
This release vastly improves storage cleaning as well improving a few
smaller things. There is a minor breaking change as we get ever closer
to v1.0.
- ⚠️ The `DecisionFunc` for On-Demand TLS now takes a
`context.Context` value as its first argument. The context carries the
`ClientHelloInfo` value (keyed by `ClientHelloInfoCtxKey`) for logging
purposes.
- Storage cleaning is now synchronized across the cluster, including
process restarts. The state of cleaning expired certificates and OCSP
staples is written to storage, and distributed locking is used to ensure
that only 1 instance does it at a time. This greatly reduces costs for
expensive storage backends! Cleaning is also done less often when the
process is frequently restarted because the state is written to storage,
so it is not forgotten after shutting down.
- `.home.arpa` is now considered an internal suffix.
- Backoff timings have been tuned based on real-world experience.
#### What's Changed
- README: Add hint about NextProtos for certmagic.TLS by
[@​oliverpool](https://togithub.com/oliverpool ) in
[https://github.com/caddyserver/certmagic/pull/251 ](https://togithub.com/caddyserver/certmagic/pull/251 )
- Bump golang.org/x/net from 0.11.0 to 0.17.0 by
[@​dependabot](https://togithub.com/dependabot ) in
[https://github.com/caddyserver/certmagic/pull/253 ](https://togithub.com/caddyserver/certmagic/pull/253 )
- Optionally pass the context argument down to the OnDemand decision
func by [@​ankon](https://togithub.com/ankon ) in
[https://github.com/caddyserver/certmagic/pull/255 ](https://togithub.com/caddyserver/certmagic/pull/255 )
- Retain the error stack if `checkIfCertShouldBeObtained` returns an
error by [@​ankon](https://togithub.com/ankon ) in
[https://github.com/caddyserver/certmagic/pull/256 ](https://togithub.com/caddyserver/certmagic/pull/256 )
- Add OCSP stapling unit tests by
[@​kenjenkins](https://togithub.com/kenjenkins ) in
[https://github.com/caddyserver/certmagic/pull/259 ](https://togithub.com/caddyserver/certmagic/pull/259 )
#### New Contributors
- [@​oliverpool](https://togithub.com/oliverpool ) made their first
contribution in
[https://github.com/caddyserver/certmagic/pull/251 ](https://togithub.com/caddyserver/certmagic/pull/251 )
**Full Changelog**:
https://github.com/caddyserver/certmagic/compare/v0.19.2...v0.20.0
</details>
<details>
<summary>expr-lang/expr (github.com/expr-lang/expr)</summary>
###
[`v1.15.7`](https://togithub.com/expr-lang/expr/releases/tag/v1.15.7 )
[Compare
Source](https://togithub.com/expr-lang/expr/compare/v1.15.6...v1.15.7 )
**Expr** is a Go-centric expression language designed to deliver dynamic
configurations with unparalleled accuracy, safety, and speed.
##### In this release:
- Fixed commutative property for comparison between a value and a
pointer. ([#​490](https://togithub.com/expr-lang/expr/issues/490 ))
- Checker: forbid accessing built-ins and custom functions from `$env`.
([#​495](https://togithub.com/expr-lang/expr/issues/495 ))
- Enhanced the number parser to include support for parsing hexadecimal,
binary, and octal literals.
([#​483](https://togithub.com/expr-lang/expr/issues/483 ))
- Added `GetSource()` method to `vm.Program`.
([#​491](https://togithub.com/expr-lang/expr/issues/491 ))
</details>
<details>
<summary>google/uuid (github.com/google/uuid)</summary>
### [`v1.5.0`](https://togithub.com/google/uuid/releases/tag/v1.5.0 )
[Compare
Source](https://togithub.com/google/uuid/compare/v1.4.0...v1.5.0 )
##### Features
- Validate UUID without creating new UUID
([#​141](https://togithub.com/google/uuid/issues/141 ))
([9ee7366](9ee7366e66https://togithub.com/jellydator/ttlcache/releases/tag/v3.1.1 )
[Compare
Source](https://togithub.com/jellydator/ttlcache/compare/v3.1.0...v3.1.1 )
Fix a bug in the `Range` method that causes a panic when the cache is
empty
</details>
<details>
<summary>mattn/go-sqlite3 (github.com/mattn/go-sqlite3)</summary>
###
[`v1.14.19`](https://togithub.com/mattn/go-sqlite3/compare/v1.14.18...v1.14.19 )
[Compare
Source](https://togithub.com/mattn/go-sqlite3/compare/v1.14.18...v1.14.19 )
</details>
<details>
<summary>xanzy/go-gitlab (github.com/xanzy/go-gitlab)</summary>
###
[`v0.95.2`](https://togithub.com/xanzy/go-gitlab/compare/v0.95.1...v0.95.2 )
[Compare
Source](https://togithub.com/xanzy/go-gitlab/compare/v0.95.1...v0.95.2 )
###
[`v0.95.1`](https://togithub.com/xanzy/go-gitlab/compare/v0.95.0...v0.95.1 )
[Compare
Source](https://togithub.com/xanzy/go-gitlab/compare/v0.95.0...v0.95.1 )
###
[`v0.95.0`](https://togithub.com/xanzy/go-gitlab/compare/v0.94.0...v0.95.0 )
[Compare
Source](https://togithub.com/xanzy/go-gitlab/compare/v0.94.0...v0.95.0 )
</details>
<details>
<summary>grpc/grpc-go (google.golang.org/grpc)</summary>
### [`v1.60.0`](https://togithub.com/grpc/grpc-go/releases/tag/v1.60.0 ):
Release 1.60.0
[Compare
Source](https://togithub.com/grpc/grpc-go/compare/v1.59.0...v1.60.0 )
### Security
- credentials/tls: if not set, set TLS MinVersion to 1.2 and
CipherSuites according to supported suites not forbidden by RFC7540.
- This is a behavior change to bring us into better alignment with RFC
7540.
### API Changes
- resolver: remove deprecated and experimental
`ClientConn.NewServiceConfig`
([#​6784](https://togithub.com/grpc/grpc-go/issues/6784 ))
- client: remove deprecated `grpc.WithServiceConfig` `DialOption`
([#​6800](https://togithub.com/grpc/grpc-go/issues/6800 ))
### Bug Fixes
- client: fix race that could cause a deadlock while entering idle mode
and receiving a name resolver update
([#​6804](https://togithub.com/grpc/grpc-go/issues/6804 ))
- client: always enable TCP keepalives with OS defaults
([#​6834](https://togithub.com/grpc/grpc-go/issues/6834 ))
- credentials/alts: fix a bug preventing ALTS from connecting to the
metadata server if the default scheme is overridden
([#​6686](https://togithub.com/grpc/grpc-go/issues/6686 ))
- Special Thanks: [@​mjamaloney](https://togithub.com/mjamaloney )
### Behavior Changes
- server: Do not return from Stop() or GracefulStop() until all
resources are released
([#​6489](https://togithub.com/grpc/grpc-go/issues/6489 ))
- Special Thanks: [@​fho](https://togithub.com/fho )
### Documentation
- codes: clarify that only codes defined by this package are valid and
that users should not cast other values to `codes.Code`
([#​6701](https://togithub.com/grpc/grpc-go/issues/6701 ))
</details>
<details>
<summary>kubernetes/api (k8s.io/api)</summary>
###
[`v0.29.0`](https://togithub.com/kubernetes/api/compare/v0.28.4...v0.29.0 )
[Compare
Source](https://togithub.com/kubernetes/api/compare/v0.28.4...v0.29.0 )
</details>
<details>
<summary>kubernetes/apimachinery (k8s.io/apimachinery)</summary>
###
[`v0.29.0`](https://togithub.com/kubernetes/apimachinery/compare/v0.28.4...v0.29.0 )
[Compare
Source](https://togithub.com/kubernetes/apimachinery/compare/v0.28.4...v0.29.0 )
</details>
<details>
<summary>kubernetes/client-go (k8s.io/client-go)</summary>
###
[`v0.29.0`](https://togithub.com/kubernetes/client-go/compare/v0.28.4...v0.29.0 )
[Compare
Source](https://togithub.com/kubernetes/client-go/compare/v0.28.4...v0.29.0 )
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "before 4am" (UTC), Automerge -
"before 4am" (UTC).
🚦 **Automerge**: Enabled.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions ) if
that's undesired.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/ ). View
repository job log
[here](https://developer.mend.io/github/woodpecker-ci/woodpecker ).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy45My4xIiwidXBkYXRlZEluVmVyIjoiMzcuOTMuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
---------
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Robert Kaussow <mail@thegeeklab.de>
2023-12-17 14:37:26 +01:00
6543
1f8b3b5e1b
Only update pipelineStatus in one place ( #2952 )
2023-12-15 10:03:05 +01:00
qwerty287
ff1f51d6a9
Rename engine to backend ( #2950 )
...
rename based on https://woodpecker-ci.org/docs/usage/terminiology
---------
Co-authored-by: 6543 <6543@obermui.de>
2023-12-14 19:20:47 +01:00
gapanyc
547f5dea35
Init CI_COMMIT_TAG if commit ref is a tag ( #2934 )
...
When triggering a deployment event on an existing pipeline, there is no
way to get the tag used to trigger the parent pipeline, even if this
parent was a tag event.
In our company CI/CD current setup with drone, we use the tag event to
trigger a kaniko image build step, using the git tag as an image tag,
and the deployment/promotion step to effectively deploy this image using
the tag reference in our cluster. This is the only point blocking us to
completely switch to woodpecker and get rid of drone...
What's done:
- changed the metadata environ() method to populate CI_COMMIT_TAG env
var if commit ref starts with /refs/tags (like it's done in drone),
independently of event type EventTag.
Please let me know if I'm wrong, I will happily contribute in this nice
project.
---------
Co-authored-by: Christian Gapany <christian.gapany@netplus.pro>
Co-authored-by: Lauris BH <lauris@nix.lv>
2023-12-12 18:05:06 +02:00
Nikolai Rodionov
b3541e314e
fix: Add backend_options to service linter entry ( #2930 )
...
I've tried setting resources for a service and have seen the linter
warning that is not supported, though the the pipeline was successful
and resources were actually set on the pod. So I assume it shouldn't be
a linter issue.
I"m also not sure if my change is correct, I only hope it is
## Some Context
A pipeline example (I've removed steps that are not related directly:
```yaml
---
steps:
test:
name: Test charts
image: quay.io/helmpack/chart-testing
environment:
- DOCKER_HOST=tcp://docker:2375
commands:
- export PATH=$PWD/.bin:$PATH
- apk update && apk add docker
- kind create cluster --config kind.yaml
- sed -i -E -e 's/localhost|0\.0\.0\.0/docker/g' ~/.kube/config
- git fetch origin
- |
if [ -e .changed ]; then
ct install --target-branch main --chart-dirs .
ct install --target-branch main --chart-dirs . --upgrade
fi
services:
docker:
image: docker:dind
commands: dockerd -H tcp://0.0.0.0:2375 --tls=false
privileged: true
ports:
- 2375
backend_options:
kubernetes:
resources:
requests:
memory: 400Mi
cpu: 100m
limits:
memory: 400Mi
cpu: 100m
```
Pod description:
```
Containers:
wp-01hhczdknafj81jv80gzjbgt93-0-services-0:
Limits:
cpu: 100m
memory: 400Mi
Requests:
cpu: 100m
memory: 400Mi
```
Warning in the Woodpecker UI:
```
[linter]woodpecker: services.dockerAdditional property backend_options is not allowed
```
2023-12-11 19:22:55 +01:00
