virtualenv/FFmpeg
1
0
Fork 0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2024-12-12 19:18:44 +02:00
Code Issues Releases Activity
ab38a48c48
FFmpeg/tests/ref/fate/matroska-flac-extradata-update

54 lines
2.3 KiB
Plaintext
Raw Normal View History

avformat/matroskaenc: Don't ignore tags of chapters written late The Matroska muxer writes the Chapters early when chapters were already available when writing the header; in this case any tags pertaining to these chapters get written, too. Yet if no chapters had been supplied before writing the header, Chapters can also be written when writing the trailer if any are supplied. Tags belonging to these chapters were up until now completely ignored. This commit changes this: Writing the tags belonging to chapters has been moved to mkv_write_chapters(). If mkv_write_tags() has not been called yet (i.e. when chapters are written when writing the header), the AVIOContext for writing the ordinary Tags element is used, but not output, as this is left to mkv_write_tags() in order to only write one Tags element. Yet if mkv_write_tags() has already been called, mkv_write_chapters() will output a Tags element of its own which only contains the tags for chapters. When chapters are available initially, the corresponding tags will now be the first tags in the Tags element; but the ordering of tags in Tags is irrelevant anyway. This commit also makes chapter_id_offset local to mkv_write_chapters() as it is used only there and not reused at all. Potentially writing a second Tags element means that the maximum number of SeekHead entries had to be incremented. All the changes to FATE result from the ensuing increase in the amount of space reserved for the SeekHead (21 bytes more). Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
2020-04-29 10:27:23 +02:00
3c721898cf2cf3e2e6c43ad58952bd2d *tests/data/fate/matroska-flac-extradata-update.matroska
2032 tests/data/fate/matroska-flac-extradata-update.matroska
fate/matroska: Add test for updating CodecPrivate from packet sidedata containing updated extradata, in this case a new FLAC streaminfo. Furthermore, it also tests that the Matroska muxer is able to preserve uncommon channel layouts by adding Vorbis comments to the CodecPrivate. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
2020-04-01 20:22:29 +02:00
#extradata 0: 34, 0x7acb09e7
#extradata 1: 34, 0x7acb09e7
#extradata 2: 34, 0x443402dd
#tb 0: 1/1000
#media_type 0: audio
#codec_id 0: flac
#sample_rate 0: 48000
#channel_layout 0: 3f
#channel_layout_name 0: 5.1
#tb 1: 1/1000
#media_type 1: audio
#codec_id 1: flac
#sample_rate 1: 48000
#channel_layout 1: 60f
#channel_layout_name 1: 5.1(side)
#tb 2: 1/1000
#media_type 2: audio
#codec_id 2: flac
#sample_rate 2: 48000
#channel_layout 2: 3f
#channel_layout_name 2: 5.1
0, 0, 0, 96, 26, 0x4e160341
1, 0, 0, 96, 26, 0x4e160341
2, 0, 0, 96, 26, 0x4e160341
0, 96, 96, 96, 26, 0x4e17035c
1, 96, 96, 96, 26, 0x4e17035c
2, 96, 96, 96, 26, 0x4e17035c
0, 192, 192, 96, 26, 0x4de40383
1, 192, 192, 96, 26, 0x4de40383
2, 192, 192, 96, 26, 0x4de40383
0, 288, 288, 96, 26, 0x4e3903a2
1, 288, 288, 96, 26, 0x4e3903a2
2, 288, 288, 96, 26, 0x4e3903a2
0, 384, 384, 96, 26, 0x4f9a03d5
1, 384, 384, 96, 26, 0x4f9a03d5
2, 384, 384, 96, 26, 0x4f9a03d5
0, 480, 480, 96, 26, 0x501303e0
1, 480, 480, 96, 26, 0x501303e0
2, 480, 480, 96, 26, 0x501303e0
0, 576, 576, 96, 26, 0x5160042f
1, 576, 576, 96, 26, 0x5160042f
2, 576, 576, 96, 26, 0x5160042f
0, 672, 672, 96, 26, 0x50dd042e
1, 672, 672, 96, 26, 0x50dd042e
2, 672, 672, 96, 26, 0x50dd042e
0, 768, 768, 96, 26, 0x53de0499
1, 768, 768, 96, 26, 0x53de0499
0, 864, 864, 96, 26, 0x53df04b4
1, 864, 864, 96, 26, 0x53df04b4
0, 960, 960, 42, 26, 0x5740044b
1, 960, 960, 42, 26, 0x5740044b
Reference in New Issue Copy Permalink