2011-09-19 06:13:30 +02:00
|
|
|
/*
|
2012-09-06 21:23:09 +02:00
|
|
|
* Copyright (C) 2011-2012 Michael Niedermayer (michaelni@gmx.at)
|
2011-09-19 06:13:30 +02:00
|
|
|
*
|
|
|
|
|
* This file is part of libswresample
|
|
|
|
|
*
|
|
|
|
|
* libswresample is free software; you can redistribute it and/or
|
|
|
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
|
|
|
* License as published by the Free Software Foundation; either
|
|
|
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
|
|
|
*
|
|
|
|
|
* libswresample is distributed in the hope that it will be useful,
|
|
|
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
|
* Lesser General Public License for more details.
|
|
|
|
|
*
|
|
|
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
|
|
|
* License along with libswresample; if not, write to the Free Software
|
|
|
|
|
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
|
|
|
|
|
*/
|
|
|
|
|
|
2012-11-14 23:02:12 +01:00
|
|
|
#if defined(TEMPLATE_REMATRIX_FLT)
|
|
|
|
|
# define R(x) x
|
|
|
|
|
# define SAMPLE float
|
|
|
|
|
# define COEFF float
|
|
|
|
|
# define INTER float
|
|
|
|
|
# define RENAME(x) x ## _float
|
|
|
|
|
#elif defined(TEMPLATE_REMATRIX_DBL)
|
|
|
|
|
# define R(x) x
|
|
|
|
|
# define SAMPLE double
|
|
|
|
|
# define COEFF double
|
|
|
|
|
# define INTER double
|
|
|
|
|
# define RENAME(x) x ## _double
|
|
|
|
|
#elif defined(TEMPLATE_REMATRIX_S16)
|
|
|
|
|
# define SAMPLE int16_t
|
|
|
|
|
# define COEFF int
|
|
|
|
|
# define INTER int
|
2016-05-15 21:34:37 +02:00
|
|
|
# ifdef TEMPLATE_CLIP
|
|
|
|
|
# define R(x) av_clip_int16(((x) + 16384)>>15)
|
|
|
|
|
# define RENAME(x) x ## _clip_s16
|
|
|
|
|
# else
|
|
|
|
|
# define R(x) (((x) + 16384)>>15)
|
2012-11-14 23:02:12 +01:00
|
|
|
# define RENAME(x) x ## _s16
|
2016-05-15 21:34:37 +02:00
|
|
|
# endif
|
2013-06-04 14:54:58 +02:00
|
|
|
#elif defined(TEMPLATE_REMATRIX_S32)
|
|
|
|
|
# define R(x) (((x) + 16384)>>15)
|
|
|
|
|
# define SAMPLE int32_t
|
|
|
|
|
# define COEFF int
|
|
|
|
|
# define INTER int64_t
|
|
|
|
|
# define RENAME(x) x ## _s32
|
2012-11-14 23:02:12 +01:00
|
|
|
#endif
|
|
|
|
|
|
swresample/rematrix: Use correct function pointer types for calls
Calling a function via a different function pointer type is
undefined behavior (C11, 6.3.2.3 8); two pointer parameters
of different type are not equivalent in this regard, although
it happens to work in practice; the current code relies on this.
This patch brings the code in line with the spec. This fixes the
following FATE-tests when run with Clang-UBSan:
ac3-fixed-encode-2 audiomatch-afconvert-{16000,44100}-mono-he-{adts,m4a}
audiomatch-dolby-44100-mono-he-mp4 filter-metadata-avf-aphase-meter-mono
filter-pan-{downmix1,downmix2,mono2,stereo2,stereo3,stereo4,upmix1,upmix2}
lavf-dv_{pal,ntsc} matroska-encoding-delay
The error was something like
src/libswresample/rematrix.c:621:17: runtime error: call to function sum2_float through pointer to incorrect function type 'void (*)(void *, const void *, const void *, void *, int, int, int)
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
2025-06-23 02:02:54 +02:00
|
|
|
static void RENAME(sum2)(void *out_, const void *in1_, const void *in2_,
|
2025-06-23 02:15:00 +02:00
|
|
|
const void *coeffp_, integer index1, integer index2, integer len)
|
swresample/rematrix: Use correct function pointer types for calls
Calling a function via a different function pointer type is
undefined behavior (C11, 6.3.2.3 8); two pointer parameters
of different type are not equivalent in this regard, although
it happens to work in practice; the current code relies on this.
This patch brings the code in line with the spec. This fixes the
following FATE-tests when run with Clang-UBSan:
ac3-fixed-encode-2 audiomatch-afconvert-{16000,44100}-mono-he-{adts,m4a}
audiomatch-dolby-44100-mono-he-mp4 filter-metadata-avf-aphase-meter-mono
filter-pan-{downmix1,downmix2,mono2,stereo2,stereo3,stereo4,upmix1,upmix2}
lavf-dv_{pal,ntsc} matroska-encoding-delay
The error was something like
src/libswresample/rematrix.c:621:17: runtime error: call to function sum2_float through pointer to incorrect function type 'void (*)(void *, const void *, const void *, void *, int, int, int)
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
2025-06-23 02:02:54 +02:00
|
|
|
{
|
|
|
|
|
const SAMPLE *in1 = in1_, *in2 = in2_;
|
|
|
|
|
const COEFF *coeffp = coeffp_;
|
|
|
|
|
SAMPLE *out = out_;
|
2011-09-19 06:13:30 +02:00
|
|
|
int i;
|
2013-06-04 14:53:58 +02:00
|
|
|
INTER coeff1 = coeffp[index1];
|
|
|
|
|
INTER coeff2 = coeffp[index2];
|
2011-09-19 06:13:30 +02:00
|
|
|
|
|
|
|
|
for(i=0; i<len; i++)
|
2011-09-19 09:18:05 +02:00
|
|
|
out[i] = R(coeff1*in1[i] + coeff2*in2[i]);
|
2011-09-19 06:13:30 +02:00
|
|
|
}
|
|
|
|
|
|
2025-06-23 02:15:00 +02:00
|
|
|
static void RENAME(copy)(void *out_, const void *in_, const void *coeffp_,
|
|
|
|
|
integer index, integer len)
|
swresample/rematrix: Use correct function pointer types for calls
Calling a function via a different function pointer type is
undefined behavior (C11, 6.3.2.3 8); two pointer parameters
of different type are not equivalent in this regard, although
it happens to work in practice; the current code relies on this.
This patch brings the code in line with the spec. This fixes the
following FATE-tests when run with Clang-UBSan:
ac3-fixed-encode-2 audiomatch-afconvert-{16000,44100}-mono-he-{adts,m4a}
audiomatch-dolby-44100-mono-he-mp4 filter-metadata-avf-aphase-meter-mono
filter-pan-{downmix1,downmix2,mono2,stereo2,stereo3,stereo4,upmix1,upmix2}
lavf-dv_{pal,ntsc} matroska-encoding-delay
The error was something like
src/libswresample/rematrix.c:621:17: runtime error: call to function sum2_float through pointer to incorrect function type 'void (*)(void *, const void *, const void *, void *, int, int, int)
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
2025-06-23 02:02:54 +02:00
|
|
|
{
|
|
|
|
|
const COEFF *coeffp = coeffp_;
|
|
|
|
|
const SAMPLE *in = in_;
|
|
|
|
|
SAMPLE *out = out_;
|
2012-05-01 20:20:21 +02:00
|
|
|
int i;
|
2013-06-04 14:53:58 +02:00
|
|
|
INTER coeff = coeffp[index];
|
2012-05-01 20:20:21 +02:00
|
|
|
for(i=0; i<len; i++)
|
|
|
|
|
out[i] = R(coeff*in[i]);
|
2011-09-19 06:13:30 +02:00
|
|
|
}
|
|
|
|
|
|
2025-06-23 02:15:00 +02:00
|
|
|
static void RENAME(mix6to2)(uint8_t *const *out_, const uint8_t *const *in_,
|
|
|
|
|
const void *coeffp_, integer len)
|
swresample/rematrix: Use correct function pointer types for calls
Calling a function via a different function pointer type is
undefined behavior (C11, 6.3.2.3 8); two pointer parameters
of different type are not equivalent in this regard, although
it happens to work in practice; the current code relies on this.
This patch brings the code in line with the spec. This fixes the
following FATE-tests when run with Clang-UBSan:
ac3-fixed-encode-2 audiomatch-afconvert-{16000,44100}-mono-he-{adts,m4a}
audiomatch-dolby-44100-mono-he-mp4 filter-metadata-avf-aphase-meter-mono
filter-pan-{downmix1,downmix2,mono2,stereo2,stereo3,stereo4,upmix1,upmix2}
lavf-dv_{pal,ntsc} matroska-encoding-delay
The error was something like
src/libswresample/rematrix.c:621:17: runtime error: call to function sum2_float through pointer to incorrect function type 'void (*)(void *, const void *, const void *, void *, int, int, int)
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
2025-06-23 02:02:54 +02:00
|
|
|
{
|
|
|
|
|
const SAMPLE *const *const in = (const SAMPLE *const *)in_;
|
|
|
|
|
SAMPLE *const *const out = (SAMPLE *const*)out_;
|
|
|
|
|
const COEFF *coeffp = coeffp_;
|
2012-06-08 21:56:20 +02:00
|
|
|
int i;
|
|
|
|
|
|
|
|
|
|
for(i=0; i<len; i++) {
|
2013-06-10 02:39:48 +02:00
|
|
|
INTER t = in[2][i]*(INTER)coeffp[0*6+2] + in[3][i]*(INTER)coeffp[0*6+3];
|
2013-06-04 14:53:58 +02:00
|
|
|
out[0][i] = R(t + in[0][i]*(INTER)coeffp[0*6+0] + in[4][i]*(INTER)coeffp[0*6+4]);
|
|
|
|
|
out[1][i] = R(t + in[1][i]*(INTER)coeffp[1*6+1] + in[5][i]*(INTER)coeffp[1*6+5]);
|
2012-06-08 21:56:20 +02:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2025-06-23 02:15:00 +02:00
|
|
|
static void RENAME(mix8to2)(uint8_t *const *out_, const uint8_t *const *in_,
|
|
|
|
|
const void *coeffp_, integer len)
|
swresample/rematrix: Use correct function pointer types for calls
Calling a function via a different function pointer type is
undefined behavior (C11, 6.3.2.3 8); two pointer parameters
of different type are not equivalent in this regard, although
it happens to work in practice; the current code relies on this.
This patch brings the code in line with the spec. This fixes the
following FATE-tests when run with Clang-UBSan:
ac3-fixed-encode-2 audiomatch-afconvert-{16000,44100}-mono-he-{adts,m4a}
audiomatch-dolby-44100-mono-he-mp4 filter-metadata-avf-aphase-meter-mono
filter-pan-{downmix1,downmix2,mono2,stereo2,stereo3,stereo4,upmix1,upmix2}
lavf-dv_{pal,ntsc} matroska-encoding-delay
The error was something like
src/libswresample/rematrix.c:621:17: runtime error: call to function sum2_float through pointer to incorrect function type 'void (*)(void *, const void *, const void *, void *, int, int, int)
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
2025-06-23 02:02:54 +02:00
|
|
|
{
|
|
|
|
|
const SAMPLE *const *const in = (const SAMPLE *const *)in_;
|
|
|
|
|
SAMPLE *const *const out = (SAMPLE *const*)out_;
|
|
|
|
|
const COEFF *coeffp = coeffp_;
|
2012-06-08 22:12:00 +02:00
|
|
|
int i;
|
|
|
|
|
|
|
|
|
|
for(i=0; i<len; i++) {
|
2013-06-10 02:46:03 +02:00
|
|
|
INTER t = in[2][i]*(INTER)coeffp[0*8+2] + in[3][i]*(INTER)coeffp[0*8+3];
|
2013-06-04 14:53:58 +02:00
|
|
|
out[0][i] = R(t + in[0][i]*(INTER)coeffp[0*8+0] + in[4][i]*(INTER)coeffp[0*8+4] + in[6][i]*(INTER)coeffp[0*8+6]);
|
|
|
|
|
out[1][i] = R(t + in[1][i]*(INTER)coeffp[1*8+1] + in[5][i]*(INTER)coeffp[1*8+5] + in[7][i]*(INTER)coeffp[1*8+7]);
|
2012-06-08 22:12:00 +02:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2025-09-12 18:33:12 +02:00
|
|
|
static mix_any_func_type *RENAME(get_mix_any_func)(const SwrContext *s)
|
swresample/rematrix: Use correct function pointer types for calls
Calling a function via a different function pointer type is
undefined behavior (C11, 6.3.2.3 8); two pointer parameters
of different type are not equivalent in this regard, although
it happens to work in practice; the current code relies on this.
This patch brings the code in line with the spec. This fixes the
following FATE-tests when run with Clang-UBSan:
ac3-fixed-encode-2 audiomatch-afconvert-{16000,44100}-mono-he-{adts,m4a}
audiomatch-dolby-44100-mono-he-mp4 filter-metadata-avf-aphase-meter-mono
filter-pan-{downmix1,downmix2,mono2,stereo2,stereo3,stereo4,upmix1,upmix2}
lavf-dv_{pal,ntsc} matroska-encoding-delay
The error was something like
src/libswresample/rematrix.c:621:17: runtime error: call to function sum2_float through pointer to incorrect function type 'void (*)(void *, const void *, const void *, void *, int, int, int)
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
2025-06-23 02:02:54 +02:00
|
|
|
{
|
2021-08-27 00:37:53 -03:00
|
|
|
if ( !av_channel_layout_compare(&s->out_ch_layout, &(AVChannelLayout)AV_CHANNEL_LAYOUT_STEREO)
|
|
|
|
|
&& ( !av_channel_layout_compare(&s->in_ch_layout, &(AVChannelLayout)AV_CHANNEL_LAYOUT_5POINT1)
|
|
|
|
|
|| !av_channel_layout_compare(&s->in_ch_layout, &(AVChannelLayout)AV_CHANNEL_LAYOUT_5POINT1_BACK))
|
2012-06-08 21:56:20 +02:00
|
|
|
&& s->matrix[0][2] == s->matrix[1][2] && s->matrix[0][3] == s->matrix[1][3]
|
|
|
|
|
&& !s->matrix[0][1] && !s->matrix[0][5] && !s->matrix[1][0] && !s->matrix[1][4]
|
|
|
|
|
)
|
|
|
|
|
return RENAME(mix6to2);
|
|
|
|
|
|
2021-08-27 00:37:53 -03:00
|
|
|
if ( !av_channel_layout_compare(&s->out_ch_layout, &(AVChannelLayout)AV_CHANNEL_LAYOUT_STEREO)
|
|
|
|
|
&& !av_channel_layout_compare(&s->in_ch_layout, &(AVChannelLayout)AV_CHANNEL_LAYOUT_7POINT1)
|
2012-06-08 22:12:00 +02:00
|
|
|
&& s->matrix[0][2] == s->matrix[1][2] && s->matrix[0][3] == s->matrix[1][3]
|
|
|
|
|
&& !s->matrix[0][1] && !s->matrix[0][5] && !s->matrix[1][0] && !s->matrix[1][4]
|
|
|
|
|
&& !s->matrix[0][7] && !s->matrix[1][6]
|
|
|
|
|
)
|
|
|
|
|
return RENAME(mix8to2);
|
|
|
|
|
|
2012-06-08 21:56:20 +02:00
|
|
|
return NULL;
|
|
|
|
|
}
|
2012-11-14 23:02:12 +01:00
|
|
|
|
|
|
|
|
#undef R
|
|
|
|
|
#undef SAMPLE
|
|
|
|
|
#undef COEFF
|
|
|
|
|
#undef INTER
|
|
|
|
|
#undef RENAME
|