virtualenv/FFmpeg
1
0
Fork 0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2024-12-23 12:43:46 +02:00
Code Issues Releases Activity

avcodec/encode: unref the packet on AVCodec.receive_packet() failure

Browse Source 
Fixes memleaks with some encoders that don't unref the packet before
returning.
This is consistent with the behavior of AVCodec.encode()
implementations in encode_simple_internal().

Found-by: mkver
Reviewed-by: Anton Khirnov <anton@khirnov.net>
Signed-off-by: James Almer <jamrial@gmail.com>
This commit is contained in:
James Almer 2020-08-30 23:57:23 -03:00
parent 2a14d55a7c
commit 0271098e6c
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libavcodec/encode.c
View File

@ -242,7 +242,9 @@ static int encode_receive_packet_internal(AVCodecContext *avctx, AVPacket *avpkt
if (avctx->codec->receive_packet) { if (avctx->codec->receive_packet) {
ret = avctx->codec->receive_packet(avctx, avpkt); ret = avctx->codec->receive_packet(avctx, avpkt);
if (!ret) if (ret < 0)
av_packet_unref(avpkt);
else
// Encoders must always return ref-counted buffers. // Encoders must always return ref-counted buffers.
// Side-data only packets have no data and can be not ref-counted. // Side-data only packets have no data and can be not ref-counted.
av_assert0(!avpkt->data || avpkt->buf); av_assert0(!avpkt->data || avpkt->buf);