diff --git a/cmdutils.c b/cmdutils.c index 5639751e3a..61843b4f11 100644 --- a/cmdutils.c +++ b/cmdutils.c @@ -126,7 +126,7 @@ double parse_number_or_die(const char *context, const char *numstr, int type, else return d; av_log(NULL, AV_LOG_FATAL, error, context, numstr, min, max); - exit_program(1); + exit(1); return 0; } @@ -137,7 +137,7 @@ int64_t parse_time_or_die(const char *context, const char *timestr, if (av_parse_time(&us, timestr, is_duration) < 0) { av_log(NULL, AV_LOG_FATAL, "Invalid %s specification for %s: %s\n", is_duration ? "duration" : "date", context, timestr); - exit_program(1); + exit(1); } return us; } @@ -325,7 +325,7 @@ int parse_option(void *optctx, const char *opt, const char *arg, } } if (po->flags & OPT_EXIT) - exit_program(0); + exit(0); return !!(po->flags & HAS_ARG); } @@ -351,7 +351,7 @@ void parse_options(void *optctx, int argc, char **argv, const OptionDef *options opt++; if ((ret = parse_option(optctx, opt, argv[optindex], options)) < 0) - exit_program(1); + exit(1); optindex += ret; } else { if (parse_arg_function) @@ -511,7 +511,7 @@ int opt_loglevel(void *optctx, const char *opt, const char *arg) "Possible levels are numbers or:\n", arg); for (i = 0; i < FF_ARRAY_ELEMS(log_levels); i++) av_log(NULL, AV_LOG_FATAL, "\"%s\"\n", log_levels[i].name); - exit_program(1); + exit(1); } av_log_set_level(level); return 0; @@ -557,7 +557,7 @@ int opt_max_alloc(void *optctx, const char *opt, const char *arg) max = strtol(arg, &tail, 10); if (*tail) { av_log(NULL, AV_LOG_FATAL, "Invalid max_alloc \"%s\".\n", arg); - exit_program(1); + exit(1); } av_max_alloc(max); return 0; @@ -909,7 +909,7 @@ static unsigned get_codecs_sorted(const AVCodecDescriptor ***rcodecs) nb_codecs++; if (!(codecs = av_calloc(nb_codecs, sizeof(*codecs)))) { av_log(0, AV_LOG_ERROR, "Out of memory\n"); - exit_program(1); + exit(1); } desc = NULL; while ((desc = avcodec_descriptor_next(desc))) @@ -1467,13 +1467,13 @@ void *grow_array(void *array, int elem_size, int *size, int new_size) { if (new_size >= INT_MAX / elem_size) { av_log(NULL, AV_LOG_ERROR, "Array too big.\n"); - exit_program(1); + exit(1); } if (*size < new_size) { uint8_t *tmp = av_realloc(array, new_size*elem_size); if (!tmp) { av_log(NULL, AV_LOG_ERROR, "Could not alloc buffer.\n"); - exit_program(1); + exit(1); } memset(tmp + *size*elem_size, 0, (new_size-*size) * elem_size); *size = new_size; diff --git a/cmdutils.h b/cmdutils.h index d78eb55b44..1973c07317 100644 --- a/cmdutils.h +++ b/cmdutils.h @@ -410,15 +410,9 @@ int cmdutils_read_file(const char *filename, char **bufptr, size_t *size); FILE *get_preset_file(char *filename, size_t filename_size, const char *preset_name, int is_path, const char *codec_name); -/** - * Do all the necessary cleanup and abort. - * This function is implemented in the avtools, not cmdutils. - */ -av_noreturn void exit_program(int ret); - /** * Realloc array to hold new_size elements of elem_size. - * Calls exit_program() on failure. + * Calls exit() on failure. * * @param elem_size size in bytes of each element * @param size new element count will be written here diff --git a/configure b/configure index 65394080da..a2ca9f68f5 100755 --- a/configure +++ b/configure @@ -2410,6 +2410,8 @@ msvc_flags(){ -fno-common) ;; -fno-signed-zeros) ;; -lz) echo zlib.lib ;; + -lavifil32) echo vfw32.lib ;; + -lavicap32) echo vfw32.lib user32.lib ;; -l*) echo ${flag#-l}.lib ;; *) echo $flag ;; esac diff --git a/ffmpeg.c b/ffmpeg.c index e0cd1e6149..a9e5c548fe 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -378,7 +378,7 @@ static int decode_interrupt_cb(void *ctx) const AVIOInterruptCB int_cb = { decode_interrupt_cb, NULL }; -void av_noreturn exit_program(int ret) +static void exit_program() { int i, j; @@ -456,8 +456,6 @@ void av_noreturn exit_program(int ret) (int) received_sigterm); exit (255); } - - exit(ret); } void assert_avoptions(AVDictionary *m) @@ -465,7 +463,7 @@ void assert_avoptions(AVDictionary *m) AVDictionaryEntry *t; if ((t = av_dict_get(m, "", NULL, AV_DICT_IGNORE_SUFFIX))) { av_log(NULL, AV_LOG_FATAL, "Option %s not found.\n", t->key); - exit_program(1); + exit(1); } } @@ -482,7 +480,7 @@ static void assert_codec_experimental(AVCodecContext *c, int encoder) if (!(codec->capabilities & CODEC_CAP_EXPERIMENTAL)) av_log(NULL, AV_LOG_FATAL, "Or use the non experimental %s '%s'.\n", codec_string, codec->name); - exit_program(1); + exit(1); } } @@ -564,7 +562,7 @@ static void write_frame(AVFormatContext *s, AVPacket *pkt, OutputStream *ost) avctx->codec ? avctx->codec->name : "copy"); print_error("", a); if (exit_on_error) - exit_program(1); + exit(1); } *pkt = new_pkt; @@ -586,7 +584,7 @@ static void write_frame(AVFormatContext *s, AVPacket *pkt, OutputStream *ost) ret = av_interleaved_write_frame(s, pkt); if (ret < 0) { print_error("av_interleaved_write_frame()", ret); - exit_program(1); + exit(1); } } @@ -637,7 +635,7 @@ static void do_audio_out(AVFormatContext *s, OutputStream *ost, update_benchmark(NULL); if (avcodec_encode_audio2(enc, &pkt, frame, &got_packet) < 0) { av_log(NULL, AV_LOG_FATAL, "Audio encoding failed (avcodec_encode_audio2)\n"); - exit_program(1); + exit(1); } update_benchmark("encode_audio %d.%d", ost->file_index, ost->index); @@ -716,7 +714,7 @@ static void do_subtitle_out(AVFormatContext *s, if (sub->pts == AV_NOPTS_VALUE) { av_log(NULL, AV_LOG_ERROR, "Subtitle packets must have a pts\n"); if (exit_on_error) - exit_program(1); + exit(1); return; } @@ -752,7 +750,7 @@ static void do_subtitle_out(AVFormatContext *s, subtitle_out_max_size, sub); if (subtitle_out_size < 0) { av_log(NULL, AV_LOG_FATAL, "Subtitle encoding failed\n"); - exit_program(1); + exit(1); } av_init_packet(&pkt); @@ -895,7 +893,7 @@ static void do_video_out(AVFormatContext *s, update_benchmark("encode_video %d.%d", ost->file_index, ost->index); if (ret < 0) { av_log(NULL, AV_LOG_FATAL, "Video encoding failed\n"); - exit_program(1); + exit(1); } if (got_packet) { @@ -955,7 +953,7 @@ static void do_video_stats(AVFormatContext *os, OutputStream *ost, vstats_file = fopen(vstats_filename, "w"); if (!vstats_file) { perror("fopen"); - exit_program(1); + exit(1); } } @@ -1288,7 +1286,7 @@ static void flush_encoders(void) update_benchmark("flush %s %d.%d", desc, ost->file_index, ost->index); if (ret < 0) { av_log(NULL, AV_LOG_FATAL, "%s encoding failed\n", desc); - exit_program(1); + exit(1); } *size += pkt.size; if (ost->logfile && enc->stats_out) { @@ -1481,7 +1479,7 @@ static int decode_audio(InputStream *ist, AVPacket *pkt, int *got_output) av_log(NULL, AV_LOG_FATAL, "Unable to find default channel " "layout for Input Stream #%d.%d\n", ist->file_index, ist->st->index); - exit_program(1); + exit(1); } decoded_frame->channel_layout = avctx->channel_layout; @@ -1509,7 +1507,7 @@ static int decode_audio(InputStream *ist, AVPacket *pkt, int *got_output) int j; if (configure_filtergraph(fg) < 0) { av_log(NULL, AV_LOG_FATAL, "Error reinitializing filters!\n"); - exit_program(1); + exit(1); } for (j = 0; j < fg->nb_outputs; j++) { OutputStream *ost = fg->outputs[j]->ost; @@ -1624,7 +1622,7 @@ static int decode_video(InputStream *ist, AVPacket *pkt, int *got_output) if (ist_in_filtergraph(filtergraphs[i], ist) && configure_filtergraph(filtergraphs[i]) < 0) { av_log(NULL, AV_LOG_FATAL, "Error reinitializing filters!\n"); - exit_program(1); + exit(1); } } @@ -1660,7 +1658,7 @@ static int decode_video(InputStream *ist, AVPacket *pkt, int *got_output) } else if(av_buffersrc_add_frame(ist->filters[i]->filter, decoded_frame, AV_BUFFERSRC_FLAG_PUSH)<0) { av_log(NULL, AV_LOG_FATAL, "Failed to inject frame into filter network\n"); - exit_program(1); + exit(1); } } @@ -1859,7 +1857,7 @@ static void print_sdp(void) AVFormatContext **avc = av_malloc(sizeof(*avc) * nb_output_files); if (!avc) - exit_program(1); + exit(1); for (i = 0; i < nb_output_files; i++) avc[i] = output_files[i]->ctx; @@ -1927,7 +1925,7 @@ static void parse_forced_key_frames(char *kf, OutputStream *ost, ost->forced_kf_pts = av_malloc(sizeof(*ost->forced_kf_pts) * n); if (!ost->forced_kf_pts) { av_log(NULL, AV_LOG_FATAL, "Could not allocate forced key frames array.\n"); - exit_program(1); + exit(1); } p = kf; @@ -2093,7 +2091,7 @@ static int transcode_init(void) case AVMEDIA_TYPE_AUDIO: if (audio_volume != 256) { av_log(NULL, AV_LOG_FATAL, "-acodec copy and -vol are incompatible (frames are not decoded)\n"); - exit_program(1); + exit(1); } codec->channel_layout = icodec->channel_layout; codec->sample_rate = icodec->sample_rate; @@ -2240,7 +2238,7 @@ static int transcode_init(void) if (cmdutils_read_file(logfilename, &logbuffer, &logbuffer_size) < 0) { av_log(NULL, AV_LOG_FATAL, "Error reading log file '%s' for pass-2 encoding\n", logfilename); - exit_program(1); + exit(1); } codec->stats_in = logbuffer; } @@ -2249,7 +2247,7 @@ static int transcode_init(void) if (!f) { av_log(NULL, AV_LOG_FATAL, "Cannot write log file '%s' for pass-1 encoding: %s\n", logfilename, strerror(errno)); - exit_program(1); + exit(1); } ost->logfile = f; } @@ -2724,7 +2722,7 @@ static int process_input(int file_index) if (ret != AVERROR_EOF) { print_error(is->filename, ret); if (exit_on_error) - exit_program(1); + exit(1); } ifile->eof_reached = 1; @@ -2845,7 +2843,7 @@ static int process_input(int file_index) av_log(NULL, AV_LOG_ERROR, "Error while decoding stream #%d:%d: %s\n", ist->file_index, ist->st->index, buf); if (exit_on_error) - exit_program(1); + exit(1); } discard_packet: @@ -3119,6 +3117,8 @@ int main(int argc, char **argv) OptionsContext o = { 0 }; int64_t ti; + atexit(exit_program); + reset_options(&o, 0); setvbuf(stderr,NULL,_IONBF,0); /* win32 runtime needs this */ @@ -3153,29 +3153,29 @@ int main(int argc, char **argv) if (nb_output_files <= 0 && nb_input_files == 0) { show_usage(); av_log(NULL, AV_LOG_WARNING, "Use -h to get full help or, even better, run 'man %s'\n", program_name); - exit_program(1); + exit(1); } /* file converter / grab */ if (nb_output_files <= 0) { av_log(NULL, AV_LOG_FATAL, "At least one output file must be specified\n"); - exit_program(1); + exit(1); } // if (nb_input_files == 0) { // av_log(NULL, AV_LOG_FATAL, "At least one input file must be specified\n"); -// exit_program(1); +// exit(1); // } current_time = ti = getutime(); if (transcode() < 0) - exit_program(1); + exit(1); ti = getutime() - ti; if (do_benchmark) { int maxrss = getmaxrss() / 1024; printf("bench: utime=%0.3fs maxrss=%ikB\n", ti / 1000000.0, maxrss); } - exit_program(0); + exit(0); return 0; } diff --git a/ffmpeg_filter.c b/ffmpeg_filter.c index 8478edf0a5..318143d479 100644 --- a/ffmpeg_filter.c +++ b/ffmpeg_filter.c @@ -106,7 +106,7 @@ static char *choose_pix_fmts(OutputStream *ost) int len; if (avio_open_dyn_buf(&s) < 0) - exit_program(1); + exit(1); p = ost->enc->pix_fmts; if (ost->st->codec->strict_std_compliance <= FF_COMPLIANCE_UNOFFICIAL) { @@ -146,7 +146,7 @@ static char *choose_ ## var ## s(OutputStream *ost) \ int len; \ \ if (avio_open_dyn_buf(&s) < 0) \ - exit_program(1); \ + exit(1); \ \ for (p = ost->enc->supported_list; *p != none; p++) { \ get_name(*p); \ @@ -176,13 +176,13 @@ FilterGraph *init_simple_filtergraph(InputStream *ist, OutputStream *ost) FilterGraph *fg = av_mallocz(sizeof(*fg)); if (!fg) - exit_program(1); + exit(1); fg->index = nb_filtergraphs; fg->outputs = grow_array(fg->outputs, sizeof(*fg->outputs), &fg->nb_outputs, fg->nb_outputs + 1); if (!(fg->outputs[0] = av_mallocz(sizeof(*fg->outputs[0])))) - exit_program(1); + exit(1); fg->outputs[0]->ost = ost; fg->outputs[0]->graph = fg; @@ -191,7 +191,7 @@ FilterGraph *init_simple_filtergraph(InputStream *ist, OutputStream *ost) fg->inputs = grow_array(fg->inputs, sizeof(*fg->inputs), &fg->nb_inputs, fg->nb_inputs + 1); if (!(fg->inputs[0] = av_mallocz(sizeof(*fg->inputs[0])))) - exit_program(1); + exit(1); fg->inputs[0]->ist = ist; fg->inputs[0]->graph = fg; @@ -216,7 +216,7 @@ static void init_input_filter(FilterGraph *fg, AVFilterInOut *in) if (type != AVMEDIA_TYPE_VIDEO && type != AVMEDIA_TYPE_AUDIO) { av_log(NULL, AV_LOG_FATAL, "Only video and audio filters supported " "currently.\n"); - exit_program(1); + exit(1); } if (in->name) { @@ -228,7 +228,7 @@ static void init_input_filter(FilterGraph *fg, AVFilterInOut *in) if (file_idx < 0 || file_idx >= nb_input_files) { av_log(NULL, AV_LOG_FATAL, "Invalid file index %d in filtergraph description %s.\n", file_idx, fg->graph_desc); - exit_program(1); + exit(1); } s = input_files[file_idx]->ctx; @@ -246,7 +246,7 @@ static void init_input_filter(FilterGraph *fg, AVFilterInOut *in) if (!st) { av_log(NULL, AV_LOG_FATAL, "Stream specifier '%s' in filtergraph description %s " "matches no streams.\n", p, fg->graph_desc); - exit_program(1); + exit(1); } ist = input_streams[input_files[file_idx]->ist_index + st->index]; } else { @@ -260,7 +260,7 @@ static void init_input_filter(FilterGraph *fg, AVFilterInOut *in) av_log(NULL, AV_LOG_FATAL, "Cannot find a matching stream for " "unlabeled input pad %d on filter %s\n", in->pad_idx, in->filter_ctx->name); - exit_program(1); + exit(1); } } av_assert0(ist); @@ -272,7 +272,7 @@ static void init_input_filter(FilterGraph *fg, AVFilterInOut *in) fg->inputs = grow_array(fg->inputs, sizeof(*fg->inputs), &fg->nb_inputs, fg->nb_inputs + 1); if (!(fg->inputs[fg->nb_inputs - 1] = av_mallocz(sizeof(*fg->inputs[0])))) - exit_program(1); + exit(1); fg->inputs[fg->nb_inputs - 1]->ist = ist; fg->inputs[fg->nb_inputs - 1]->graph = fg; @@ -477,7 +477,7 @@ static int configure_output_audio_filter(FilterGraph *fg, OutputFilter *ofilter, AVIOContext *pb; \ \ if (avio_open_dyn_buf(&pb) < 0) \ - exit_program(1); \ + exit(1); \ \ avio_printf(pb, "%s", ctx->filter->name); \ if (nb_pads > 1) \ @@ -752,7 +752,7 @@ int configure_filtergraph(FilterGraph *fg) fg->outputs = grow_array(fg->outputs, sizeof(*fg->outputs), &fg->nb_outputs, fg->nb_outputs + 1); if (!(fg->outputs[fg->nb_outputs - 1] = av_mallocz(sizeof(*fg->outputs[0])))) - exit_program(1); + exit(1); fg->outputs[fg->nb_outputs - 1]->graph = fg; fg->outputs[fg->nb_outputs - 1]->out_tmp = cur; cur = cur->next; diff --git a/ffmpeg_opt.c b/ffmpeg_opt.c index 2c5fbfb6b2..bce66f825b 100644 --- a/ffmpeg_opt.c +++ b/ffmpeg_opt.c @@ -50,7 +50,7 @@ if ((ret = check_stream_specifier(fmtctx, st, spec)) > 0)\ outvar = o->name[i].u.type;\ else if (ret < 0)\ - exit_program(1);\ + exit(1);\ }\ } @@ -162,7 +162,7 @@ static int opt_video_channel(void *optctx, const char *opt, const char *arg) { av_log(NULL, AV_LOG_WARNING, "This option is deprecated, use -channel.\n"); return opt_default(optctx, "channel", arg); - } +} static int opt_video_standard(void *optctx, const char *opt, const char *arg) { @@ -215,7 +215,7 @@ static int opt_map(void *optctx, const char *opt, const char *arg) sync_file_idx = strtol(sync + 1, &sync, 0); if (sync_file_idx >= nb_input_files || sync_file_idx < 0) { av_log(NULL, AV_LOG_FATAL, "Invalid sync file index: %d.\n", sync_file_idx); - exit_program(1); + exit(1); } if (*sync) sync++; @@ -228,7 +228,7 @@ static int opt_map(void *optctx, const char *opt, const char *arg) if (i == input_files[sync_file_idx]->nb_streams) { av_log(NULL, AV_LOG_FATAL, "Sync stream specification in map %s does not " "match any streams.\n", arg); - exit_program(1); + exit(1); } } @@ -242,13 +242,13 @@ static int opt_map(void *optctx, const char *opt, const char *arg) m->linklabel = av_get_token(&c, "]"); if (!m->linklabel) { av_log(NULL, AV_LOG_ERROR, "Invalid output link label: %s.\n", map); - exit_program(1); + exit(1); } } else { file_idx = strtol(map, &p, 0); if (file_idx >= nb_input_files || file_idx < 0) { av_log(NULL, AV_LOG_FATAL, "Invalid input file index: %d.\n", file_idx); - exit_program(1); + exit(1); } if (negative) /* disable some already defined maps */ @@ -284,7 +284,7 @@ static int opt_map(void *optctx, const char *opt, const char *arg) if (!m) { av_log(NULL, AV_LOG_FATAL, "Stream map '%s' matches no streams.\n", arg); - exit_program(1); + exit(1); } av_freep(&map); @@ -329,7 +329,7 @@ static int opt_map_channel(void *optctx, const char *opt, const char *arg) if (n != 3 && n != 5) { av_log(NULL, AV_LOG_FATAL, "Syntax error, mapchan usage: " "[file.stream.channel|-1][:syncfile:syncstream]\n"); - exit_program(1); + exit(1); } if (n != 5) // only file.stream.channel specified @@ -339,24 +339,24 @@ static int opt_map_channel(void *optctx, const char *opt, const char *arg) if (m->file_idx < 0 || m->file_idx >= nb_input_files) { av_log(NULL, AV_LOG_FATAL, "mapchan: invalid input file index: %d\n", m->file_idx); - exit_program(1); + exit(1); } if (m->stream_idx < 0 || m->stream_idx >= input_files[m->file_idx]->nb_streams) { av_log(NULL, AV_LOG_FATAL, "mapchan: invalid input file stream index #%d.%d\n", m->file_idx, m->stream_idx); - exit_program(1); + exit(1); } st = input_files[m->file_idx]->ctx->streams[m->stream_idx]; if (st->codec->codec_type != AVMEDIA_TYPE_AUDIO) { av_log(NULL, AV_LOG_FATAL, "mapchan: stream #%d.%d is not an audio stream.\n", m->file_idx, m->stream_idx); - exit_program(1); + exit(1); } if (m->channel_idx < 0 || m->channel_idx >= st->codec->channels) { av_log(NULL, AV_LOG_FATAL, "mapchan: invalid audio channel #%d.%d.%d\n", m->file_idx, m->stream_idx, m->channel_idx); - exit_program(1); + exit(1); } return 0; } @@ -377,7 +377,7 @@ static void parse_meta_type(char *arg, char *type, int *index, const char **stre case 's': if (*(++arg) && *arg != ':') { av_log(NULL, AV_LOG_FATAL, "Invalid metadata specifier %s.\n", arg); - exit_program(1); + exit(1); } *stream_spec = *arg == ':' ? arg + 1 : ""; break; @@ -388,7 +388,7 @@ static void parse_meta_type(char *arg, char *type, int *index, const char **stre break; default: av_log(NULL, AV_LOG_FATAL, "Invalid metadata type %c.\n", *arg); - exit_program(1); + exit(1); } } else *type = 'g'; @@ -427,7 +427,7 @@ static int copy_metadata(char *outspec, char *inspec, AVFormatContext *oc, AVFor if ((index) < 0 || (index) >= (nb_elems)) {\ av_log(NULL, AV_LOG_FATAL, "Invalid %s index %d while processing metadata maps.\n",\ (desc), (index));\ - exit_program(1);\ + exit(1);\ } #define SET_DICT(type, meta, context, index)\ @@ -458,11 +458,11 @@ static int copy_metadata(char *outspec, char *inspec, AVFormatContext *oc, AVFor meta_in = &ic->streams[i]->metadata; break; } else if (ret < 0) - exit_program(1); + exit(1); } if (!meta_in) { av_log(NULL, AV_LOG_FATAL, "Stream specifier %s does not match any streams.\n", istream_spec); - exit_program(1); + exit(1); } } @@ -472,7 +472,7 @@ static int copy_metadata(char *outspec, char *inspec, AVFormatContext *oc, AVFor meta_out = &oc->streams[i]->metadata; av_dict_copy(meta_out, *meta_in, AV_DICT_DONT_OVERWRITE); } else if (ret < 0) - exit_program(1); + exit(1); } } else av_dict_copy(meta_out, *meta_in, AV_DICT_DONT_OVERWRITE); @@ -514,11 +514,11 @@ static AVCodec *find_codec_or_die(const char *name, enum AVMediaType type, int e if (!codec) { av_log(NULL, AV_LOG_FATAL, "Unknown %s '%s'\n", codec_string, name); - exit_program(1); + exit(1); } if (codec->type != type) { av_log(NULL, AV_LOG_FATAL, "Invalid %s type '%s'\n", codec_string, name); - exit_program(1); + exit(1); } return codec; } @@ -552,7 +552,7 @@ static void add_input_streams(OptionsContext *o, AVFormatContext *ic) char *framerate = NULL; if (!ist) - exit_program(1); + exit(1); input_streams = grow_array(input_streams, sizeof(*input_streams), &nb_input_streams, nb_input_streams + 1); input_streams[nb_input_streams - 1] = ist; @@ -593,7 +593,7 @@ static void add_input_streams(OptionsContext *o, AVFormatContext *ic) framerate) < 0) { av_log(NULL, AV_LOG_ERROR, "Error parsing framerate %s.\n", framerate); - exit_program(1); + exit(1); } ist->top_field_first = -1; @@ -637,13 +637,13 @@ static void assert_file_overwrite(const char *filename) signal(SIGINT, SIG_DFL); if (!read_yesno()) { av_log(NULL, AV_LOG_FATAL, "Not overwriting - exiting\n"); - exit_program(1); + exit(1); } term_init(); } else { av_log(NULL, AV_LOG_FATAL, "File '%s' already exists. Exiting.\n", filename); - exit_program(1); + exit(1); } } } @@ -665,7 +665,7 @@ static void dump_attachment(AVStream *st, const char *filename) if (!*filename) { av_log(NULL, AV_LOG_FATAL, "No filename specified and no 'filename' tag" "in stream #%d:%d.\n", nb_input_files - 1, st->index); - exit_program(1); + exit(1); } assert_file_overwrite(filename); @@ -673,7 +673,7 @@ static void dump_attachment(AVStream *st, const char *filename) if ((ret = avio_open2(&out, filename, AVIO_FLAG_WRITE, &int_cb, NULL)) < 0) { av_log(NULL, AV_LOG_FATAL, "Could not open file %s for writing.\n", filename); - exit_program(1); + exit(1); } avio_write(out, st->codec->extradata, st->codec->extradata_size); @@ -698,7 +698,7 @@ static int opt_input_file(void *optctx, const char *opt, const char *filename) if (o->format) { if (!(file_iformat = av_find_input_format(o->format))) { av_log(NULL, AV_LOG_FATAL, "Unknown input format: '%s'\n", o->format); - exit_program(1); + exit(1); } } @@ -712,7 +712,7 @@ static int opt_input_file(void *optctx, const char *opt, const char *filename) ic = avformat_alloc_context(); if (!ic) { print_error(filename, AVERROR(ENOMEM)); - exit_program(1); + exit(1); } if (o->nb_audio_sample_rate) { snprintf(buf, sizeof(buf), "%d", o->audio_sample_rate[o->nb_audio_sample_rate - 1].u.i); @@ -763,7 +763,7 @@ static int opt_input_file(void *optctx, const char *opt, const char *filename) err = avformat_open_input(&ic, filename, file_iformat, &format_opts); if (err < 0) { print_error(filename, err); - exit_program(1); + exit(1); } assert_avoptions(format_opts); @@ -781,7 +781,7 @@ static int opt_input_file(void *optctx, const char *opt, const char *filename) if (ret < 0) { av_log(NULL, AV_LOG_FATAL, "%s: could not find codec parameters\n", filename); avformat_close_input(&ic); - exit_program(1); + exit(1); } timestamp = o->start_time; @@ -806,7 +806,7 @@ static int opt_input_file(void *optctx, const char *opt, const char *filename) input_files = grow_array(input_files, sizeof(*input_files), &nb_input_files, nb_input_files + 1); if (!(input_files[nb_input_files - 1] = av_mallocz(sizeof(*input_files[0])))) - exit_program(1); + exit(1); input_files[nb_input_files - 1]->ctx = ic; input_files[nb_input_files - 1]->ist_index = nb_input_streams - ic->nb_streams; @@ -841,7 +841,7 @@ static uint8_t *get_line(AVIOContext *s) if (avio_open_dyn_buf(&line) < 0) { av_log(NULL, AV_LOG_FATAL, "Could not alloc buffer for reading preset.\n"); - exit_program(1); + exit(1); } while ((c = avio_r8(s)) && c != '\n') @@ -908,7 +908,7 @@ static OutputStream *new_output_stream(OptionsContext *o, AVFormatContext *oc, e if (!st) { av_log(NULL, AV_LOG_FATAL, "Could not alloc stream.\n"); - exit_program(1); + exit(1); } if (oc->nb_streams - 1 < o->nb_streamid_map) @@ -917,7 +917,7 @@ static OutputStream *new_output_stream(OptionsContext *o, AVFormatContext *oc, e output_streams = grow_array(output_streams, sizeof(*output_streams), &nb_output_streams, nb_output_streams + 1); if (!(ost = av_mallocz(sizeof(*ost)))) - exit_program(1); + exit(1); output_streams[nb_output_streams - 1] = ost; ost->file_index = nb_output_files; @@ -942,7 +942,7 @@ static OutputStream *new_output_stream(OptionsContext *o, AVFormatContext *oc, e } if (!(arg = strchr(buf, '='))) { av_log(NULL, AV_LOG_FATAL, "Invalid line found in the preset file.\n"); - exit_program(1); + exit(1); } *arg++ = 0; av_dict_set(&ost->opts, buf, arg, AV_DICT_DONT_OVERWRITE); @@ -954,7 +954,7 @@ static OutputStream *new_output_stream(OptionsContext *o, AVFormatContext *oc, e av_log(NULL, AV_LOG_FATAL, "Preset %s specified for stream %d:%d, but could not be opened.\n", preset, ost->file_index, ost->index); - exit_program(1); + exit(1); } ost->max_frames = INT64_MAX; @@ -969,7 +969,7 @@ static OutputStream *new_output_stream(OptionsContext *o, AVFormatContext *oc, e *next++ = 0; if (!(bsfc = av_bitstream_filter_init(bsf))) { av_log(NULL, AV_LOG_FATAL, "Unknown bitstream filter %s\n", bsf); - exit_program(1); + exit(1); } if (bsfc_prev) bsfc_prev->next = bsfc; @@ -1022,7 +1022,7 @@ static void parse_matrix_coeffs(uint16_t *dest, const char *str) p = strchr(p, ','); if (!p) { av_log(NULL, AV_LOG_FATAL, "Syntax error in matrix \"%s\" at coeff %d\n", str, i); - exit_program(1); + exit(1); } p++; } @@ -1042,7 +1042,7 @@ static OutputStream *new_video_stream(OptionsContext *o, AVFormatContext *oc, in MATCH_PER_STREAM_OPT(frame_rates, str, frame_rate, oc, st); if (frame_rate && av_parse_video_rate(&ost->frame_rate, frame_rate) < 0) { av_log(NULL, AV_LOG_FATAL, "Invalid framerate value: %s\n", frame_rate); - exit_program(1); + exit(1); } if (!ost->stream_copy) { @@ -1057,7 +1057,7 @@ static OutputStream *new_video_stream(OptionsContext *o, AVFormatContext *oc, in MATCH_PER_STREAM_OPT(frame_sizes, str, frame_size, oc, st); if (frame_size && av_parse_video_size(&video_enc->width, &video_enc->height, frame_size) < 0) { av_log(NULL, AV_LOG_FATAL, "Invalid frame size: %s.\n", frame_size); - exit_program(1); + exit(1); } MATCH_PER_STREAM_OPT(frame_aspect_ratios, str, frame_aspect_ratio, oc, st); @@ -1066,7 +1066,7 @@ static OutputStream *new_video_stream(OptionsContext *o, AVFormatContext *oc, in if (av_parse_ratio(&q, frame_aspect_ratio, 255, 0, NULL) < 0 || q.num <= 0 || q.den <= 0) { av_log(NULL, AV_LOG_FATAL, "Invalid aspect ratio: %s\n", frame_aspect_ratio); - exit_program(1); + exit(1); } ost->frame_aspect_ratio = av_q2d(q); } @@ -1080,7 +1080,7 @@ static OutputStream *new_video_stream(OptionsContext *o, AVFormatContext *oc, in } if (frame_pix_fmt && (video_enc->pix_fmt = av_get_pix_fmt(frame_pix_fmt)) == PIX_FMT_NONE) { av_log(NULL, AV_LOG_FATAL, "Unknown pixel format requested: %s.\n", frame_pix_fmt); - exit_program(1); + exit(1); } st->sample_aspect_ratio = video_enc->sample_aspect_ratio; @@ -1090,7 +1090,7 @@ static OutputStream *new_video_stream(OptionsContext *o, AVFormatContext *oc, in if (intra_matrix) { if (!(video_enc->intra_matrix = av_mallocz(sizeof(*video_enc->intra_matrix) * 64))) { av_log(NULL, AV_LOG_FATAL, "Could not allocate memory for intra matrix.\n"); - exit_program(1); + exit(1); } parse_matrix_coeffs(video_enc->intra_matrix, intra_matrix); } @@ -1098,7 +1098,7 @@ static OutputStream *new_video_stream(OptionsContext *o, AVFormatContext *oc, in if (inter_matrix) { if (!(video_enc->inter_matrix = av_mallocz(sizeof(*video_enc->inter_matrix) * 64))) { av_log(NULL, AV_LOG_FATAL, "Could not allocate memory for inter matrix.\n"); - exit_program(1); + exit(1); } parse_matrix_coeffs(video_enc->inter_matrix, inter_matrix); } @@ -1109,7 +1109,7 @@ static OutputStream *new_video_stream(OptionsContext *o, AVFormatContext *oc, in int e = sscanf(p, "%d,%d,%d", &start, &end, &q); if (e != 3) { av_log(NULL, AV_LOG_FATAL, "error parsing rc_override\n"); - exit_program(1); + exit(1); } /* FIXME realloc failure */ video_enc->rc_override = @@ -1150,7 +1150,7 @@ static OutputStream *new_video_stream(OptionsContext *o, AVFormatContext *oc, in MATCH_PER_STREAM_OPT(passlogfiles, str, ost->logfile_prefix, oc, st); if (ost->logfile_prefix && !(ost->logfile_prefix = av_strdup(ost->logfile_prefix))) - exit_program(1); + exit(1); MATCH_PER_STREAM_OPT(forced_key_frames, str, ost->forced_keyframes, oc, st); if (ost->forced_keyframes) @@ -1193,7 +1193,7 @@ static OutputStream *new_audio_stream(OptionsContext *o, AVFormatContext *oc, in if (sample_fmt && (audio_enc->sample_fmt = av_get_sample_fmt(sample_fmt)) == AV_SAMPLE_FMT_NONE) { av_log(NULL, AV_LOG_FATAL, "Invalid sample format '%s'\n", sample_fmt); - exit_program(1); + exit(1); } MATCH_PER_STREAM_OPT(audio_sample_rate, i, audio_enc->sample_rate, oc, st); @@ -1229,7 +1229,7 @@ static OutputStream *new_data_stream(OptionsContext *o, AVFormatContext *oc, int ost = new_output_stream(o, oc, AVMEDIA_TYPE_DATA, source_index); if (!ost->stream_copy) { av_log(NULL, AV_LOG_FATAL, "Data stream encoding not supported yet (only streamcopy)\n"); - exit_program(1); + exit(1); } return ost; @@ -1262,7 +1262,7 @@ static OutputStream *new_subtitle_stream(OptionsContext *o, AVFormatContext *oc, MATCH_PER_STREAM_OPT(frame_sizes, str, frame_size, oc, st); if (frame_size && av_parse_video_size(&subtitle_enc->width, &subtitle_enc->height, frame_size) < 0) { av_log(NULL, AV_LOG_FATAL, "Invalid frame size: %s.\n", frame_size); - exit_program(1); + exit(1); } } @@ -1283,7 +1283,7 @@ static int opt_streamid(void *optctx, const char *opt, const char *arg) av_log(NULL, AV_LOG_FATAL, "Invalid value '%s' for option '%s', required syntax is 'index:value'\n", arg, opt); - exit_program(1); + exit(1); } *p++ = '\0'; idx = parse_number_or_die(opt, idx_str, OPT_INT, 0, MAX_STREAMS-1); @@ -1384,7 +1384,7 @@ static void init_output_filter(OutputFilter *ofilter, OptionsContext *o, default: av_log(NULL, AV_LOG_FATAL, "Only video and audio filters are supported " "currently.\n"); - exit_program(1); + exit(1); } ost->source_index = -1; @@ -1396,12 +1396,12 @@ static void init_output_filter(OutputFilter *ofilter, OptionsContext *o, av_log(NULL, AV_LOG_ERROR, "Streamcopy requested for output stream %d:%d, " "which is fed from a complex filtergraph. Filtering and streamcopy " "cannot be used together.\n", ost->file_index, ost->index); - exit_program(1); + exit(1); } if (configure_output_filter(ofilter->graph, ofilter, ofilter->out_tmp) < 0) { av_log(NULL, AV_LOG_FATAL, "Error configuring filter.\n"); - exit_program(1); + exit(1); } avfilter_inout_free(&ofilter->out_tmp); } @@ -1428,7 +1428,7 @@ void opt_output_file(void *optctx, const char *filename) if (configure_complex_filters() < 0) { av_log(NULL, AV_LOG_FATAL, "Error configuring filters.\n"); - exit_program(1); + exit(1); } if (!strcmp(filename, "-")) @@ -1437,7 +1437,7 @@ void opt_output_file(void *optctx, const char *filename) err = avformat_alloc_output_context2(&oc, NULL, o->format, filename); if (!oc) { print_error(filename, err); - exit_program(1); + exit(1); } file_oformat= oc->oformat; oc->interrupt_callback = int_cb; @@ -1469,7 +1469,7 @@ void opt_output_file(void *optctx, const char *filename) int err = read_ffserver_streams(o, oc, filename); if (err < 0) { print_error(filename, err); - exit_program(1); + exit(1); } for(j = nb_output_streams - oc->nb_streams; j < nb_output_streams; j++) { ost = output_streams[j]; @@ -1487,7 +1487,7 @@ void opt_output_file(void *optctx, const char *filename) } if(!ost->sync_ist){ av_log(NULL, AV_LOG_FATAL, "Missing %s stream which is required by this ffm\n", av_get_media_type_string(ost->st->codec->codec_type)); - exit_program(1); + exit(1); } } } else if (!o->nb_stream_maps) { @@ -1568,7 +1568,7 @@ loop_end: if (!ofilter) { av_log(NULL, AV_LOG_FATAL, "Output with label '%s' does not exist " "in any defined filter graph.\n", map->linklabel); - exit_program(1); + exit(1); } init_output_filter(ofilter, o, oc); } else { @@ -1591,7 +1591,7 @@ loop_end: default: av_log(NULL, AV_LOG_FATAL, "Cannot map stream #%d:%d - unsupported type.\n", map->file_index, map->stream_index); - exit_program(1); + exit(1); } } } @@ -1606,7 +1606,7 @@ loop_end: && (e = av_dict_get(codec_opts, "flags", NULL, AV_DICT_IGNORE_SUFFIX)) && (!e->key[5] || check_stream_specifier(oc, ost->st, e->key+6))) if (av_opt_set(ost->st->codec, "flags", e->value, 0) < 0) - exit_program(1); + exit(1); } /* handle attached files */ @@ -1619,17 +1619,17 @@ loop_end: if ((err = avio_open2(&pb, o->attachments[i], AVIO_FLAG_READ, &int_cb, NULL)) < 0) { av_log(NULL, AV_LOG_FATAL, "Could not open attachment file %s.\n", o->attachments[i]); - exit_program(1); + exit(1); } if ((len = avio_size(pb)) <= 0) { av_log(NULL, AV_LOG_FATAL, "Could not get size of the attachment %s.\n", o->attachments[i]); - exit_program(1); + exit(1); } if (!(attachment = av_malloc(len))) { av_log(NULL, AV_LOG_FATAL, "Attachment %s too large to fit into memory.\n", o->attachments[i]); - exit_program(1); + exit(1); } avio_read(pb, attachment, len); @@ -1646,7 +1646,7 @@ loop_end: output_files = grow_array(output_files, sizeof(*output_files), &nb_output_files, nb_output_files + 1); if (!(output_files[nb_output_files - 1] = av_mallocz(sizeof(*output_files[0])))) - exit_program(1); + exit(1); output_files[nb_output_files - 1]->ctx = oc; output_files[nb_output_files - 1]->ost_index = nb_output_streams - oc->nb_streams; @@ -1662,7 +1662,7 @@ loop_end: if (oc->oformat->flags & AVFMT_NEEDNUMBER) { if (!av_filename_number_test(oc->filename)) { print_error(oc->filename, AVERROR(EINVAL)); - exit_program(1); + exit(1); } } @@ -1675,7 +1675,7 @@ loop_end: &oc->interrupt_callback, &output_files[nb_output_files - 1]->opts)) < 0) { print_error(filename, err); - exit_program(1); + exit(1); } } @@ -1693,7 +1693,7 @@ loop_end: if (in_file_index >= nb_input_files) { av_log(NULL, AV_LOG_FATAL, "Invalid input file index %d while processing metadata maps\n", in_file_index); - exit_program(1); + exit(1); } copy_metadata(o->metadata_map[i].specifier, *p ? p + 1 : p, oc, in_file_index >= 0 ? input_files[in_file_index]->ctx : NULL, o); } @@ -1711,7 +1711,7 @@ loop_end: } else { av_log(NULL, AV_LOG_FATAL, "Invalid input file index %d in chapter mapping.\n", o->chapters_input_file); - exit_program(1); + exit(1); } } if (o->chapters_input_file >= 0) @@ -1746,7 +1746,7 @@ loop_end: if (!val) { av_log(NULL, AV_LOG_FATAL, "No '=' character in metadata string %s.\n", o->metadata[i].u.str); - exit_program(1); + exit(1); } *val++ = 0; @@ -1756,7 +1756,7 @@ loop_end: if ((ret = check_stream_specifier(oc, oc->streams[j], stream_spec)) > 0) { av_dict_set(&oc->streams[j]->metadata, o->metadata[i].u.str, *val ? val : NULL, 0); } else if (ret < 0) - exit_program(1); + exit(1); } } else { @@ -1767,13 +1767,13 @@ loop_end: case 'c': if (index < 0 || index >= oc->nb_chapters) { av_log(NULL, AV_LOG_FATAL, "Invalid chapter index %d in metadata specifier.\n", index); - exit_program(1); + exit(1); } m = &oc->chapters[index]->metadata; break; default: av_log(NULL, AV_LOG_FATAL, "Invalid metadata specifier %s.\n", o->metadata[i].specifier); - exit_program(1); + exit(1); } av_dict_set(m, o->metadata[i].u.str, *val ? val : NULL, 0); } @@ -1827,7 +1827,7 @@ static int opt_target(void *optctx, const char *opt, const char *arg) av_log(NULL, AV_LOG_FATAL, "Could not determine norm (PAL/NTSC/NTSC-Film) for target.\n"); av_log(NULL, AV_LOG_FATAL, "Please prefix target with \"pal-\", \"ntsc-\" or \"film-\",\n"); av_log(NULL, AV_LOG_FATAL, "or set a framerate with \"-r xxx\".\n"); - exit_program(1); + exit(1); } if (!strcmp(arg, "vcd")) { @@ -1972,7 +1972,7 @@ static int opt_preset(void *optctx, const char *opt, const char *arg) av_log(NULL, AV_LOG_FATAL, "Please use -preset -qp 0\n"); }else av_log(NULL, AV_LOG_FATAL, "File for preset '%s' not found\n", arg); - exit_program(1); + exit(1); } while (fgets(line, sizeof(line), f)) { @@ -1984,7 +1984,7 @@ static int opt_preset(void *optctx, const char *opt, const char *arg) if (!av_strtok(key, "=", &value) || !av_strtok(value, "\r\n", &endptr)) { av_log(NULL, AV_LOG_FATAL, "%s: Invalid syntax: '%s'\n", filename, line); - exit_program(1); + exit(1); } av_log(NULL, AV_LOG_DEBUG, "ffpreset[%s]: set '%s' = '%s'\n", filename, key, value); @@ -1995,7 +1995,7 @@ static int opt_preset(void *optctx, const char *opt, const char *arg) else if (opt_default(NULL, key, value) < 0) { av_log(NULL, AV_LOG_FATAL, "%s: Invalid option or argument: '%s', parsed as '%s' = '%s'\n", filename, line, key, value); - exit_program(1); + exit(1); } } diff --git a/ffplay.c b/ffplay.c index 2337fe0d27..3a21bfa68d 100644 --- a/ffplay.c +++ b/ffplay.c @@ -300,10 +300,7 @@ static AVPacket flush_pkt; static SDL_Surface *screen; -void av_noreturn exit_program(int ret) -{ - exit(ret); -} +static int packet_queue_put(PacketQueue *q, AVPacket *pkt); static int packet_queue_put_private(PacketQueue *q, AVPacket *pkt) { @@ -2988,7 +2985,7 @@ static void opt_input_file(void *optctx, const char *filename) if (input_filename) { fprintf(stderr, "Argument '%s' provided as input filename, but '%s' was already specified.\n", filename, input_filename); - exit_program(1); + exit(1); } if (!strcmp(filename, "-")) filename = "pipe:"; diff --git a/ffprobe.c b/ffprobe.c index 9e5cd04101..31d1a4430a 100644 --- a/ffprobe.c +++ b/ffprobe.c @@ -141,10 +141,9 @@ static const char unit_bit_per_second_str[] = "bit/s"; static uint64_t *nb_streams_packets; static uint64_t *nb_streams_frames; -void av_noreturn exit_program(int ret) +static void exit_program() { av_dict_free(&fmt_entries_to_show); - exit(ret); } struct unit_value { @@ -2093,6 +2092,8 @@ int main(int argc, char **argv) int ret; av_log_set_flags(AV_LOG_SKIP_REPEATED); + atexit(exit_program); + options = real_options; parse_loglevel(argc, argv, options); av_register_all(); diff --git a/ffserver.c b/ffserver.c index 480e6fc15b..7fb61d04ea 100644 --- a/ffserver.c +++ b/ffserver.c @@ -329,11 +329,6 @@ static AVLFG random_state; static FILE *logfile = NULL; /* FIXME: make ffserver work with IPv6 */ -void av_noreturn exit_program(int ret) -{ - exit(ret); -} - /* resolve host with also IP address parsing */ static int resolve_host(struct in_addr *sin_addr, const char *hostname) { diff --git a/libavcodec/tiffenc.c b/libavcodec/tiffenc.c index 7d9752367a..dc87057fc9 100644 --- a/libavcodec/tiffenc.c +++ b/libavcodec/tiffenc.c @@ -28,6 +28,7 @@ #include "libavutil/imgutils.h" #include "libavutil/log.h" #include "libavutil/opt.h" +#include "libavutil/pixdesc.h" #include "avcodec.h" #include "config.h" @@ -250,6 +251,7 @@ static int encode_frame(AVCodecContext * avctx, AVPacket *pkt, int ret = -1; int is_yuv = 0, alpha = 0; int shift_h, shift_v; + const AVPixFmtDescriptor* pfd; *p = *pict; @@ -260,6 +262,7 @@ static int encode_frame(AVCodecContext * avctx, AVPacket *pkt, avctx->bits_per_coded_sample = s->bpp = av_get_bits_per_pixel(&av_pix_fmt_descriptors[avctx->pix_fmt]); + s->bpp_tab_size = av_pix_fmt_descriptors[avctx->pix_fmt].nb_components; switch (avctx->pix_fmt) { case PIX_FMT_RGBA64LE: @@ -302,7 +305,6 @@ static int encode_frame(AVCodecContext * avctx, AVPacket *pkt, return -1; } - s->bpp_tab_size = av_pix_fmt_descriptors[avctx->pix_fmt].nb_components; for (i = 0; i < s->bpp_tab_size; i++) bpp_tab[i] = av_pix_fmt_descriptors[avctx->pix_fmt].comp[i].depth_minus1 + 1; @@ -346,6 +348,7 @@ static int encode_frame(AVCodecContext * avctx, AVPacket *pkt, if (is_yuv){ av_fast_padded_malloc(&s->yuv_line, &s->yuv_line_size, bytes_per_row); if (s->yuv_line == NULL){ + av_log(s->avctx, AV_LOG_ERROR, "Not enough memory\n"); ret = AVERROR(ENOMEM); goto fail; } @@ -359,6 +362,10 @@ static int encode_frame(AVCodecContext * avctx, AVPacket *pkt, zlen = bytes_per_row * s->rps; zbuf = av_malloc(zlen); + if (!zbuf) { + ret = AVERROR(ENOMEM); + goto fail; + } s->strip_offsets[0] = ptr - pkt->data; zn = 0; for (j = 0; j < s->rps; j++) { @@ -383,8 +390,13 @@ static int encode_frame(AVCodecContext * avctx, AVPacket *pkt, } else #endif { - if(s->compr == TIFF_LZW) + if (s->compr == TIFF_LZW) { s->lzws = av_malloc(ff_lzw_encode_state_size); + if (!s->lzws) { + ret = AVERROR(ENOMEM); + goto fail; + } + } for (i = 0; i < s->height; i++) { if (s->strip_sizes[i / s->rps] == 0) { if(s->compr == TIFF_LZW){ diff --git a/libavformat/nutdec.c b/libavformat/nutdec.c index d9d115daf8..b2bbb9a36b 100644 --- a/libavformat/nutdec.c +++ b/libavformat/nutdec.c @@ -188,13 +188,15 @@ static int nut_probe(AVProbeData *p) return 0; } -#define GET_V(dst, check) \ - tmp = ffio_read_varlen(bc); \ - if (!(check)) { \ - av_log(s, AV_LOG_ERROR, "Error " #dst " is (%"PRId64")\n", tmp); \ - return -1; \ - } \ - dst = tmp; +#define GET_V(dst, check) \ + do { \ + tmp = ffio_read_varlen(bc); \ + if (!(check)) { \ + av_log(s, AV_LOG_ERROR, "Error " #dst " is (%"PRId64")\n", tmp); \ + return -1; \ + } \ + dst = tmp; \ + } while (0) static int skip_reserved(AVIOContext *bc, int64_t pos) { @@ -221,8 +223,8 @@ static int decode_main_header(NUTContext *nut) end = get_packetheader(nut, bc, 1, MAIN_STARTCODE); end += avio_tell(bc); - GET_V(tmp, tmp >= 2 && tmp <= 3) - GET_V(stream_count, tmp > 0 && tmp <= NUT_MAX_STREAMS) + GET_V(tmp, tmp >= 2 && tmp <= 3); + GET_V(stream_count, tmp > 0 && tmp <= NUT_MAX_STREAMS); nut->max_distance = ffio_read_varlen(bc); if (nut->max_distance > 65536) { @@ -230,12 +232,12 @@ static int decode_main_header(NUTContext *nut) nut->max_distance = 65536; } - GET_V(nut->time_base_count, tmp > 0 && tmp < INT_MAX / sizeof(AVRational)) + GET_V(nut->time_base_count, tmp > 0 && tmp < INT_MAX / sizeof(AVRational)); nut->time_base = av_malloc(nut->time_base_count * sizeof(AVRational)); for (i = 0; i < nut->time_base_count; i++) { - GET_V(nut->time_base[i].num, tmp > 0 && tmp < (1ULL << 31)) - GET_V(nut->time_base[i].den, tmp > 0 && tmp < (1ULL << 31)) + GET_V(nut->time_base[i].num, tmp > 0 && tmp < (1ULL << 31)); + GET_V(nut->time_base[i].den, tmp > 0 && tmp < (1ULL << 31)); if (av_gcd(nut->time_base[i].num, nut->time_base[i].den) != 1) { av_log(s, AV_LOG_ERROR, "time base invalid\n"); return AVERROR_INVALIDDATA; @@ -303,7 +305,7 @@ static int decode_main_header(NUTContext *nut) if (end > avio_tell(bc) + 4) { int rem = 1024; - GET_V(nut->header_count, tmp < 128U) + GET_V(nut->header_count, tmp < 128U); nut->header_count++; for (i = 1; i < nut->header_count; i++) { uint8_t *hdr; @@ -400,8 +402,8 @@ static int decode_stream_header(NUTContext *nut) } if (st->codec->codec_type == AVMEDIA_TYPE_VIDEO) { - GET_V(st->codec->width, tmp > 0) - GET_V(st->codec->height, tmp > 0) + GET_V(st->codec->width, tmp > 0); + GET_V(st->codec->height, tmp > 0); st->sample_aspect_ratio.num = ffio_read_varlen(bc); st->sample_aspect_ratio.den = ffio_read_varlen(bc); if ((!st->sample_aspect_ratio.num) != (!st->sample_aspect_ratio.den)) { @@ -411,9 +413,9 @@ static int decode_stream_header(NUTContext *nut) } ffio_read_varlen(bc); /* csp type */ } else if (st->codec->codec_type == AVMEDIA_TYPE_AUDIO) { - GET_V(st->codec->sample_rate, tmp > 0) + GET_V(st->codec->sample_rate, tmp > 0); ffio_read_varlen(bc); // samplerate_den - GET_V(st->codec->channels, tmp > 0) + GET_V(st->codec->channels, tmp > 0); } if (skip_reserved(bc, end) || ffio_get_checksum(bc)) { av_log(s, AV_LOG_ERROR, @@ -458,7 +460,7 @@ static int decode_info_header(NUTContext *nut) end = get_packetheader(nut, bc, 1, INFO_STARTCODE); end += avio_tell(bc); - GET_V(stream_id_plus1, tmp <= s->nb_streams) + GET_V(stream_id_plus1, tmp <= s->nb_streams); chapter_id = get_s(bc); chapter_start = ffio_read_varlen(bc); chapter_len = ffio_read_varlen(bc); @@ -608,7 +610,7 @@ static int find_and_decode_index(NUTContext *nut) end += avio_tell(bc); ffio_read_varlen(bc); // max_pts - GET_V(syncpoint_count, tmp < INT_MAX / 8 && tmp > 0) + GET_V(syncpoint_count, tmp < INT_MAX / 8 && tmp > 0); syncpoints = av_malloc(sizeof(int64_t) * syncpoint_count); has_keyframe = av_malloc(sizeof(int8_t) * (syncpoint_count + 1)); for (i = 0; i < syncpoint_count; i++) { @@ -773,7 +775,7 @@ static int decode_frame_header(NUTContext *nut, int64_t *pts, int *stream_id, if (flags & FLAG_CODED) flags ^= ffio_read_varlen(bc); if (flags & FLAG_STREAM_ID) { - GET_V(*stream_id, tmp < s->nb_streams) + GET_V(*stream_id, tmp < s->nb_streams); } stc = &nut->stream[*stream_id]; if (flags & FLAG_CODED_PTS) { diff --git a/libavutil/arm/asm.S b/libavutil/arm/asm.S index b9d4b737ad..449077c1ab 100644 --- a/libavutil/arm/asm.S +++ b/libavutil/arm/asm.S @@ -141,7 +141,9 @@ ELF .size \name, . - \name ldr \rd, .Lpicoff\@ .Lpic\@: .if \indir - ldr \rd, [pc, \rd] +A ldr \rd, [pc, \rd] +T add \rd, pc +T ldr \rd, [\rd] .else add \rd, pc .endif