virtualenv/FFmpeg
1
0
Fork 0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2025-01-29 22:00:58 +02:00
Code Issues Releases Activity

lavc/x86/hevc_add_res: Fix overflow in ADD_RES_MMX_4_8

Browse Source 
Fix overflow for coeff -32768 in function ADD_RES_MMX_4_8 with no
performance drop.

./checkasm --test=hevc_add_res --bench

Mainline:
  - hevc_add_res.add_residual [OK]
    hevc_add_res_4x4_8_mmxext: 15.5

Add overflow test case:
  - hevc_add_res.add_residual [FAILED]

After:
  - hevc_add_res.add_residual [OK]
    hevc_add_res_4x4_8_mmxext: 15.0

Signed-off-by: Xu Guangxin <guangxin.xu@intel.com>
Signed-off-by: Linjie Fu <linjie.fu@intel.com>
Signed-off-by: Anton Khirnov <anton@khirnov.net>
This commit is contained in:
Linjie Fu 2020-03-05 15:47:37 +08:00 committed by Anton Khirnov
parent 091341f2ab
commit 0da14ed09e
1 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
libavcodec/x86/hevc_add_res.asm
View File

@ -30,27 +30,26 @@ cextern pw_1023
%macro ADD_RES_MMX_4_8 0 %macro ADD_RES_MMX_4_8 0
mova m0, [r1] mova m0, [r1]
mova m2, [r1+8] mova m2, [r1+8]
pxor m1, m1
pxor m3, m3
psubw m1, m0
psubw m3, m2
packuswb m0, m2
packuswb m1, m3
movd m2, [r0] movd m1, [r0]
movd m3, [r0+r2] movd m3, [r0+r2]
punpckldq m2, m3 punpcklbw m1, m4
paddusb m0, m2 punpcklbw m3, m4
psubusb m0, m1
paddsw m0, m1
paddsw m2, m3
packuswb m0, m4
packuswb m2, m4
movd [r0], m0 movd [r0], m0
psrlq m0, 32 movd [r0+r2], m2
movd [r0+r2], m0
%endmacro %endmacro
INIT_MMX mmxext INIT_MMX mmxext
; void ff_hevc_add_residual_4_8_mmxext(uint8_t *dst, int16_t *res, ptrdiff_t stride) ; void ff_hevc_add_residual_4_8_mmxext(uint8_t *dst, int16_t *res, ptrdiff_t stride)
cglobal hevc_add_residual_4_8, 3, 3, 6 cglobal hevc_add_residual_4_8, 3, 3, 6
pxor m4, m4
ADD_RES_MMX_4_8 ADD_RES_MMX_4_8
add r1, 16 add r1, 16
lea r0, [r0+r2*2] lea r0, [r0+r2*2]