From 20b13122ec42398936f9e97c88b827792d583bc0 Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Sun, 8 Nov 2020 00:08:35 +0100 Subject: [PATCH] avcodec/cfhd: check peak.offset Fixes: signed integer overflow: -2147483648 - 4 cannot be represented in type 'int' Fixes: 26907/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CFHD_fuzzer-5746202330267648 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer (cherry picked from commit 386faeda5ff1924c17766248ce19528dbf90cf15) Signed-off-by: Michael Niedermayer --- libavcodec/cfhd.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c index 5f2cda8327..cbc16f8424 100644 --- a/libavcodec/cfhd.c +++ b/libavcodec/cfhd.c @@ -550,6 +550,12 @@ static int cfhd_decode(AVCodecContext *avctx, void *data, int *got_frame, s->peak.level = 0; } else if (tag == -74 && s->peak.offset) { s->peak.level = data; + if (s->peak.offset < 4 - bytestream2_tell(&s->peak.base) || + s->peak.offset > 4 + bytestream2_get_bytes_left(&s->peak.base) + ) { + ret = AVERROR_INVALIDDATA; + goto end; + } bytestream2_seek(&s->peak.base, s->peak.offset - 4, SEEK_CUR); } else av_log(avctx, AV_LOG_DEBUG, "Unknown tag %i data %x\n", tag, data);