From 22522d9c2c69624fe4d81d61ee65a56610f22f1d Mon Sep 17 00:00:00 2001 From: Anton Khirnov Date: Tue, 21 Jul 2015 19:41:59 +0200 Subject: [PATCH] qsvdec: fix a memleak of async_fifo init() is called whenever format changes, so current code would leak the fifo in this case. --- libavcodec/qsvdec.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c index 489375cf7b..ef781d9d8e 100644 --- a/libavcodec/qsvdec.c +++ b/libavcodec/qsvdec.c @@ -73,10 +73,12 @@ int ff_qsv_decode_init(AVCodecContext *avctx, QSVContext *q, mfxSession session) mfxVideoParam param = { { 0 } }; int ret; - q->async_fifo = av_fifo_alloc((1 + q->async_depth) * - (sizeof(mfxSyncPoint) + sizeof(QSVFrame*))); - if (!q->async_fifo) - return AVERROR(ENOMEM); + if (!q->async_fifo) { + q->async_fifo = av_fifo_alloc((1 + q->async_depth) * + (sizeof(mfxSyncPoint) + sizeof(QSVFrame*))); + if (!q->async_fifo) + return AVERROR(ENOMEM); + } ret = qsv_init_session(avctx, q, session); if (ret < 0) {