virtualenv/FFmpeg
1
0
Fork 0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2025-11-23 21:54:53 +02:00
Code Issues Releases Activity

avcodec/exif: avoid writing native-endian EXIF buffers

Browse Source 
Currently there's platform-dependent behavior where if no endianness
is requested, it writes the buffers in native-endian. This breaks FATE
tests on big-endian architecture. This commit changes the default to
little-endian buffers upon writing.

Fixes: #20291.

Signed-off-by: Leo Izen <leo.izen@gmail.com>
This commit is contained in:
Leo Izen
2025-08-24 08:54:16 -04:00
parent 2298d4d072
commit 2398fddf6e
1 changed files with 1 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
libavcodec/exif.c
View File

@@ -695,11 +695,7 @@ int av_exif_write(void *logctx, const AVExifMetadata *ifd, AVBufferRef **buffer,
PutByteContext pb; PutByteContext pb;
int ret, off = 0; int ret, off = 0;
#if AV_HAVE_BIGENDIAN
int le = 0;
#else
int le = 1; int le = 1;
#endif
if (*buffer) if (*buffer)
return AVERROR(EINVAL); return AVERROR(EINVAL);
@@ -736,12 +732,8 @@ int av_exif_write(void *logctx, const AVExifMetadata *ifd, AVBufferRef **buffer,
if (header_mode != AV_EXIF_ASSUME_BE && header_mode != AV_EXIF_ASSUME_LE) { if (header_mode != AV_EXIF_ASSUME_BE && header_mode != AV_EXIF_ASSUME_LE) {
/* these constants are be32 in both cases */ /* these constants are be32 in both cases */
/* this is a #if instead of a ternary to suppress a deadcode warning */ /* le == 1 always in this case */
#if AV_HAVE_BIGENDIAN
bytestream2_put_be32(&pb, EXIF_MM_LONG);
#else
bytestream2_put_be32(&pb, EXIF_II_LONG); bytestream2_put_be32(&pb, EXIF_II_LONG);
#endif
tput32(&pb, le, 8); tput32(&pb, le, 8);
} }