From 2657e1679ef595ad4e873cfae5a069dd559a762e Mon Sep 17 00:00:00 2001 From: Koushik Dutta Date: Wed, 26 Mar 2025 13:13:13 -0700 Subject: [PATCH] avformat/rtpenc: Add flag AVFMT_NODIMENSIONS. Not all rtp formats require the video dimensions to be available up front. H264 and HEVC will send them as stream parameters. The flag is restrictive and prevents RTP repacketization without parsing the codec information out of the stream. This change checks to see if the codec parameters are available on the rtp formats that need it. Signed-off-by: Koushik Dutta Signed-off-by: Michael Niedermayer --- libavformat/rtpenc.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/libavformat/rtpenc.c b/libavformat/rtpenc.c index 3db13ee0b2..8b989dca71 100644 --- a/libavformat/rtpenc.c +++ b/libavformat/rtpenc.c @@ -635,10 +635,18 @@ static int rtp_write_packet(AVFormatContext *s1, AVPacket *pkt) rtp_send_ilbc(s1, pkt->data, size); break; case AV_CODEC_ID_MJPEG: + if (st->codecpar->width <= 0 || st->codecpar->height <= 0) { + av_log(s1, AV_LOG_ERROR, "dimensions not set\n"); + return AVERROR(EINVAL); + } ff_rtp_send_jpeg(s1, pkt->data, size); break; case AV_CODEC_ID_BITPACKED: case AV_CODEC_ID_RAWVIDEO: { + if (st->codecpar->width <= 0 || st->codecpar->height <= 0) { + av_log(s1, AV_LOG_ERROR, "dimensions not set\n"); + return AVERROR(EINVAL); + } int interlaced = st->codecpar->field_order != AV_FIELD_PROGRESSIVE; ff_rtp_send_raw_rfc4175(s1, pkt->data, size, interlaced, 0); @@ -685,5 +693,5 @@ const FFOutputFormat ff_rtp_muxer = { .write_packet = rtp_write_packet, .write_trailer = rtp_write_trailer, .p.priv_class = &rtp_muxer_class, - .p.flags = AVFMT_TS_NONSTRICT, + .p.flags = AVFMT_NODIMENSIONS | AVFMT_TS_NONSTRICT, };