From 2f62e147aeb737e97656c524ffc2a1c5d23deff4 Mon Sep 17 00:00:00 2001 From: Fabrice Bellard Date: Mon, 6 Jan 2003 22:47:42 +0000 Subject: [PATCH] oops : better error resilience - should fix most wma decoding problems Originally committed as revision 1404 to svn://svn.ffmpeg.org/ffmpeg/trunk --- libavcodec/wmadec.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/libavcodec/wmadec.c b/libavcodec/wmadec.c index 7505a9be3d..ceeb371791 100644 --- a/libavcodec/wmadec.c +++ b/libavcodec/wmadec.c @@ -1240,7 +1240,7 @@ static int wma_decode_superframe(AVCodecContext *avctx, /* add bit_offset bits to last frame */ if ((s->last_superframe_len + ((bit_offset + 7) >> 3)) > MAX_CODED_SUPERFRAME_SIZE) - return -1; + goto fail; q = s->last_superframe + s->last_superframe_len; len = bit_offset; while (len > 0) { @@ -1259,7 +1259,7 @@ static int wma_decode_superframe(AVCodecContext *avctx, /* this frame is stored in the last superframe and in the current one */ if (wma_decode_frame(s, samples) < 0) - return -1; + goto fail; samples += s->nb_channels * s->frame_len; } @@ -1273,7 +1273,7 @@ static int wma_decode_superframe(AVCodecContext *avctx, s->reset_block_lengths = 1; for(i=0;inb_channels * s->frame_len; } @@ -1283,18 +1283,22 @@ static int wma_decode_superframe(AVCodecContext *avctx, pos >>= 3; len = buf_size - pos; if (len > MAX_CODED_SUPERFRAME_SIZE || len < 0) { - return -1; + goto fail; } s->last_superframe_len = len; memcpy(s->last_superframe, buf + pos, len); } else { /* single frame decode */ if (wma_decode_frame(s, samples) < 0) - return -1; + goto fail; samples += s->nb_channels * s->frame_len; } *data_size = (int8_t *)samples - (int8_t *)data; return s->block_align; + fail: + /* when error, we reset the bit reservoir */ + s->last_superframe_len = 0; + return -1; } static int wma_decode_end(AVCodecContext *avctx)