You've already forked FFmpeg
mirror of
https://github.com/FFmpeg/FFmpeg.git
synced 2025-11-23 21:54:53 +02:00
avcodec/libaomenc: Fix use of uninitialized value
codecctl_intp() is used to populate values via aom_codec_control(), not set them. This change moves the output of the return pointer's value after the aom_codec_control() to avoid a memory sanitizer warning (use of uninitialized value). Signed-off-by: James Zern <jzern@google.com>
This commit is contained in:
@@ -392,17 +392,17 @@ static av_cold int codecctl_intp(AVCodecContext *avctx,
|
|||||||
int width = -30;
|
int width = -30;
|
||||||
int res;
|
int res;
|
||||||
|
|
||||||
snprintf(buf, sizeof(buf), "%s:", ctlidstr[id]);
|
|
||||||
av_log(avctx, AV_LOG_DEBUG, " %*s%d\n", width, buf, *ptr);
|
|
||||||
|
|
||||||
res = aom_codec_control(&ctx->encoder, id, ptr);
|
res = aom_codec_control(&ctx->encoder, id, ptr);
|
||||||
if (res != AOM_CODEC_OK) {
|
if (res != AOM_CODEC_OK) {
|
||||||
snprintf(buf, sizeof(buf), "Failed to set %s codec control",
|
snprintf(buf, sizeof(buf), "Failed to get %s codec control",
|
||||||
ctlidstr[id]);
|
ctlidstr[id]);
|
||||||
log_encoder_error(avctx, buf);
|
log_encoder_error(avctx, buf);
|
||||||
return AVERROR(EINVAL);
|
return AVERROR(EINVAL);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
snprintf(buf, sizeof(buf), "%s:", ctlidstr[id]);
|
||||||
|
av_log(avctx, AV_LOG_DEBUG, " %*s%d\n", width, buf, *ptr);
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
#endif
|
#endif
|
||||||
|
|||||||
Reference in New Issue
Block a user