From 3748b2b8e8bcedba2de7fe826c4094169a885840 Mon Sep 17 00:00:00 2001 From: Stefano Sabatini Date: Sun, 18 Apr 2010 20:10:43 +0000 Subject: [PATCH] Fix leak in avfilter_graph_add_filter(). In case of reallocation failure the pointer to the original filter array was lost. The correct behavior seems to just keep the old array and count. Originally committed as revision 22905 to svn://svn.ffmpeg.org/ffmpeg/trunk --- libavfilter/avfiltergraph.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c index 2fcf73ab5c..9ad6536306 100644 --- a/libavfilter/avfiltergraph.c +++ b/libavfilter/avfiltergraph.c @@ -36,13 +36,13 @@ void avfilter_graph_destroy(AVFilterGraph *graph) int avfilter_graph_add_filter(AVFilterGraph *graph, AVFilterContext *filter) { - graph->filters = av_realloc(graph->filters, - sizeof(AVFilterContext*) * ++graph->filter_count); - - if (!graph->filters) + AVFilterContext **filters = av_realloc(graph->filters, + sizeof(AVFilterContext*) * (graph->filter_count+1)); + if (!filters) return AVERROR(ENOMEM); - graph->filters[graph->filter_count - 1] = filter; + graph->filters = filters; + graph->filters[graph->filter_count++] = filter; return 0; }