virtualenv/FFmpeg
1
0
Fork 0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2025-02-04 06:08:26 +02:00
Code Issues Releases Activity

avdevice/xcbgrab: Check sscanf() return

Browse Source 
Alot more input checking can be performed, this is only checking the obvious missing case

Fixes: CID1598562 Unchecked return value

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit 78d6d13babc62fa14727ee590e5a9661f23a0d9f)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
This commit is contained in:
Michael Niedermayer 2024-06-02 23:32:43 +02:00
parent 4a91134a18
commit 413b07402e
No known key found for this signature in database
GPG Key ID: B18E8928B3948D64
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libavdevice/xcbgrab.c
View File

@ -680,7 +680,10 @@ static av_cold int xcbgrab_read_header(AVFormatContext *s)
if (!sscanf(s->url, "%[^+]+%d,%d", display_name, &c->x, &c->y)) { if (!sscanf(s->url, "%[^+]+%d,%d", display_name, &c->x, &c->y)) {
*display_name = 0; *display_name = 0;
sscanf(s->url, "+%d,%d", &c->x, &c->y); if(sscanf(s->url, "+%d,%d", &c->x, &c->y) != 2) {
if (*s->url)
av_log(s, AV_LOG_WARNING, "Ambigous URL: %s\n", s->url);
}
} }
c->conn = xcb_connect(display_name[0] ? display_name : NULL, &screen_num); c->conn = xcb_connect(display_name[0] ? display_name : NULL, &screen_num);