mirror of
https://github.com/FFmpeg/FFmpeg.git
synced 2024-12-23 12:43:46 +02:00
avcodec: Ignoring errors is only possible before the input end
Fixes: out of array read
Fixes: Ticket 10308
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit fead656a7b
)
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
This commit is contained in:
parent
b46ee95d3c
commit
4b072933d4
@ -301,7 +301,7 @@ static int decode_slice(MpegEncContext *s)
|
|||||||
ff_er_add_slice(&s->er, s->resync_mb_x, s->resync_mb_y,
|
ff_er_add_slice(&s->er, s->resync_mb_x, s->resync_mb_y,
|
||||||
s->mb_x, s->mb_y, ER_MB_ERROR & part_mask);
|
s->mb_x, s->mb_y, ER_MB_ERROR & part_mask);
|
||||||
|
|
||||||
if (s->avctx->err_recognition & AV_EF_IGNORE_ERR)
|
if ((s->avctx->err_recognition & AV_EF_IGNORE_ERR) && get_bits_left(&s->gb) > 0)
|
||||||
continue;
|
continue;
|
||||||
return AVERROR_INVALIDDATA;
|
return AVERROR_INVALIDDATA;
|
||||||
}
|
}
|
||||||
|
@ -1187,7 +1187,7 @@ static inline int mpeg4_decode_block(Mpeg4DecContext *ctx, int16_t *block,
|
|||||||
if (SHOW_UBITS(re, &s->gb, 1) == 0) {
|
if (SHOW_UBITS(re, &s->gb, 1) == 0) {
|
||||||
av_log(s->avctx, AV_LOG_ERROR,
|
av_log(s->avctx, AV_LOG_ERROR,
|
||||||
"1. marker bit missing in 3. esc\n");
|
"1. marker bit missing in 3. esc\n");
|
||||||
if (!(s->avctx->err_recognition & AV_EF_IGNORE_ERR))
|
if (!(s->avctx->err_recognition & AV_EF_IGNORE_ERR) || get_bits_left(&s->gb) <= 0)
|
||||||
return AVERROR_INVALIDDATA;
|
return AVERROR_INVALIDDATA;
|
||||||
}
|
}
|
||||||
SKIP_CACHE(re, &s->gb, 1);
|
SKIP_CACHE(re, &s->gb, 1);
|
||||||
@ -1198,7 +1198,7 @@ static inline int mpeg4_decode_block(Mpeg4DecContext *ctx, int16_t *block,
|
|||||||
if (SHOW_UBITS(re, &s->gb, 1) == 0) {
|
if (SHOW_UBITS(re, &s->gb, 1) == 0) {
|
||||||
av_log(s->avctx, AV_LOG_ERROR,
|
av_log(s->avctx, AV_LOG_ERROR,
|
||||||
"2. marker bit missing in 3. esc\n");
|
"2. marker bit missing in 3. esc\n");
|
||||||
if (!(s->avctx->err_recognition & AV_EF_IGNORE_ERR))
|
if (!(s->avctx->err_recognition & AV_EF_IGNORE_ERR) || get_bits_left(&s->gb) <= 0)
|
||||||
return AVERROR_INVALIDDATA;
|
return AVERROR_INVALIDDATA;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user