1
0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2024-11-26 19:01:44 +02:00

avcodec/tiff: Check value on positive signed targets

Fixes: CID1604593 Overflowed constant

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
This commit is contained in:
Michael Niedermayer 2024-07-07 20:47:24 +02:00
parent 19a5a8997c
commit 66d6b8033b
No known key found for this signature in database
GPG Key ID: B18E8928B3948D64

View File

@ -1298,9 +1298,13 @@ static int tiff_decode_tag(TiffContext *s, AVFrame *frame)
s->is_thumbnail = (value != 0);
break;
case TIFF_WIDTH:
if (value > INT_MAX)
return AVERROR_INVALIDDATA;
s->width = value;
break;
case TIFF_HEIGHT:
if (value > INT_MAX)
return AVERROR_INVALIDDATA;
s->height = value;
break;
case TIFF_BPP:
@ -1432,12 +1436,18 @@ static int tiff_decode_tag(TiffContext *s, AVFrame *frame)
s->tile_byte_counts_offset = off;
break;
case TIFF_TILE_LENGTH:
if (value > INT_MAX)
return AVERROR_INVALIDDATA;
s->tile_length = value;
break;
case TIFF_TILE_WIDTH:
if (value > INT_MAX)
return AVERROR_INVALIDDATA;
s->tile_width = value;
break;
case TIFF_PREDICTOR:
if (value > INT_MAX)
return AVERROR_INVALIDDATA;
s->predictor = value;
break;
case TIFF_SUB_IFDS:
@ -1582,12 +1592,18 @@ static int tiff_decode_tag(TiffContext *s, AVFrame *frame)
}
break;
case TIFF_T4OPTIONS:
if (s->compr == TIFF_G3)
if (s->compr == TIFF_G3) {
if (value > INT_MAX)
return AVERROR_INVALIDDATA;
s->fax_opts = value;
}
break;
case TIFF_T6OPTIONS:
if (s->compr == TIFF_G4)
if (s->compr == TIFF_G4) {
if (value > INT_MAX)
return AVERROR_INVALIDDATA;
s->fax_opts = value;
}
break;
#define ADD_METADATA(count, name, sep)\
if ((ret = add_metadata(count, type, name, sep, s, frame)) < 0) {\