virtualenv/FFmpeg
1
0
Fork 0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2025-03-23 04:24:35 +02:00
Code Issues Releases Activity

avformat/oggparsevorbis: Update end_trimming for the last packet

Browse Source 
Without end_trimming, the last packet will contain unexpected samples used
for padding.

This commit partially fixes  when the audio length is long enough.

dd if=/dev/zero of=./silence.raw count=20 bs=500
oggenc --raw silence.raw --output=silence.ogg
oggdec --raw --output silence.oggdec.raw silence.ogg
ffmpeg -codec:a libvorbis -i silence.ogg -f s16le -codec:a pcm_s16le silence.libvorbis.ffmpeg.raw
ffmpeg -i silence.ogg -f s16le -codec:a pcm_s16le silence.native.ffmpeg.raw
ls -l *.raw

The original test case in  is still not fixed due to a remaining issue.

The remaining issue is that ogg_stream->private is not kept during
ogg_save()/ogg_restore(). Field final_duration in the private data is
important to calculate end_trimming.

Some common operations such as avformat_open_input() and
avformat_find_stream_info() before reading packet will trigger ogg_save()
and ogg_restore().

Luckily, final_duration will not get updated until the last ogg page. The
save/restore mentioned above will not change final_duration most of the
time. But if the audio length is short, those reads may be performed on
the last ogg page, causing trouble keeping the correct value of
final_duration. We probably need a more complicated patch to address this
issue.

Signed-off-by: Guangyu Sun <gsun@roblox.com>
This commit is contained in:
Guangyu Sun 2021-07-07 08:41:32 -07:00 committed by Lynne
parent ed240db9e3
commit 75510d7015
1 changed files with 5 additions and 1 deletions

6
libavformat/oggparsevorbis.c

@ -492,8 +492,12 @@ static int vorbis_packet(AVFormatContext *s, int idx)
priv->final_pts = os->lastpts;
priv->final_duration = 0;
}
if (os->segp == os->nsegs)
if (os->segp == os->nsegs) {
int64_t skip = priv->final_pts + priv->final_duration + os->pduration - os->granule;
if (skip > 0)
os->end_trimming = skip;
os->pduration = os->granule - priv->final_pts - priv->final_duration;
}
priv->final_duration += os->pduration;
}