virtualenv/FFmpeg
1
0
Fork 0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2025-08-15 14:13:16 +02:00
Code Issues Releases Activity

ffmpeg: check fclose return values

Browse Source 
In the spirit of commit a956840cbc. Simple method to reproduce:
pass -vstats_file /dev/full to ffmpeg.

All raw fclose usages in ffmpeg.c taken care of here.

Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>
This commit is contained in:
Ganesh Ajjanagadde
2016-01-06 20:57:47 -08:00
parent 2fbdc4faf1
commit 7ab37cae34
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
ffmpeg.c
View File

@@ -554,8 +554,12 @@ static void ffmpeg_cleanup(int ret)
av_freep(&input_streams[i]); av_freep(&input_streams[i]);
} }
if (vstats_file) if (vstats_file) {
fclose(vstats_file); if (fclose(vstats_file))
av_log(NULL, AV_LOG_ERROR,
"Error closing vstats file, loss of information possible: %s\n",
av_err2str(AVERROR(errno)));
}
av_freep(&vstats_filename); av_freep(&vstats_filename);
av_freep(&input_streams); av_freep(&input_streams);
@@ -4200,7 +4204,10 @@ static int transcode(void)
ost = output_streams[i]; ost = output_streams[i];
if (ost) { if (ost) {
if (ost->logfile) { if (ost->logfile) {
fclose(ost->logfile); if (fclose(ost->logfile))
av_log(NULL, AV_LOG_ERROR,
"Error closing logfile, loss of information possible: %s\n",
av_err2str(AVERROR(errno)));
ost->logfile = NULL; ost->logfile = NULL;
} }
av_freep(&ost->forced_kf_pts); av_freep(&ost->forced_kf_pts);