virtualenv/FFmpeg
1
0
Fork 0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2024-12-23 12:43:46 +02:00
Code Issues Releases Activity

avcodec/gdv: Remove dead check

Browse Source 
At the end of its decode function, the decoder sets *got_frame to 1 and
then checks whether ret is < 0; if so, it is returned, otherwise
avpkt->size is. But it is impossible for ret to be < 0 here and if it
were, it would be nonsense to set *got_frame to 1 before this. Therefore
just return avpkt->size unconditionally.

Fixes Coverity issue #1439730.

Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
This commit is contained in:
Andreas Rheinhardt 2020-11-05 21:35:56 +01:00
parent d2dcb113f8
commit 7e8306dd2d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libavcodec/gdv.c
View File

@ -551,7 +551,7 @@ static int gdv_decode_frame(AVCodecContext *avctx, void *data,
*got_frame = 1; *got_frame = 1;
return ret < 0 ? ret : avpkt->size; return avpkt->size;
} }
static av_cold int gdv_decode_close(AVCodecContext *avctx) static av_cold int gdv_decode_close(AVCodecContext *avctx)