virtualenv/FFmpeg
1
0
Fork 0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2025-08-15 14:13:16 +02:00
Code Issues Releases Activity

avdevice/decklink: fix leak when listing devices and there is no memory

Browse Source 
Fixes Coverity CID 1419523.

Signed-off-by: Marton Balint <cus@passwd.hu>
This commit is contained in:
Marton Balint
2018-03-17 12:41:15 +01:00
parent 5f6126ea7f
commit 87455b78cc
1 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
libavdevice/decklink_common.cpp
View File

@@ -322,21 +322,14 @@ int ff_decklink_list_devices(AVFormatContext *avctx,
ret = AVERROR(ENOMEM); ret = AVERROR(ENOMEM);
goto next; goto next;
} }
new_device->device_name = av_strdup(displayName); new_device->device_name = av_strdup(displayName);
if (!new_device->device_name) {
ret = AVERROR(ENOMEM);
goto next;
}
new_device->device_description = av_strdup(displayName); new_device->device_description = av_strdup(displayName);
if (!new_device->device_description) {
av_freep(&new_device->device_name);
ret = AVERROR(ENOMEM);
goto next;
}
if ((ret = av_dynarray_add_nofree(&device_list->devices, if (!new_device->device_name ||
&device_list->nb_devices, new_device)) < 0) { !new_device->device_description ||
av_dynarray_add_nofree(&device_list->devices, &device_list->nb_devices, new_device) < 0) {
ret = AVERROR(ENOMEM);
av_freep(&new_device->device_name); av_freep(&new_device->device_name);
av_freep(&new_device->device_description); av_freep(&new_device->device_description);
av_freep(&new_device); av_freep(&new_device);