From 9908c1a8bf19c5bc40a49114cc42dc2fa7efe455 Mon Sep 17 00:00:00 2001 From: Diego Biurrun Date: Mon, 4 Feb 2008 12:16:14 +0000 Subject: [PATCH] Update policy entry about compiler warnings to reflect ml discussions. Originally committed as revision 11858 to svn://svn.ffmpeg.org/ffmpeg/trunk --- doc/general.texi | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/doc/general.texi b/doc/general.texi index 57223b6e92..d77f4f0577 100644 --- a/doc/general.texi +++ b/doc/general.texi @@ -825,8 +825,13 @@ should also be avoided if they don't make the code easier to understand. it has a fourcc, add it to @file{libavformat/avienc.c}, even if it is only a decoder. @item - Do not change code to hide warnings without ensuring that the underlying - logic is correct and thus the warning was inappropriate. + Compiler warnings indicate bugs or code with bad style. If a type of + warning always points to correct and clean code, that warning should + be disabled, not the code changed. + Thus the remaining warnings can either be bugs or correct code. + If it is a bug, it has to be fixed. If it is not, the code should + be changed to not generate a warning unless that causes a slowdown + or obfuscates the code. @item If you add a new file, give it a proper license header. Do not copy and paste it from a random place, use an existing file as template.