virtualenv/FFmpeg
1
0
Fork 0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2025-08-10 06:10:52 +02:00
Code Issues Releases Activity

avformat/tls_openssl: fix X509 cert serial number might be negative

Browse Source 
See RFC5280 4.1.2.2

Signed-off-by: Jack Lau <jacklau1222@qq.com>
This commit is contained in:
winlin
2025-06-10 14:53:08 -04:00
committed by Kacper Michajłow
parent 49f4ef9e79
commit a72cc49e8a
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
libavformat/tls_openssl.c
View File

@@ -315,7 +315,8 @@ end:
static int openssl_gen_certificate(EVP_PKEY *pkey, X509 **cert, char **fingerprint) static int openssl_gen_certificate(EVP_PKEY *pkey, X509 **cert, char **fingerprint)
{ {
int ret = 0, serial, expire_day; int ret = 0, expire_day;
uint64_t serial;
const char *aor = "lavf"; const char *aor = "lavf";
X509_NAME* subject = NULL; X509_NAME* subject = NULL;
@@ -330,8 +331,8 @@ static int openssl_gen_certificate(EVP_PKEY *pkey, X509 **cert, char **fingerpri
goto enomem_end; goto enomem_end;
} }
serial = (int)av_get_random_seed(); serial = av_get_random_seed();
if (ASN1_INTEGER_set(X509_get_serialNumber(*cert), serial) != 1) { if (ASN1_INTEGER_set_uint64(X509_get_serialNumber(*cert), serial) != 1) {
av_log(NULL, AV_LOG_ERROR, "TLS: Failed to set serial, %s\n", ERR_error_string(ERR_get_error(), NULL)); av_log(NULL, AV_LOG_ERROR, "TLS: Failed to set serial, %s\n", ERR_error_string(ERR_get_error(), NULL));
goto einval_end; goto einval_end;
} }