From ae36d6cdde0799099dee0397427438bfc86bc1d9 Mon Sep 17 00:00:00 2001 From: James Almer Date: Tue, 20 Mar 2018 00:55:27 -0300 Subject: [PATCH] avcodec/h265_metadata: fix memory leak in case of output packet creation failure Some function calls may fail after the output packet is initialized. Reviewed-by: jkqxz Signed-off-by: James Almer --- libavcodec/h265_metadata_bsf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/h265_metadata_bsf.c b/libavcodec/h265_metadata_bsf.c index 8759e410f3..26eb2d05d0 100644 --- a/libavcodec/h265_metadata_bsf.c +++ b/libavcodec/h265_metadata_bsf.c @@ -239,7 +239,7 @@ static int h265_metadata_filter(AVBSFContext *bsf, AVPacket *out) err = ff_bsf_get_packet(bsf, &in); if (err < 0) - goto fail; + return err; err = ff_cbs_read_packet(ctx->cbc, au, in); if (err < 0) { @@ -324,6 +324,8 @@ static int h265_metadata_filter(AVBSFContext *bsf, AVPacket *out) fail: ff_cbs_fragment_uninit(ctx->cbc, au); + if (err < 0) + av_packet_unref(out); av_packet_free(&in); return err;