virtualenv/FFmpeg
1
0
Fork 0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2025-06-04 05:57:49 +02:00
Code Issues Releases Activity

avcodec/alac: Fix multiple integer overflows in lpc_prediction()

Browse Source 
Fixes: signed integer overflow: 2088795537 + 2147254401 cannot be represented in type 'int'
Fixes: signed integer overflow: -1500363496 + -1295351808 cannot be represented in type 'int'
Fixes: signed integer overflow: -79560 * 32640 cannot be represented in type 'int'
Fixes: signed integer overflow: 2088910005 + 2088796058 cannot be represented in type 'int'
Fixes: signed integer overflow: -117258064 - 2088725225 cannot be represented in type 'int'
Fixes: signed integer overflow: 2088725225 - -117258064 cannot be represented in type 'int'
Fixes: 15739/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-5630664122040320

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
This commit is contained in:
Michael Niedermayer 2019-08-08 19:48:19 +02:00
parent 1c9a56b139
commit ae3d6a337a
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libavcodec/alac.c
View File

@ -171,12 +171,12 @@ static inline int sign_only(int v)
return v ? FFSIGN(v) : 0; return v ? FFSIGN(v) : 0;
} }
static void lpc_prediction(int32_t *error_buffer, int32_t *buffer_out, static void lpc_prediction(int32_t *error_buffer, uint32_t *buffer_out,
int nb_samples, int bps, int16_t *lpc_coefs, int nb_samples, int bps, int16_t *lpc_coefs,
int lpc_order, int lpc_quant) int lpc_order, int lpc_quant)
{ {
int i; int i;
int32_t *pred = buffer_out; uint32_t *pred = buffer_out;
/* first sample always copies */ /* first sample always copies */
*buffer_out = *error_buffer; *buffer_out = *error_buffer;
@ -208,7 +208,7 @@ static void lpc_prediction(int32_t *error_buffer, int32_t *buffer_out,
for (; i < nb_samples; i++) { for (; i < nb_samples; i++) {
int j; int j;
int val = 0; int val = 0;
int error_val = error_buffer[i]; unsigned error_val = error_buffer[i];
int error_sign; int error_sign;
int d = *pred++; int d = *pred++;
@ -222,7 +222,7 @@ static void lpc_prediction(int32_t *error_buffer, int32_t *buffer_out,
/* adapt LPC coefficients */ /* adapt LPC coefficients */
error_sign = sign_only(error_val); error_sign = sign_only(error_val);
if (error_sign) { if (error_sign) {
for (j = 0; j < lpc_order && error_val * error_sign > 0; j++) { for (j = 0; j < lpc_order && (int)error_val * error_sign > 0; j++) {
int sign; int sign;
val = d - pred[j]; val = d - pred[j];
sign = sign_only(val) * error_sign; sign = sign_only(val) * error_sign;