From afd04058bc910e4a3b1017e03ea543d8be395818 Mon Sep 17 00:00:00 2001 From: James Almer Date: Thu, 16 Jun 2016 19:17:26 -0300 Subject: [PATCH] avformat/oggparsevorbis: free base64 encoded data immediately after decoding it It has no use afterwards and freeing it before calling ff_flac_parse_picture() may help prevent OOM issues on memory constrained scenarios. Signed-off-by: James Almer --- libavformat/oggparsevorbis.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/oggparsevorbis.c b/libavformat/oggparsevorbis.c index c16871873e..89f40f6379 100644 --- a/libavformat/oggparsevorbis.c +++ b/libavformat/oggparsevorbis.c @@ -161,10 +161,11 @@ int ff_vorbis_comment(AVFormatContext *as, AVDictionary **m, av_freep(&ct); continue; } - if ((ret = av_base64_decode(pict, ct, len)) > 0) - ret = ff_flac_parse_picture(as, pict, ret); + ret = av_base64_decode(pict, ct, len); av_freep(&tt); av_freep(&ct); + if (ret > 0) + ret = ff_flac_parse_picture(as, pict, ret); av_freep(&pict); if (ret < 0) { av_log(as, AV_LOG_WARNING, "Failed to parse cover art block.\n");