mirror of
https://github.com/FFmpeg/FFmpeg.git
synced 2025-01-24 13:56:33 +02:00
avformat/sdp: Check before appending ","
Found by reviewing code related to CID1500301 String not null terminated Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 5b82852519e92a2b94de0f22da1a81df5b3e0412) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
This commit is contained in:
parent
ca087aac86
commit
b09cadf2ef
@ -202,6 +202,8 @@ static int extradata2psets(AVFormatContext *s, const AVCodecParameters *par,
|
||||
continue;
|
||||
}
|
||||
if (p != (psets + strlen(pset_string))) {
|
||||
if (p - psets >= MAX_PSET_SIZE)
|
||||
goto fail_in_loop;
|
||||
*p = ',';
|
||||
p++;
|
||||
}
|
||||
@ -212,6 +214,7 @@ static int extradata2psets(AVFormatContext *s, const AVCodecParameters *par,
|
||||
if (!av_base64_encode(p, MAX_PSET_SIZE - (p - psets), r, r1 - r)) {
|
||||
av_log(s, AV_LOG_ERROR, "Cannot Base64-encode %"PTRDIFF_SPECIFIER" %"PTRDIFF_SPECIFIER"!\n",
|
||||
MAX_PSET_SIZE - (p - psets), r1 - r);
|
||||
fail_in_loop:
|
||||
av_free(psets);
|
||||
av_free(tmpbuf);
|
||||
|
||||
|
Loading…
x
Reference in New Issue
Block a user