From beb3aea48e5f8a3d57f244fb8998ddf04928ee81 Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Thu, 27 Sep 2018 00:00:24 +0200 Subject: [PATCH] avformat/utils: Do not ignore failure in extract_extradata_init() We check for the documented explanation of the "Ignore code" in extract_extradata_check() already Signed-off-by: Michael Niedermayer --- libavformat/utils.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index c973a7e0c5..7e5783c14c 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -3489,13 +3489,9 @@ static int extract_extradata_init(AVStream *st) i->extract_extradata.bsf->time_base_in = st->time_base; - /* if init fails here, we assume extracting extradata is just not - * supported for this codec, so we return success */ ret = av_bsf_init(i->extract_extradata.bsf); - if (ret < 0) { - av_bsf_free(&i->extract_extradata.bsf); - ret = 0; - } + if (ret < 0) + goto fail; finish: i->extract_extradata.inited = 1;