virtualenv/FFmpeg
1
0
Fork 0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2025-02-04 06:08:26 +02:00
Code Issues Releases Activity

avfilter/af_afir: Check return value of av_tx_init()

Browse Source 
Should fix Coverity issue #1516762.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
This commit is contained in:
Andreas Rheinhardt 2022-11-09 16:58:04 +01:00
parent 36d0550bc9
commit c787eab395
1 changed files with 17 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
libavfilter/af_afir.c
View File

@ -158,6 +158,7 @@ static int init_segment(AVFilterContext *ctx, AudioFIRSegment *seg,
int offset, int nb_partitions, int part_size) int offset, int nb_partitions, int part_size)
{ {
AudioFIRContext *s = ctx->priv; AudioFIRContext *s = ctx->priv;
int ret;
seg->tx = av_calloc(ctx->inputs[0]->ch_layout.nb_channels, sizeof(*seg->tx)); seg->tx = av_calloc(ctx->inputs[0]->ch_layout.nb_channels, sizeof(*seg->tx));
seg->itx = av_calloc(ctx->inputs[0]->ch_layout.nb_channels, sizeof(*seg->itx)); seg->itx = av_calloc(ctx->inputs[0]->ch_layout.nb_channels, sizeof(*seg->itx));
@ -178,22 +179,29 @@ static int init_segment(AVFilterContext *ctx, AudioFIRSegment *seg,
return AVERROR(ENOMEM); return AVERROR(ENOMEM);
for (int ch = 0; ch < ctx->inputs[0]->ch_layout.nb_channels && part_size >= 8; ch++) { for (int ch = 0; ch < ctx->inputs[0]->ch_layout.nb_channels && part_size >= 8; ch++) {
double dscale = 1.0, idscale = 1.0 / part_size; union { double d; float f; } scale, iscale;
float fscale = 1.f, ifscale = 1.f / part_size; enum AVTXType tx_type;
switch (s->format) { switch (s->format) {
case AV_SAMPLE_FMT_FLTP: case AV_SAMPLE_FMT_FLTP:
av_tx_init(&seg->tx[ch], &seg->tx_fn, AV_TX_FLOAT_RDFT, 0, 2 * part_size, &fscale, 0); scale.f = 1.f;
av_tx_init(&seg->itx[ch], &seg->itx_fn, AV_TX_FLOAT_RDFT, 1, 2 * part_size, &ifscale, 0); iscale.f = 1.f / part_size;
tx_type = AV_TX_FLOAT_RDFT;
break; break;
case AV_SAMPLE_FMT_DBLP: case AV_SAMPLE_FMT_DBLP:
av_tx_init(&seg->tx[ch], &seg->tx_fn, AV_TX_DOUBLE_RDFT, 0, 2 * part_size, &dscale, 0); scale.d = 1.0;
av_tx_init(&seg->itx[ch], &seg->itx_fn, AV_TX_DOUBLE_RDFT, 1, 2 * part_size, &idscale, 0); iscale.d = 1.0 / part_size;
tx_type = AV_TX_DOUBLE_RDFT;
break; break;
} }
ret = av_tx_init(&seg->tx[ch], &seg->tx_fn, tx_type,
if (!seg->tx[ch] || !seg->itx[ch]) 0, 2 * part_size, &scale, 0);
return AVERROR(ENOMEM); if (ret < 0)
return ret;
ret = av_tx_init(&seg->itx[ch], &seg->itx_fn, tx_type,
1, 2 * part_size, &iscale, 0);
if (ret < 0)
return ret;
} }
seg->sumin = ff_get_audio_buffer(ctx->inputs[0], seg->fft_length); seg->sumin = ff_get_audio_buffer(ctx->inputs[0], seg->fft_length);