From ca087aac86564b0b31af9d203db40003645db51a Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Fri, 10 May 2024 03:48:10 +0200 Subject: [PATCH] avcodec/libx264: Check init_get_bits8() return code Fixes: CID1594529 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer (cherry picked from commit dce69ba89e37a956236b30663be893b7dae1567b) Signed-off-by: Michael Niedermayer --- libavcodec/libx264.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index eadb20d2b3..813ccbbdb3 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -929,7 +929,9 @@ static int set_avcc_extradata(AVCodecContext *avctx, x264_nal_t *nal, int nnal) * * +4 to skip until sps id. */ - init_get_bits8(&gbc, sps + 4, sps_nal->i_payload - 4 - 4); + ret = init_get_bits8(&gbc, sps + 4, sps_nal->i_payload - 4 - 4); + if (ret < 0) + return ret; // Skip sps id get_ue_golomb_31(&gbc); chroma_format_idc = get_ue_golomb_31(&gbc);