virtualenv/FFmpeg
1
0
Fork 0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2025-07-16 22:42:38 +02:00
Code Issues Releases Activity

avformat/mp3enc: use av_copy_packet()

Browse Source 
Fixes double free
Fixes Ticket3476

Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
This commit is contained in:
Michael Niedermayer
2014-03-22 01:26:48 +01:00
parent 1b4f2fb165
commit d003a0cd2e
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
libavformat/mp3enc.c
View File

@ -417,14 +417,14 @@ static int mp3_write_packet(AVFormatContext *s, AVPacket *pkt)
if (mp3->pics_to_write) { if (mp3->pics_to_write) {
/* buffer audio packets until we get all the pictures */ /* buffer audio packets until we get all the pictures */
AVPacketList *pktl = av_mallocz(sizeof(*pktl)); AVPacketList *pktl = av_mallocz(sizeof(*pktl));
int ret;
if (!pktl) if (!pktl)
return AVERROR(ENOMEM); return AVERROR(ENOMEM);
pktl->pkt = *pkt; ret = av_copy_packet(&pktl->pkt, pkt);
pktl->pkt.buf = av_buffer_ref(pkt->buf); if (ret < 0) {
if (!pktl->pkt.buf) {
av_freep(&pktl); av_freep(&pktl);
return AVERROR(ENOMEM); return ret;
} }
if (mp3->queue_end) if (mp3->queue_end)