virtualenv/FFmpeg
1
0
Fork 0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2025-07-16 22:42:38 +02:00
Code Issues Releases Activity

avcodec/videotoolboxenc: Fix bitrate doesn't work as expected

Browse Source 
Commit 4ef5e7d472 add qmin/qmax support to videotoolbox encoder.
The default value of (qmin, qmax) is (2, 31), which makes bitrate
control doesn't work as users' expectations.

Signed-off-by: Zhao Zhili <zhilizhao@tencent.com>
This commit is contained in:
Zhao Zhili
2024-07-16 20:59:52 +08:00
parent 8030876d1c
commit d07da7539d
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
libavcodec/videotoolboxenc.c
View File

@ -2932,6 +2932,12 @@ static const AVOption h264_options[] = {
{ NULL }, { NULL },
}; };
static const FFCodecDefault vt_defaults[] = {
{"qmin", "-1"},
{"qmax", "-1"},
{NULL},
};
static const AVClass h264_videotoolbox_class = { static const AVClass h264_videotoolbox_class = {
.class_name = "h264_videotoolbox", .class_name = "h264_videotoolbox",
.item_name = av_default_item_name, .item_name = av_default_item_name,
@ -2947,6 +2953,7 @@ const FFCodec ff_h264_videotoolbox_encoder = {
.p.capabilities = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_DELAY, .p.capabilities = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_DELAY,
.priv_data_size = sizeof(VTEncContext), .priv_data_size = sizeof(VTEncContext),
.p.pix_fmts = avc_pix_fmts, .p.pix_fmts = avc_pix_fmts,
.defaults = vt_defaults,
.init = vtenc_init, .init = vtenc_init,
FF_CODEC_ENCODE_CB(vtenc_frame), FF_CODEC_ENCODE_CB(vtenc_frame),
.close = vtenc_close, .close = vtenc_close,
@ -2984,6 +2991,7 @@ const FFCodec ff_hevc_videotoolbox_encoder = {
AV_CODEC_CAP_HARDWARE, AV_CODEC_CAP_HARDWARE,
.priv_data_size = sizeof(VTEncContext), .priv_data_size = sizeof(VTEncContext),
.p.pix_fmts = hevc_pix_fmts, .p.pix_fmts = hevc_pix_fmts,
.defaults = vt_defaults,
.init = vtenc_init, .init = vtenc_init,
FF_CODEC_ENCODE_CB(vtenc_frame), FF_CODEC_ENCODE_CB(vtenc_frame),
.close = vtenc_close, .close = vtenc_close,
@ -3023,6 +3031,7 @@ const FFCodec ff_prores_videotoolbox_encoder = {
AV_CODEC_CAP_HARDWARE, AV_CODEC_CAP_HARDWARE,
.priv_data_size = sizeof(VTEncContext), .priv_data_size = sizeof(VTEncContext),
.p.pix_fmts = prores_pix_fmts, .p.pix_fmts = prores_pix_fmts,
.defaults = vt_defaults,
.init = vtenc_init, .init = vtenc_init,
FF_CODEC_ENCODE_CB(vtenc_frame), FF_CODEC_ENCODE_CB(vtenc_frame),
.close = vtenc_close, .close = vtenc_close,