virtualenv/FFmpeg
1
0
Fork 0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2024-12-23 12:43:46 +02:00
Code Issues Releases Activity

h264: Fix handling of changing reference counts between slices

Browse Source 
Fixes out of array accesses

Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
This commit is contained in:
Michael Niedermayer 2013-02-20 19:43:58 +01:00
parent 039f55c803
commit da7672b20a
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libavcodec/h264.c
View File

@ -1655,6 +1655,7 @@ static int decode_update_thread_context(AVCodecContext *dst,
h->last_slice_type = h1->last_slice_type; h->last_slice_type = h1->last_slice_type;
h->sync = h1->sync; h->sync = h1->sync;
memcpy(h->last_ref_count, h1->last_ref_count, sizeof(h->last_ref_count));
if (context_reinitialized) if (context_reinitialized)
h264_set_parameter_from_sps(h); h264_set_parameter_from_sps(h);
@ -3103,7 +3104,9 @@ static int decode_slice_header(H264Context *h, H264Context *h0)
slice_type = golomb_to_pict_type[slice_type]; slice_type = golomb_to_pict_type[slice_type];
if (slice_type == AV_PICTURE_TYPE_I || if (slice_type == AV_PICTURE_TYPE_I ||
(h0->current_slice != 0 && slice_type == h0->last_slice_type)) { (h0->current_slice != 0 &&
slice_type == h0->last_slice_type &&
!memcmp(h0->last_ref_count, h0->ref_count, sizeof(h0->ref_count)))) {
default_ref_list_done = 1; default_ref_list_done = 1;
} }
h->slice_type = slice_type; h->slice_type = slice_type;
@ -3672,6 +3675,7 @@ static int decode_slice_header(H264Context *h, H264Context *h0)
6 * (h->sps.bit_depth_luma - 8); 6 * (h->sps.bit_depth_luma - 8);
h0->last_slice_type = slice_type; h0->last_slice_type = slice_type;
memcpy(h0->last_ref_count, h0->ref_count, sizeof(h0->last_ref_count));
h->slice_num = ++h0->current_slice; h->slice_num = ++h0->current_slice;
if (h->slice_num) if (h->slice_num)

1
libavcodec/h264.h
View File

@ -572,6 +572,7 @@ typedef struct H264Context {
enum AVPictureType pict_type; enum AVPictureType pict_type;
int last_slice_type; int last_slice_type;
unsigned int last_ref_count[2];
/** @} */ /** @} */
/** /**