virtualenv/FFmpeg
1
0
Fork 0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2025-01-24 13:56:33 +02:00
Code Issues Releases Activity

qsv: Initialize impl_value

Browse Source 
Fixes: The warnings from CID1598553 Uninitialized scalar variable

Passing partly initialized structs is ugly and asking for hard to rieproduce bugs,
The uninitialized fields where not used

Reviewed-by: "Xiang, Haihao" <haihao.xiang-at-intel.com@ffmpeg.org>
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit c841cb45e81ebece26768c820c459b085668a37a)
This commit is contained in:
Michael Niedermayer 2024-05-26 23:34:05 +02:00 committed by Timo Rothenpieler
parent c859363910
commit e3711d18f3
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libavcodec/qsv.c
View File

@ -496,7 +496,7 @@ static int qsv_new_mfx_loader(AVCodecContext *avctx,
mfxStatus sts; mfxStatus sts;
mfxLoader loader = NULL; mfxLoader loader = NULL;
mfxConfig cfg; mfxConfig cfg;
mfxVariant impl_value; mfxVariant impl_value = {0};
loader = MFXLoad(); loader = MFXLoad();
if (!loader) { if (!loader) {

8
libavutil/hwcontext_qsv.c
View File

@ -674,7 +674,7 @@ static int qsv_d3d11_update_config(void *ctx, mfxHDL handle, mfxConfig cfg)
IDXGIDevice *pDXGIDevice = NULL; IDXGIDevice *pDXGIDevice = NULL;
HRESULT hr; HRESULT hr;
ID3D11Device *device = handle; ID3D11Device *device = handle;
mfxVariant impl_value; mfxVariant impl_value = {0};
hr = ID3D11Device_QueryInterface(device, &IID_IDXGIDevice, (void**)&pDXGIDevice); hr = ID3D11Device_QueryInterface(device, &IID_IDXGIDevice, (void**)&pDXGIDevice);
if (SUCCEEDED(hr)) { if (SUCCEEDED(hr)) {
@ -748,7 +748,7 @@ static int qsv_d3d9_update_config(void *ctx, mfxHDL handle, mfxConfig cfg)
LUID luid; LUID luid;
D3DDEVICE_CREATION_PARAMETERS params; D3DDEVICE_CREATION_PARAMETERS params;
HRESULT hr; HRESULT hr;
mfxVariant impl_value; mfxVariant impl_value = {0};
hr = IDirect3DDeviceManager9_OpenDeviceHandle(devmgr, &device_handle); hr = IDirect3DDeviceManager9_OpenDeviceHandle(devmgr, &device_handle);
if (FAILED(hr)) { if (FAILED(hr)) {
@ -830,7 +830,7 @@ static int qsv_va_update_config(void *ctx, mfxHDL handle, mfxConfig cfg)
VADisplayAttribute attr = { VADisplayAttribute attr = {
.type = VADisplayPCIID, .type = VADisplayPCIID,
}; };
mfxVariant impl_value; mfxVariant impl_value = {0};
vas = vaGetDisplayAttributes(dpy, &attr, 1); vas = vaGetDisplayAttributes(dpy, &attr, 1);
if (vas == VA_STATUS_SUCCESS && attr.flags != VA_DISPLAY_ATTRIB_NOT_SUPPORTED) { if (vas == VA_STATUS_SUCCESS && attr.flags != VA_DISPLAY_ATTRIB_NOT_SUPPORTED) {
@ -871,7 +871,7 @@ static int qsv_new_mfx_loader(void *ctx,
mfxStatus sts; mfxStatus sts;
mfxLoader loader = NULL; mfxLoader loader = NULL;
mfxConfig cfg; mfxConfig cfg;
mfxVariant impl_value; mfxVariant impl_value = {0};
*ploader = NULL; *ploader = NULL;
loader = MFXLoad(); loader = MFXLoad();