virtualenv/FFmpeg
1
0
Fork 0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2025-08-10 06:10:52 +02:00
Code Issues Releases Activity

vulkan/common: Use u32vec2 buffer type instead of u64

Browse Source 
According to the GL_EXT_buffer_reference spec alignment
"must be a power of two and be greater than or equal to the largest scalar/component type in the block."

This means by using u32vec2 we can drop the requirement alignment from 8 bytes to 4 bytes
and save a pack64 call in reverse8 (though I assume in most ISAs that compiles to nothing)

Allows the vc2 vulkan encoder to function without setting PB_UNALIGNED
This commit is contained in:
IndecisiveTurtle
2024-11-27 21:18:06 +02:00
committed by Lynne
parent f794ed48c0
commit e3ac63b213
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
libavcodec/vulkan/common.comp
View File

@@ -30,6 +30,10 @@ layout(buffer_reference, buffer_reference_align = 4) buffer u32buf {
uint32_t v; uint32_t v;
}; };
layout(buffer_reference, buffer_reference_align = 4) buffer u32vec2buf {
u32vec2 v;
};
layout(buffer_reference, buffer_reference_align = 8) buffer u64buf { layout(buffer_reference, buffer_reference_align = 8) buffer u64buf {
uint64_t v; uint64_t v;
}; };
@@ -70,12 +74,12 @@ uint64_t align64(uint64_t src, uint64_t a)
#define reverse4(src) \ #define reverse4(src) \
(pack32(unpack8(uint32_t(src)).wzyx)) (pack32(unpack8(uint32_t(src)).wzyx))
uint64_t reverse8(uint64_t src) u32vec2 reverse8(uint64_t src)
{ {
u32vec2 tmp = unpack32(src); u32vec2 tmp = unpack32(src);
tmp.x = reverse4(tmp.x); tmp.x = reverse4(tmp.x);
tmp.y = reverse4(tmp.y); tmp.y = reverse4(tmp.y);
return pack64(tmp.yx); return tmp.yx;
} }
#ifdef PB_32 #ifdef PB_32
@@ -88,7 +92,7 @@ uint64_t reverse8(uint64_t src)
(uint8_t(bitfieldExtract((src), ((byte_off) << 3), 8))) (uint8_t(bitfieldExtract((src), ((byte_off) << 3), 8)))
#else #else
#define BIT_BUF_TYPE uint64_t #define BIT_BUF_TYPE uint64_t
#define BUF_TYPE u64buf #define BUF_TYPE u32vec2buf
#define BUF_REVERSE(src) reverse8(src) #define BUF_REVERSE(src) reverse8(src)
#define BUF_BITS uint8_t(64) #define BUF_BITS uint8_t(64)
#define BUF_BYTES uint8_t(8) #define BUF_BYTES uint8_t(8)