From e55e8b2c362a60bad66929d83d8c83b0d7f5ffc9 Mon Sep 17 00:00:00 2001 From: Luca Barbato Date: Tue, 7 May 2013 02:02:51 +0200 Subject: [PATCH] lavc: do not leak frames in avcodec_decode_audio4 Notwithstanding the return value the frame should be freed if is not going to be used. Reported-by: Matthew Wolenetz --- libavcodec/utils.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index df4e30524d..a6a1a653ca 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -1463,9 +1463,7 @@ int attribute_align_arg avcodec_decode_audio4(AVCodecContext *avctx, frame->extended_buf = NULL; frame->nb_extended_buf = 0; } - } - - if (ret < 0 && frame->data[0]) + } else if (frame->data[0]) av_frame_unref(frame); }