virtualenv/FFmpeg
1
0
Fork 0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2025-04-02 20:35:37 +02:00
Code Issues Releases Activity

dds: Fix the slice size computation

Browse Source 
A bug was introduced in 6b2b26e7af3ede0abfb46eb5725c26d1083f50bc whereby when
frame height wasn't divisible by the number of threads, pixels would be omitted
from the bottom rows during decode.

Signed-off-by: Luca Barbato <lu_zero@gentoo.org>
This commit is contained in:
Tom Butterworth 2015-07-23 00:03:29 +01:00 committed by Luca Barbato
parent 22ecfcd4c7
commit ebe8b5d947
1 changed files with 17 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
libavcodec/dds.c
View File

@ -105,7 +105,7 @@ typedef struct DDSContext {
const uint8_t *tex_data; // Compressed texture const uint8_t *tex_data; // Compressed texture
int tex_ratio; // Compression ratio int tex_ratio; // Compression ratio
int slice_size; // Optimal slice size int slice_count; // Number of slices for threaded operations
/* Pointer to the selected compress or decompress function. */ /* Pointer to the selected compress or decompress function. */
int (*tex_funct)(uint8_t *dst, ptrdiff_t stride, const uint8_t *block); int (*tex_funct)(uint8_t *dst, ptrdiff_t stride, const uint8_t *block);
@ -421,14 +421,23 @@ static int decompress_texture_thread(AVCodecContext *avctx, void *arg,
AVFrame *frame = arg; AVFrame *frame = arg;
const uint8_t *d = ctx->tex_data; const uint8_t *d = ctx->tex_data;
int w_block = avctx->coded_width / TEXTURE_BLOCK_W; int w_block = avctx->coded_width / TEXTURE_BLOCK_W;
int h_block = avctx->coded_height / TEXTURE_BLOCK_H;
int x, y; int x, y;
int start_slice, end_slice; int start_slice, end_slice;
int base_blocks_per_slice = h_block / ctx->slice_count;
int remainder_blocks = h_block % ctx->slice_count;
start_slice = slice * ctx->slice_size; /* When the frame height (in blocks) doesn't divide evenly between the
end_slice = FFMIN(start_slice + ctx->slice_size, avctx->coded_height); * number of slices, spread the remaining blocks evenly between the first
* operations */
start_slice = slice * base_blocks_per_slice;
/* Add any extra blocks (one per slice) that have been added before this slice */
start_slice += FFMIN(slice, remainder_blocks);
start_slice /= TEXTURE_BLOCK_H; end_slice = start_slice + base_blocks_per_slice;
end_slice /= TEXTURE_BLOCK_H; /* Add an extra block if there are still remainder blocks to be accounted for */
if (slice < remainder_blocks)
end_slice++;
for (y = start_slice; y < end_slice; y++) { for (y = start_slice; y < end_slice; y++) {
uint8_t *p = frame->data[0] + y * frame->linesize[0] * TEXTURE_BLOCK_H; uint8_t *p = frame->data[0] + y * frame->linesize[0] * TEXTURE_BLOCK_H;
@ -633,13 +642,12 @@ static int dds_decode(AVCodecContext *avctx, void *data,
return ret; return ret;
if (ctx->compressed) { if (ctx->compressed) {
int slices = FFMIN(avctx->thread_count, ctx->slice_count = av_clip(avctx->thread_count, 1,
avctx->coded_height / TEXTURE_BLOCK_H); avctx->coded_height / TEXTURE_BLOCK_H);
ctx->slice_size = avctx->coded_height / slices;
/* Use the decompress function on the texture, one block per thread. */ /* Use the decompress function on the texture, one block per thread. */
ctx->tex_data = gbc->buffer; ctx->tex_data = gbc->buffer;
avctx->execute2(avctx, decompress_texture_thread, frame, NULL, slices); avctx->execute2(avctx, decompress_texture_thread, frame, NULL, ctx->slice_count);
} else { } else {
int linesize = av_image_get_linesize(avctx->pix_fmt, frame->width, 0); int linesize = av_image_get_linesize(avctx->pix_fmt, frame->width, 0);