From ee1f79b0fa4c82da9c19328b049b593c71611402 Mon Sep 17 00:00:00 2001 From: Lidong Yan Date: Tue, 17 Jun 2025 22:14:15 +0800 Subject: [PATCH] avformat/sbgdec: fix leak in sbg_read_header() In sbg_read_header(), if avformat_new_stream() failed, it returns without cleanup, which may cause memory leaks. Replace return statement with goto so that we would first clean up then return. Signed-off-by: Lidong Yan <502024330056@smail.nju.edu.cn> Reviewed-by: Nicolas George Signed-off-by: James Almer --- libavformat/sbgdec.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/sbgdec.c b/libavformat/sbgdec.c index bf319be228..4afb51b844 100644 --- a/libavformat/sbgdec.c +++ b/libavformat/sbgdec.c @@ -1434,8 +1434,10 @@ static av_cold int sbg_read_header(AVFormatContext *avf) } st = avformat_new_stream(avf, NULL); - if (!st) - return AVERROR(ENOMEM); + if (!st) { + r = AVERROR(ENOMEM); + goto fail; + } sti = ffstream(st); st->codecpar->codec_type = AVMEDIA_TYPE_AUDIO; st->codecpar->codec_id = AV_CODEC_ID_FFWAVESYNTH;