From f02832904dbce8e0473cdc9c7b09d92493b40a14 Mon Sep 17 00:00:00 2001 From: James Darnley Date: Sat, 22 Mar 2014 09:48:52 +0100 Subject: [PATCH] lavc/libx264: add a warning when using qscale This addresses ticket #3238. Signed-off-by: Michael Niedermayer --- libavcodec/libx264.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 60076301a6..ebaf351680 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -330,6 +330,9 @@ static av_cold int X264_init(AVCodecContext *avctx) X264Context *x4 = avctx->priv_data; int sw,sh; + if (avctx->global_quality > 0) + av_log(avctx, AV_LOG_WARNING, "-qscale is ignored, -crf is recommended.\n"); + x264_param_default(&x4->params); x4->params.b_deblocking_filter = avctx->flags & CODEC_FLAG_LOOP_FILTER;