1
0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2024-12-23 12:43:46 +02:00

Merge remote-tracking branch 'hexene/stagefright'

* hexene/stagefright:
  libstagefright: start decode_thread() only after decode_frame() is called at least once.
  libstagefright: mark the dummy frame as keyframe.
  libstagefright: limit the output queue size
  libstagefright: return EOS if CustomSource::read() is called after decode_thread() returns
  libstagefright: set the correct frame size

Merged-by: Michael Niedermayer <michaelni@gmx.at>
This commit is contained in:
Michael Niedermayer 2011-10-07 15:32:14 +02:00
commit f22bc68dc0

View File

@ -66,7 +66,7 @@ struct StagefrightContext {
Frame *end_frame;
bool source_done;
volatile sig_atomic_t thread_exited, stop_decode;
volatile sig_atomic_t thread_started, thread_exited, stop_decode;
AVFrame ret_frame;
@ -104,6 +104,8 @@ public:
Frame *frame;
status_t ret;
if (s->thread_exited)
return ERROR_END_OF_STREAM;
pthread_mutex_lock(&s->in_mutex);
while (s->in_queue->empty())
@ -172,7 +174,15 @@ void* decode_thread(void *arg)
decode_done = 1;
}
}
pthread_mutex_lock(&s->out_mutex);
while (true) {
pthread_mutex_lock(&s->out_mutex);
if (s->out_queue->size() >= 10) {
pthread_mutex_unlock(&s->out_mutex);
usleep(10000);
continue;
}
break;
}
s->out_queue->push_back(frame);
pthread_mutex_unlock(&s->out_mutex);
} while (!decode_done && !s->stop_decode);
@ -264,7 +274,6 @@ static av_cold int Stagefright_init(AVCodecContext *avctx)
pthread_mutex_init(&s->in_mutex, NULL);
pthread_mutex_init(&s->out_mutex, NULL);
pthread_cond_init(&s->condition, NULL);
pthread_create(&s->decode_thread_id, NULL, &decode_thread, avctx);
return 0;
fail:
@ -293,6 +302,11 @@ static int Stagefright_decode_frame(AVCodecContext *avctx, void *data,
AVPacket pkt = *avpkt;
int ret;
if (!s->thread_started) {
pthread_create(&s->decode_thread_id, NULL, &decode_thread, avctx);
s->thread_started = true;
}
if (avpkt && avpkt->data) {
av_bitstream_filter_filter(s->bsfc, avctx, NULL, &pkt.data, &pkt.size,
avpkt->data, avpkt->size, avpkt->flags & AV_PKT_FLAG_KEY);
@ -311,7 +325,7 @@ static int Stagefright_decode_frame(AVCodecContext *avctx, void *data,
frame = (Frame*)av_mallocz(sizeof(Frame));
if (avpkt->data) {
frame->status = OK;
frame->size = orig_size;
frame->size = avpkt->size;
// Stagefright can't handle negative timestamps -
// if needed, work around this by offsetting them manually?
if (avpkt->pts >= 0)
@ -324,8 +338,10 @@ static int Stagefright_decode_frame(AVCodecContext *avctx, void *data,
}
uint8_t *ptr = avpkt->data;
// The OMX.SEC decoder fails without this.
if (avpkt->size == orig_size + avctx->extradata_size)
if (avpkt->size == orig_size + avctx->extradata_size) {
ptr += avctx->extradata_size;
frame->size = orig_size;
}
memcpy(frame->buffer, ptr, orig_size);
} else {
frame->status = ERROR_END_OF_STREAM;
@ -428,15 +444,28 @@ static av_cold int Stagefright_close(AVCodecContext *avctx)
StagefrightContext *s = (StagefrightContext*)avctx->priv_data;
Frame *frame;
if (s->thread_started) {
if (!s->thread_exited) {
s->stop_decode = 1;
// Make sure decode_thread() doesn't get stuck
pthread_mutex_lock(&s->out_mutex);
while (!s->out_queue->empty()) {
frame = *s->out_queue->begin();
s->out_queue->erase(s->out_queue->begin());
if (frame->size)
frame->mbuffer->release();
av_freep(&frame);
}
pthread_mutex_unlock(&s->out_mutex);
// Feed a dummy frame prior to signalling EOF.
// This is required to terminate the decoder(OMX.SEC)
// when only one frame is read during stream info detection.
if (s->dummy_buf && (frame = (Frame*)av_mallocz(sizeof(Frame)))) {
frame->status = OK;
frame->size = s->dummy_bufsize;
frame->key = 1;
frame->buffer = s->dummy_buf;
pthread_mutex_lock(&s->in_mutex);
s->in_queue->push_back(frame);
@ -458,6 +487,9 @@ static av_cold int Stagefright_close(AVCodecContext *avctx)
if (s->ret_frame.data[0])
avctx->release_buffer(avctx, &s->ret_frame);
s->thread_started = false;
}
while (!s->in_queue->empty()) {
frame = *s->in_queue->begin();
s->in_queue->erase(s->in_queue->begin());