virtualenv/FFmpeg
1
0
Fork 0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2024-12-23 12:43:46 +02:00
Code Issues Releases Activity

checkasm: sw_scale: Produce more realistic test filter coefficients for yuv2yuvX

Browse Source 
This avoids triggering overflows in the filters, and avoids stray
test failures in the approximate functions on x86; due to rounding
differences, one implementation might overflow while another one
doesn't.

Signed-off-by: Martin Storsjö <martin@martin.st>
This commit is contained in:
Martin Storsjö 2022-08-17 23:25:02 +03:00
parent e1e981c65e
commit f921c58335
1 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
tests/checkasm/sw_scale.c
View File

@ -187,7 +187,6 @@ static void check_yuv2yuvX(int accurate)
uint8_t d_val = rnd(); uint8_t d_val = rnd();
memset(dither, d_val, LARGEST_INPUT_SIZE); memset(dither, d_val, LARGEST_INPUT_SIZE);
randomize_buffers((uint8_t*)src_pixels, LARGEST_FILTER * LARGEST_INPUT_SIZE * sizeof(int16_t)); randomize_buffers((uint8_t*)src_pixels, LARGEST_FILTER * LARGEST_INPUT_SIZE * sizeof(int16_t));
randomize_buffers((uint8_t*)filter_coeff, LARGEST_FILTER * sizeof(int16_t));
ctx = sws_alloc_context(); ctx = sws_alloc_context();
if (accurate) if (accurate)
ctx->flags |= SWS_ACCURATE_RND; ctx->flags |= SWS_ACCURATE_RND;
@ -201,6 +200,21 @@ static void check_yuv2yuvX(int accurate)
if (dstW <= osi) if (dstW <= osi)
continue; continue;
for (fsi = 0; fsi < FILTER_SIZES; ++fsi) { for (fsi = 0; fsi < FILTER_SIZES; ++fsi) {
// Generate filter coefficients for the given filter size,
// with some properties:
// - The coefficients add up to the intended sum (4096, 1<<12)
// - The coefficients contain negative values
// - The filter intermediates don't overflow for worst case
// inputs (all positive coefficients are coupled with
// input_max and all negative coefficients with input_min,
// or vice versa).
// Produce a filter with all coefficients set to
// -((1<<12)/(filter_size-1)) except for one (randomly chosen)
// which is set to ((1<<13)-1).
for (i = 0; i < filter_sizes[fsi]; ++i)
filter_coeff[i] = -((1 << 12) / (filter_sizes[fsi] - 1));
filter_coeff[rnd() % filter_sizes[fsi]] = (1 << 13) - 1;
src = av_malloc(sizeof(int16_t*) * filter_sizes[fsi]); src = av_malloc(sizeof(int16_t*) * filter_sizes[fsi]);
vFilterData = av_malloc((filter_sizes[fsi] + 2) * sizeof(union VFilterData)); vFilterData = av_malloc((filter_sizes[fsi] + 2) * sizeof(union VFilterData));
memset(vFilterData, 0, (filter_sizes[fsi] + 2) * sizeof(union VFilterData)); memset(vFilterData, 0, (filter_sizes[fsi] + 2) * sizeof(union VFilterData));