1
0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2024-12-23 12:43:46 +02:00

lavfi/afir: fix vpad.name leak

Fix vpad.name leak in error path, move the vpad related operation
only if enabled show IR frequency response.

Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
This commit is contained in:
Jun Zhao 2020-05-25 08:48:12 +08:00
parent 77e15f01fb
commit ff8329a730

View File

@ -876,6 +876,12 @@ static av_cold int init(AVFilterContext *ctx)
if (!pad.name) if (!pad.name)
return AVERROR(ENOMEM); return AVERROR(ENOMEM);
ret = ff_insert_outpad(ctx, 0, &pad);
if (ret < 0) {
av_freep(&pad.name);
return ret;
}
if (s->response) { if (s->response) {
vpad = (AVFilterPad){ vpad = (AVFilterPad){
.name = av_strdup("filter_response"), .name = av_strdup("filter_response"),
@ -884,15 +890,7 @@ static av_cold int init(AVFilterContext *ctx)
}; };
if (!vpad.name) if (!vpad.name)
return AVERROR(ENOMEM); return AVERROR(ENOMEM);
}
ret = ff_insert_outpad(ctx, 0, &pad);
if (ret < 0) {
av_freep(&pad.name);
return ret;
}
if (s->response) {
ret = ff_insert_outpad(ctx, 1, &vpad); ret = ff_insert_outpad(ctx, 1, &vpad);
if (ret < 0) { if (ret < 0) {
av_freep(&vpad.name); av_freep(&vpad.name);