Marton Balint
0d6ef6f545
fftools/textformat: correctly propagate uninit error codes
...
This allows catching IO errors occuring at file close.
Signed-off-by: Marton Balint <cus@passwd.hu >
2025-05-16 20:43:58 +02:00
softworkz
cee7b8a051
fftools/textformat: Introduce common header and deduplicate code
...
Also change writer_printf signature in AVTextWriter to use va_list,
so that it can be called by the new function writer_printf()
in tf_internal.h.
Reviewed-by: Stefano Sabatini <stefasab@gmail.com >
Signed-off-by: softworkz <softworkz@hotmail.com >
2025-05-15 23:04:44 +02:00
softworkz
5f90eea8a8
fftools/textformat: Apply quality improvements
...
Perform multiple improvements to increase code robustness.
In particular:
- favor unsigned counters for loops
- add missing checks
- avoid possible leaks
- move variable declarations to inner scopes when feasible
- provide explicit type-casting when needed
Signed-off-by: softworkz <softworkz@hotmail.com >
2025-05-15 23:04:44 +02:00
Andreas Rheinhardt
b9450583bc
textformat/tw_avio: Remove close_on_uninit param from create_file
...
avtextwriter_create_file() creates an AVIOContext whose pointer
resides in its private context. If it were not always closed on
uninit, the AVIOContext would leak, so it makes no sense
to have this parameter.
Reviewed-by: softworkz . <softworkz-at-hotmail.com@ffmpeg.org >
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com >
2025-04-16 06:12:09 +02:00
Andreas Rheinhardt
f73badbf47
fftools/textformat/tw_avio: Use avio_closep()
...
Avoids leaving dangling pointers behind.
Reviewed-by: softworkz . <softworkz-at-hotmail.com@ffmpeg.org >
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com >
2025-04-16 06:12:05 +02:00
Andreas Rheinhardt
79fa31d159
fftools/textformat/tw_avio: Don't flush unnecessarily
...
avio_close() automatically flushes the AVIOContext.
Reviewed-by: softworkz . <softworkz-at-hotmail.com@ffmpeg.org >
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com >
2025-04-16 06:11:58 +02:00
Andreas Rheinhardt
395c91347f
fftools/textformat/tw_avio: Remove unused private class
...
This AVTextWriter does not have any options.
Reviewed-by: softworkz . <softworkz-at-hotmail.com@ffmpeg.org >
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com >
2025-04-16 06:11:52 +02:00
softworkz
97d680d450
fftools/textformat: Extract and generalize textformat api from ffprobe.c
...
Signed-off-by: softworkz <softworkz@hotmail.com >
2025-04-11 03:06:47 +02:00
