Anton Khirnov
3d01996b24
fftools/ffmpeg_filter: change processing order in fg_finalise_bindings()
...
First bind all inputs in all filtergraphs, only then check that all
outputs are bound.
Needed by the following commit.
2024-04-09 10:34:18 +02:00
Anton Khirnov
243a51490a
fftools/ffmpeg_filter: only store complex filtergraphs in global array
...
Store simple filtergraphs in the stream they feed. Keeping the two
separate will be useful in following commits.
2024-04-09 10:34:18 +02:00
Anton Khirnov
d74cbcb963
fftools/ffmpeg_filter: drop OutputFilter.ost
...
All remaining code accessing it only needs to know whether this
filtergraph output has been bound or not.
2024-04-09 10:34:18 +02:00
Anton Khirnov
f2c919252d
fftools/ffmpeg_filter: accept encoder thread count through OutputFilterOptions
...
Stop digging through encoder options manually.
Will allow decoupling filtering from encoding in future commits.
2024-04-09 10:34:18 +02:00
Anton Khirnov
a4c940c86a
fftools/ffmpeg_filter: move most of -apad logic to the muxer
...
The decision whether -apad actually does anything is made based on muxer
properties, and so more properly belongs there. Filtering code only
receives the result.
2024-04-09 10:34:18 +02:00
Anton Khirnov
a2892dbe06
fftools/ffmpeg_filter: pass trim parameters through OutputFilterOptions
...
Do not read them from OutputStream directly.
Will allow decoupling filtering from encoding in future commits.
2024-04-09 10:34:18 +02:00
Anton Khirnov
83304f7c1f
fftools/ffmpeg_filter: pass autoscale through OutputFilterOptions
...
Do not read it from OutputStream directly.
Will allow decoupling filtering from encoding in future commits.
2024-04-09 10:34:18 +02:00
Anton Khirnov
b8e6802023
fftools/ffmpeg_filter: pass sws/swr opts through OutputFilterOptions
...
Do not read them from OutputStream directly.
Will allow decoupling filtering from encoding in future commits.
2024-04-09 10:34:18 +02:00
Anton Khirnov
23c23077fc
fftools/ffmpeg_filter: drop an unnecessary use of OutputStream
...
OutputFilter.type contains the same information.
2024-04-09 10:34:18 +02:00
Anton Khirnov
fc6354c39c
fftools/ffmpeg_filter: add an AVClass to OutputFilter
...
Use it for logging where appropriate, avoid logging to OutputStream as
we do not own it.
This is a step towards decoupling filtering from encoding.
2024-04-09 10:34:18 +02:00
Anton Khirnov
3c3e04c8a3
fftools/ffmpeg_filter: simplify retrieving filter type
2024-04-09 10:34:18 +02:00
Anton Khirnov
114cbaa316
fftools/ffmpeg_filter: drop a redundant check
...
fg_finalise_bindings() already checks that all filtergraph outputs are
connected.
2024-04-09 10:34:18 +02:00
Anton Khirnov
da80e0b077
fftools/ffmpeg_filter: accept a caller-provided output name
...
Do not construct it from OutputStream manually.
Will allow decoupling filtering from encoding in future commits.
2024-04-09 10:34:18 +02:00
Anton Khirnov
82c7c21b18
fftools/ffmpeg: drop OutputStream.is_cfr
...
It is used in a single place in the filtering code, so it is better to
inline it there.
2024-04-09 10:34:18 +02:00
Anton Khirnov
509afedaaf
fftools/ffmpeg_filter: pass vsync method through OutputFilterOptions
...
Do not read it from OutputStream directly.
Will allow decoupling filtering from encoding in future commits.
2024-04-09 10:34:18 +02:00
Anton Khirnov
bc206ed1b3
fftools/ffmpeg_filter: stop accessing encoder AVCodecContext
...
Pass all the necessary value through OutputFilterOptions.
Will allow decoupling filtering from encoding in future commits.
2024-04-09 10:34:18 +02:00
Anton Khirnov
17702c5f7b
fftools/ffmpeg_filter: move the MJPEG format selection hack to muxer setup
...
That, if anywhere, is a more appropriate place for it.
2024-04-09 10:34:18 +02:00
Anton Khirnov
9d5bf2d69e
fftools/ffmpeg_filter: pass enc_timebase through OutputFilterOptions
...
Reduces the need to access OutputStream, which will allow decoupling
filtering from encoding in future commits.
2024-04-09 10:34:18 +02:00
Anton Khirnov
e903c31fd1
fftools/ffmpeg_filter: pass keep_pix_fmt through OutputFilterOptions
...
Reduces the need to access OutputStream, which will allow decoupling
filtering from encoding in future commits.
2024-04-09 10:34:18 +02:00
Anton Khirnov
b3864e7a08
fftools/ffmpeg_filter: pass ts offset through OutputFilterOptions
...
Reduces the need to access OutputFile, which will allow decoupling
filtering from encoding in future commits.
2024-04-09 10:34:18 +02:00
Anton Khirnov
651c79da36
fftools/ffmpeg_filter: check that filter type matches output stream type
...
For simple filtergraphs. For complex filtergraphs they always match.
2024-04-09 10:34:18 +02:00
Anton Khirnov
8e35e33d42
fftools/ffmpeg_filter: stop accessing AVCodecContext.codec
...
Instead pass the encoder through a newly-added output options struct,
analogous to previously added input options.
Will allow decoupling filtering from encoding in future commits.
2024-04-09 10:34:18 +02:00
Anton Khirnov
8c33085313
fftools/ffmpeg_filter: do not pass OutputStream to set_channel_layout()
...
It only needs a list of allowed layouts and the requested layout.
2024-04-09 10:34:18 +02:00
Andreas Rheinhardt
790f793844
avutil/common: Don't auto-include mem.h
...
There are lots of files that don't need it: The number of object
files that actually need it went down from 2011 to 884 here.
Keep it for external users in order to not cause breakages.
Also improve the other headers a bit while just at it.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
2024-03-31 00:08:43 +01:00
Anton Khirnov
106131bb10
fftools/ffmpeg_filter: remove display matrix if we have applied it
2024-03-28 08:40:01 +01:00
James Almer
767e7d3d2b
fftools/ffmpeg_filter: remove unused struct from InputFilterPriv
...
It's already in InputFilterOptions.
Signed-off-by: James Almer <jamrial@gmail.com>
2024-03-25 23:23:27 -03:00
Anton Khirnov
a9193f7b7d
fftools/ffmpeg: add loopback decoding
...
This allows to send an encoder's output back to decoding and feed the
result into a complex filtergraph.
2024-03-13 08:01:27 +01:00
Anton Khirnov
2ee9362419
fftools/ffmpeg: remove unncessary casts for *_thread() return values
...
These functions used to be passed directly to pthread_create(), which
required them to return void*. This is no longer the case, so they can
return a plain int.
2024-03-13 08:01:15 +01:00
Anton Khirnov
f5d03b972c
fftools/ffmpeg: simplify propagating fallback parameters from decoders to filters
...
Current callstack looks like this:
* ifilter_bind_ist() (filter) calls ist_filter_add() (demuxer);
* ist_filter_add() opens the decoder, and then calls
dec_add_filter() (decoder);
* dec_add_filter() calls ifilter_parameters_from_dec() (i.e. back into
the filtering code) in order to give post-avcodec_open2() parameters
to the filter.
This is unnecessarily complicated. Pass the parameters as follows
instead:
* dec_init() (which opens the decoder) returns post-avcodec_open2()
parameters to its caller (i.e. the demuxer) in a parameter-only
AVFrame
* the demuxer passes these parameters to the filter in
InputFilterOptions, together with other filter options
2024-03-13 08:01:15 +01:00
Anton Khirnov
cabeac9123
fftools/ffmpeg_filter: add logging for binding inputs to demuxer streams
2024-03-13 08:01:15 +01:00
Anton Khirnov
cb0ec854fd
fftools/ffmpeg_filter: move filtergraph input type check to a better place
...
Perform it right after we figure out what the type is.
2024-03-13 08:01:15 +01:00
Anton Khirnov
7b51523f12
fftools/ffmpeg_opt: merge init_complex_filters() and check_filter_outputs()
...
The first of these binds inputs of complex filtergraphs to demuxer
streams (with a misleading comment claiming it *creates* complex
filtergraphs).
The second ensures that all filtergraph outputs are connected to an
encoder.
Merge them into a single function, which simplifies the ffmpeg_filter
API, is shorter, and will also be useful in following commits.
Also, rename misleadingly-named init_input_filter() to
fg_complex_bind_input().
2024-03-13 08:01:15 +01:00
Anton Khirnov
6f2acd7a9c
fftools/ffmpeg_filter: drop unused InputFilterPriv.ist
...
Outside of ifilter_bind_ist(), there are no longer any assumptions about
about filter inputs being fed by an InputStream.
2024-03-13 08:01:15 +01:00
Anton Khirnov
daca5d1241
fftools/ffmpeg_filter: refactor setting input timebase
...
Treat it analogously to stream parameters like format/dimensions/etc.
This is functionally different from previous code in 2 ways:
* for non-CFR video, the frame timebase (set by the decoder) is used
rather than the demuxer timebase
* for sub2video, AV_TIME_BASE_Q is used, which is hardcoded by the
subtitle decoding API
These changes should avoid unnecessary and potentially lossy timestamp
conversions from decoder timebase into the demuxer one.
Changes the timebases used in sub2video tests.
2024-03-13 08:01:15 +01:00
Anton Khirnov
f344277a88
fftools/ffmpeg_filter: merge block with the enclosing one
...
It has no reason to exist.
2024-03-12 09:47:56 +01:00
Anton Khirnov
639208cc6a
fftools/ffmpeg_filter: don't forward EOF in close_output()
...
The caller does not need or expect it, and it can lead to terminating
filtering prematurely in case there is more than one output.
2024-03-12 09:47:56 +01:00
Anton Khirnov
ce178be8b0
fftools/ffmpeg_filter: do not assume av_buffersrc_get_nb_failed_requests()>0
...
Apparently it can happen that avfilter_graph_request_oldest() returns
EAGAIN, yet av_buffersrc_get_nb_failed_requests() returns 0 for every
input.
Works around #10795 , though the root issue is most likely in the
scale2ref filter.
2024-03-12 09:47:14 +01:00
James Almer
b8fef7e9c5
avutil: remove deprecated FF_API_PKT_DURATION
...
Signed-off-by: James Almer <jamrial@gmail.com>
2024-03-07 08:53:30 -03:00
Anton Khirnov
e48055fdce
fftools/ffmpeg: remove options deprecated before 6.0
2024-03-01 16:51:11 +01:00
Anton Khirnov
a2fc86378a
fftools/ffmpeg: declare loop indices inside loops
2024-02-24 11:51:41 +01:00
Anton Khirnov
a3f69cdec7
fftools/ffmpeg: cosmetics, vertically align structs
2024-02-21 10:33:20 +01:00
Anton Khirnov
826cfd9997
fftools/ffmpeg_filter: pass framerate through InputFilterOptions
...
Rather than read it directly from InputStream.
This is a step towards avoiding the assumption that filtergraph inputs
are always fed by demuxers.
2024-02-21 10:27:20 +01:00
Anton Khirnov
fef3052df3
fftools/ffmpeg_filter: pass autorotate/reinit flags through InputFilterOptions
...
Rather than read them directly from InputStream.
This is a step towards avoiding the assumption that filtergraph inputs
are always fed by demuxers.
2024-02-21 10:27:20 +01:00
Anton Khirnov
6315f78e0c
fftools/ffmpeg_filter: pass sub2video canvas size through InputFilterOptions
...
Rather than read them directly from InputStream.
This is a step towards avoiding the assumption that filtergraph inputs
are always fed by demuxers.
2024-02-21 10:27:20 +01:00
Anton Khirnov
bd3c1c194b
fftools/ffmpeg_filter: accept a name from its upstream input
...
Do not construct the name manually from input file/stream indices.
This is a step towards avoiding the assumption that filtergraph inputs
are always fed by demuxers.
2024-02-21 10:27:20 +01:00
Anton Khirnov
8f592eb35f
fftools/ffmpeg_filter: compute input trim start/end in demuxer
...
The computation is based on demuxer properties, so that is the more
appropriate place for it. Filter code just receives the desired
start time/duration.
2024-02-21 10:27:20 +01:00
Anton Khirnov
09438d6529
fftools/ffmpeg_filter: stop taking display matrix from global side data
...
It should never be necessary now that decoders propagate global side
data to frames.
2024-02-21 10:27:20 +01:00
Niklas Haas
f7b1017d73
fftools/ffmpeg_filter: simplify buffersrc arg printing
...
There's no need to go through full string expansion here.
2024-02-02 13:24:27 +01:00
Anton Khirnov
d47bb91f8b
fftools/ffmpeg_filter: consolidate decoder/filter type checks
...
Also perform them earlier.
2024-01-30 09:52:00 +01:00
Anton Khirnov
1ea2e757f7
fftools/ffmpeg_filter: do not end filtering when a graph input EOFs
...
There may be other inputs or sources in the filtergraph. Propagate the
EOF to the scheduler and continue filtering.
Fixes #10803
2024-01-27 09:24:29 +01:00