Andreas Rheinhardt
4ab80ac17e
avfilter/af_biquads: Deduplicate AVClasses
...
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
2021-09-19 04:04:12 +02:00
Andreas Rheinhardt
8be701d9f7
avfilter/avfilter: Add numbers of (in|out)pads directly to AVFilter
...
Up until now, an AVFilter's lists of input and output AVFilterPads
were terminated by a sentinel and the only way to get the length
of these lists was by using avfilter_pad_count(). This has two
drawbacks: first, sizeof(AVFilterPad) is not negligible
(i.e. 64B on 64bit systems); second, getting the size involves
a function call instead of just reading the data.
This commit therefore changes this. The sentinels are removed and new
private fields nb_inputs and nb_outputs are added to AVFilter that
contain the number of elements of the respective AVFilterPad array.
Given that AVFilter.(in|out)puts are the only arrays of zero-terminated
AVFilterPads an API user has access to (AVFilterContext.(in|out)put_pads
are not zero-terminated and they already have a size field) the argument
to avfilter_pad_count() is always one of these lists, so it just has to
find the filter the list belongs to and read said number. This is slower
than before, but a replacement function that just reads the internal numbers
that users are expected to switch to will be added soon; and furthermore,
avfilter_pad_count() is probably never called in hot loops anyway.
This saves about 49KiB from the binary; notice that these sentinels are
not in .bss despite being zeroed: they are in .data.rel.ro due to the
non-sentinels.
Reviewed-by: Nicolas George <george@nsup.org>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
2021-08-20 12:53:58 +02:00
Andreas Rheinhardt
1b20853fb3
avfilter/internal: Factor out executing a filter's execute_func
...
The current way of doing it involves writing the ctx parameter twice.
Reviewed-by: Nicolas George <george@nsup.org>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
2021-08-15 21:33:25 +02:00
Andreas Rheinhardt
18ec426a86
avfilter/formats: Factor common function combinations out
...
Several combinations of functions happen quite often in query_format
functions; e.g. ff_set_common_formats(ctx, ff_make_format_list(sample_fmts))
is very common. This commit therefore adds functions that are equivalent
to commonly used function combinations in order to reduce code
duplication.
Reviewed-by: Nicolas George <george@nsup.org>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
2021-08-13 17:36:22 +02:00
Andreas Rheinhardt
1be3d8a0cb
avcodec/avcodec: Stop including channel_layout.h in avcodec.h
...
Also include channel_layout.h directly wherever used.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
2021-07-22 11:14:31 +02:00
Andreas Rheinhardt
a04ad248a0
avfilter: Constify all AVFilters
...
This is possible now that the next-API is gone.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Signed-off-by: James Almer <jamrial@gmail.com>
2021-04-27 11:48:05 -03:00
Andreas Rheinhardt
6fed8a6cb0
avfilter/af_biquads: Don't redundantly set AVClass
...
It is already set generically in ff_filter_alloc().
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
2021-01-08 05:06:12 +01:00
Andreas Rheinhardt
2d48b69b3d
avfilter/af_biquads: Deduplicate options
...
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
2021-01-08 05:06:12 +01:00
Paul B Mahol
1eb751955e
avfilter/af_biquads: fix error in ro calculation
2020-12-17 15:13:42 +01:00
Paul B Mahol
69be00aa61
avfilter/af_biquads: add one-pole shelf filters by adding pole option
2020-12-16 18:38:51 +01:00
Paul B Mahol
88b6ebdace
avfilter/af_biquads: add shortcut to set internal precision
2020-12-06 14:51:21 +01:00
Paul B Mahol
c6a7ca271b
avfilter/af_biquads: make sure that biquad filter still works
2020-11-24 14:26:47 +01:00
Paul B Mahol
040e989223
avfilter/af_biquads: do not abort filtering on bogus options
...
Instead, continue returning unfiltered input.
2020-11-24 12:03:23 +01:00
Paul B Mahol
42ccef2846
avfilter/af_biquads: remove not needed code
2020-11-22 14:22:19 +01:00
Paul B Mahol
2ddd6afd30
avfilter/af_biquads: make commands work reliably within biquad filter
...
Previously changing single coefficient would give unexpected results.
2020-11-02 13:30:14 +01:00
Paul B Mahol
40ce4ad999
avfilter/af_biquads: add lattice-ladder form
2020-11-02 13:30:14 +01:00
Paul B Mahol
2459c3f8f0
avfilter/af_biquads: add different transform types
2020-08-21 22:46:07 +02:00
Paul B Mahol
1206a10d9c
avfilter/af_biquads: implement 1st order allpass
2020-05-30 09:57:04 +02:00
Paul B Mahol
f46b04c4c3
avfilter/af_biquads: add new normalize/n option
2019-11-22 21:10:43 +01:00
Paul B Mahol
015cbca444
avfilter/af_biquads: use ff_filter_process_command()
2019-10-14 11:40:17 +02:00
Paul B Mahol
034a9d2507
avfilter/af_biquads: clip gain picked from command to sane values
2019-07-08 16:29:15 +02:00
Paul B Mahol
7b2d39fc27
avfilter/af_biquads: implement mix option to all filters
2019-07-08 16:20:57 +02:00
Paul B Mahol
255feeccc5
avfilter/af_biquads: add timeline support
2019-05-01 12:59:54 +02:00
Michael Niedermayer
1b6695354d
avfilter/af_biquads: minor simplification by using ff_exp10()
...
Reviewed-by: Paul B Mahol <onemda@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
2019-01-01 21:11:47 +01:00
Michael Niedermayer
6414415889
avfilter/af_biquads: Remove l from %lf in av_log environment
...
The l modifier does nothing in C99 and it was undefined in C89 for %f
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
2018-10-07 03:03:09 +02:00
Paul B Mahol
d176497cec
avfilter/af_biquads: add slice threading
...
Helps with multi-channels audio. Otherwise use threads=1.
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2018-05-01 16:00:19 +02:00
Paul B Mahol
2308a3c7e3
avfilter/af_biquads: change clipping detection from global to channel
...
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2018-05-01 15:26:20 +02:00
Paul B Mahol
2fc12f4971
avfilter: add lowshelf and highshelf filters
...
These are old bass and treble filters.
Make bass and treble filters better at boosting.
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2018-04-17 12:40:27 +02:00
Paul B Mahol
50b3cd22dd
avfilter/av_biquads: scale a0 too
...
Fixes bug when using commands to alter coefficients.
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2018-01-06 14:58:00 +01:00
Paul B Mahol
7bb1be9af0
avfilter: add arbitrary audio IIR filter
...
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2018-01-05 17:04:21 +01:00
Paul B Mahol
88cbd25b19
avfilter: pass outlink to ff_get_audio_buffer()
...
This is more correct.
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2018-01-03 22:52:47 +01:00
Paul B Mahol
5a6e753bc6
avfilter/af_biquads: change defaults for biquad filter
...
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2017-12-21 12:06:21 +01:00
Paul B Mahol
7fc89f226f
avfilter/af_biquads: increase width range
...
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2017-12-21 11:53:22 +01:00
Paul B Mahol
c99ed89f89
avfilter/af_biquads: add kHz width_type
...
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2017-12-21 11:52:49 +01:00
Paul B Mahol
9dcecbf04c
avfilter/af_biquads: add missing break statements
...
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2017-12-17 19:23:37 +01:00
Paul B Mahol
600c8729e2
avfilter/af_biquads: remove unused enum item
...
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2017-12-17 16:46:40 +01:00
Paul B Mahol
ce626f2695
avfilter/av_biquads: add support for commands
...
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2017-12-17 16:46:40 +01:00
Paul B Mahol
a23a56e77c
libavfilter/af_biquads: add shorter option for width_type
...
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2017-06-18 17:31:03 +02:00
Paul B Mahol
9d08c7bd42
avfilter/af_biquads: allow filtering only selected channels
...
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2017-04-25 18:08:26 +02:00
Muhammad Faiz
6af050d7d0
avfilter: do not use AVFrame accessor
...
Reviewed-by: wm4 <nfxjfg@googlemail.com>
Signed-off-by: Muhammad Faiz <mfcc64@gmail.com>
2017-04-23 14:40:30 +07:00
Sergey Kudryashov
a9b33b5a37
libavfilter/af_biquads: warn about clipping only after frame with clipping
2017-01-12 19:52:29 +01:00
Paul B Mahol
3689b58a5a
avfilter/af_biquads: display clipping warnings once per filtered frame
...
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2015-12-23 19:15:25 +01:00
Paul B Mahol
e6690ce02f
avfilter/af_biquads: pass filter ctx to av_log calls
...
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2015-12-07 11:47:43 +01:00
Paul B Mahol
142894d720
avfilter: do not leak frame if ff_get_audio_buffer() fails
...
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2015-11-25 21:59:33 +01:00
Paul B Mahol
494b792441
avfilter: use ff_all_channel_counts() instead of ff_all_channel_layouts()
...
Fixes playback of some files with ffplay.
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2015-09-12 01:43:06 +00:00
Clément Bœsch
1e2c23f06c
avfilter/treble: use AV_OPT_TYPE_BOOL for csg option
2015-09-12 18:24:49 +02:00
Paul B Mahol
a0854c084e
avfilter: handle error in query_formats() in bunch of filters
...
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2015-04-08 13:05:06 +00:00
Michael Niedermayer
e8c1eb09c7
avfilter/af_biquads: Change width_type to int as its accessed as int via AVOptions
...
This fixes depending on implementation defined behavior
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
2015-03-02 04:08:26 +01:00
Paul B Mahol
6121968a9e
avfilter/af_biquads: use the name 's' for the pointer to the private context
...
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2015-01-28 14:30:27 +00:00
Muhammad Faiz
ce385c869c
avfilter/biquads: avoid clipping when using floating type
...
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
2014-07-21 03:48:18 +02:00