1
0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2025-01-24 13:56:33 +02:00
FFmpeg/libavformat
Ico Doornekamp e112096885 avformat/rtpdec_jpeg: fix low contrast image on low quality setting
Original mail and my own followup on ffmpeg-user earlier today:

I have a device sending out a MJPEG/RTP stream on a low quality setting.
Decoding and displaying the video with libavformat results in a washed
out, low contrast, greyish image. Playing the same stream with VLC results
in proper color representation.

Screenshots for comparison:

  http://zevv.nl/div/libav/shot-ffplay.jpg
  http://zevv.nl/div/libav/shot-vlc.jpg

A pcap capture of a few seconds of video and SDP file for playing the
stream are available at

  http://zevv.nl/div/libav/mjpeg.pcap
  http://zevv.nl/div/libav/mjpeg.sdp

I believe the problem might be in the calculation of the quantization
tables in the function create_default_qtables(), the attached patch
solves the issue for me.

The problem is that the argument 'q' is of the type uint8_t. According to the
JPEG standard, if 1 <= q <= 50, the scale factor 'S' should be 5000 / Q.
Because the create_default_qtables() reuses the variable 'q' to store the
result of this calculation, for small values of q < 19, q wil subsequently
overflow and give wrong results in the calculated quantization tables. The
patch below uses a new variable 'S' (same name as in RFC2435) with the proper
range to store the result of the division.

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
(cherry picked from commit e3e6a2cff4af9542455d416faec4584d5e823d5d)

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
2016-04-28 03:47:13 +02:00
..
2015-05-23 22:36:02 +02:00
2015-06-08 03:36:22 +02:00
2015-04-07 22:50:07 +02:00
2016-01-15 16:00:31 +01:00
2016-01-31 00:23:46 +01:00
2015-06-18 22:09:01 +02:00
2016-01-28 01:05:04 +01:00
2015-02-26 02:06:10 +01:00
2015-03-26 03:10:27 +01:00
2015-06-18 22:09:01 +02:00
2016-01-15 16:00:32 +01:00
2016-01-31 00:23:45 +01:00
2015-05-26 19:54:41 +02:00
2015-06-08 03:36:22 +02:00
2016-04-28 03:47:13 +02:00
2015-11-12 02:55:46 +01:00
2015-05-31 10:10:16 +03:00
2015-05-20 19:07:26 +02:00
2015-12-20 14:18:11 +01:00
2015-11-26 01:37:12 +01:00
2015-06-07 21:55:46 +02:00
2015-05-27 21:48:47 +02:00
2015-04-23 12:56:31 +02:00
2015-03-27 18:29:46 +01:00
2015-04-24 03:43:56 +02:00