mirror of
https://github.com/FFmpeg/FFmpeg.git
synced 2025-01-03 05:10:03 +02:00
2698bfdc93
This test deliberately doesn't exercise the full range of inputs described in
the committee draft VC-1 standard. It says:
input coefficients in frequency domain, D, satisfy -2048 <= D < 2047
intermediate coefficients, E, satisfy -4096 <= E < 4095
fully inverse-transformed coefficients, R, satisfy -512 <= R < 511
For one thing, the inequalities look odd. Did they mean them to go the
other way round? That would make more sense because the equations generally
both add and subtract coefficients multiplied by constants, including powers
of 2. Requiring the most-negative values to be valid extends the number of
bits to represent the intermediate values just for the sake of that one case!
For another thing, the extreme values don't look to occur in real streams -
both in my experience and supported by the following comment in the AArch32
decoder:
tNhalf is half of the value of tN (as described in vc1_inv_trans_8x8_c).
This is done because sometimes files have input that causes tN + tM to
overflow. To avoid this overflow, we compute tNhalf, then compute
tNhalf + tM (which doesn't overflow), and then we use vhadd to compute
(tNhalf + (tNhalf + tM)) >> 1 which does not overflow because it is
one instruction.
My AArch64 decoder goes further than this. It calculates tNhalf and tM
then does an SRA (essentially a fused halve and add) to compute
(tN + tM) >> 1 without ever having to hold (tNhalf + tM) in a 16-bit element
without overflowing. It only encounters difficulties if either tNhalf or
tM overflow in isolation.
I haven't had sight of the final standard, so it's possible that these
issues were dealt with during finalisation, which could explain the lack
of usage of extreme inputs in real streams. Or a preponderance of decoders
that only support 16-bit intermediate values in their inverse transforms
might have caused encoders to steer clear of such cases.
I have effectively followed this approach in the test, and limited the
scale of the coefficients sufficient that both the existing AArch32 decoder
and my new AArch64 decoder both pass.
Signed-off-by: Ben Avison <bavison@riscosopen.org>
Signed-off-by: Martin Storsjö <martin@martin.st>
|
||
|---|---|---|
| .. | ||
| aarch64 | ||
| arm | ||
| x86 | ||
| .gitignore | ||
| aacpsdsp.c | ||
| af_afir.c | ||
| alacdsp.c | ||
| audiodsp.c | ||
| av_tx.c | ||
| blockdsp.c | ||
| bswapdsp.c | ||
| checkasm.c | ||
| checkasm.h | ||
| exrdsp.c | ||
| fixed_dsp.c | ||
| flacdsp.c | ||
| float_dsp.c | ||
| fmtconvert.c | ||
| g722dsp.c | ||
| h264dsp.c | ||
| h264pred.c | ||
| h264qpel.c | ||
| hevc_add_res.c | ||
| hevc_idct.c | ||
| hevc_pel.c | ||
| hevc_sao.c | ||
| huffyuvdsp.c | ||
| jpeg2000dsp.c | ||
| llviddsp.c | ||
| llviddspenc.c | ||
| Makefile | ||
| opusdsp.c | ||
| pixblockdsp.c | ||
| sbrdsp.c | ||
| sw_gbrp.c | ||
| sw_rgb.c | ||
| sw_scale.c | ||
| synth_filter.c | ||
| utvideodsp.c | ||
| v210dec.c | ||
| v210enc.c | ||
| vc1dsp.c | ||
| vf_blend.c | ||
| vf_colorspace.c | ||
| vf_eq.c | ||
| vf_gblur.c | ||
| vf_hflip.c | ||
| vf_nlmeans.c | ||
| vf_threshold.c | ||
| videodsp.c | ||
| vp8dsp.c | ||
| vp9dsp.c | ||