mirror of
https://github.com/FFmpeg/FFmpeg.git
synced 2024-12-02 03:06:28 +02:00
f1b08b8a65
ff_aac_coder_init_mips() modifies a static const structure of function pointers. This will crash if the binary uses relro and is a data race in any case. Furthermore it points to a maintainability issue: The AACCoefficientsEncoder structures have been constified in commitfd9212f2ed, a Libav commit merged in318778de9e. Libav did not have the MIPS-specific AAC code and so this was fine for them; yet FFmpeg had them, but this was not recognized. Commit75a099fc73points to another maintainability issue: Contrary to ordinary DSP code, this code here is way more complex and needs to be constantly kept in sync with the ordinary code which it mimicks and replaces. Said commit is the only commit actually changing aaccoder.c in the last few years and the same change has not been performed for the MIPS clone; before that, it even happened several times that the mips code was broken due to changes of the generic code (see commits97437bd17aandde262d018dor860dbe0275or933309a6caorb65ffa316e). This might even lead to scenarios where someone changing non-dsp aacenc code would have to modify mips inline asm in order to keep them in sync. This is obviously a significant burden (if the AAC encoder were actively developed). Finally, the code does not even compile here due to errors like "Error: float register should be even, was 1". Reviewed-by: Lynne <dev@lynne.ee> Reviewed-by: Jean-Baptiste Kempf <jb@videolan.org> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
97 lines
6.5 KiB
Makefile
97 lines
6.5 KiB
Makefile
ARCH_HEADERS = aacsbr_mips.h aacpsy_mips.h \
|
|
cabac.h compute_antialias_fixed.h \
|
|
compute_antialias_float.h \
|
|
|
|
MIPSFPU-OBJS-$(CONFIG_AMRNB_DECODER) += mips/acelp_filters_mips.o \
|
|
mips/celp_filters_mips.o \
|
|
mips/celp_math_mips.o \
|
|
mips/acelp_vectors_mips.o
|
|
MIPSFPU-OBJS-$(CONFIG_AMRWB_DECODER) += mips/acelp_filters_mips.o \
|
|
mips/celp_filters_mips.o \
|
|
mips/amrwbdec_mips.o \
|
|
mips/celp_math_mips.o \
|
|
mips/acelp_vectors_mips.o
|
|
MIPSFPU-OBJS-$(CONFIG_MPEGAUDIODSP) += mips/mpegaudiodsp_mips_float.o
|
|
MIPSDSP-OBJS-$(CONFIG_MPEGAUDIODSP) += mips/mpegaudiodsp_mips_fixed.o
|
|
MIPSFPU-OBJS-$(CONFIG_FMTCONVERT) += mips/fmtconvert_mips.o
|
|
OBJS-$(CONFIG_AC3DSP) += mips/ac3dsp_mips.o
|
|
OBJS-$(CONFIG_AAC_DECODER) += mips/aacdec_mips.o \
|
|
mips/aacsbr_mips.o \
|
|
mips/sbrdsp_mips.o \
|
|
mips/aacpsdsp_mips.o
|
|
MIPSFPU-OBJS-$(CONFIG_AAC_ENCODER) += mips/iirfilter_mips.o
|
|
OBJS-$(CONFIG_HEVC_DECODER) += mips/hevcdsp_init_mips.o \
|
|
mips/hevcpred_init_mips.o
|
|
OBJS-$(CONFIG_VP9_DECODER) += mips/vp9dsp_init_mips.o
|
|
OBJS-$(CONFIG_VP8_DECODER) += mips/vp8dsp_init_mips.o
|
|
OBJS-$(CONFIG_VP3DSP) += mips/vp3dsp_init_mips.o
|
|
OBJS-$(CONFIG_H264DSP) += mips/h264dsp_init_mips.o
|
|
OBJS-$(CONFIG_H264QPEL) += mips/h264qpel_init_mips.o
|
|
OBJS-$(CONFIG_H264CHROMA) += mips/h264chroma_init_mips.o
|
|
OBJS-$(CONFIG_H264PRED) += mips/h264pred_init_mips.o
|
|
OBJS-$(CONFIG_H263DSP) += mips/h263dsp_init_mips.o
|
|
OBJS-$(CONFIG_QPELDSP) += mips/qpeldsp_init_mips.o
|
|
OBJS-$(CONFIG_HPELDSP) += mips/hpeldsp_init_mips.o
|
|
OBJS-$(CONFIG_BLOCKDSP) += mips/blockdsp_init_mips.o
|
|
OBJS-$(CONFIG_PIXBLOCKDSP) += mips/pixblockdsp_init_mips.o
|
|
OBJS-$(CONFIG_IDCTDSP) += mips/idctdsp_init_mips.o
|
|
OBJS-$(CONFIG_MPEGVIDEO) += mips/mpegvideo_init_mips.o
|
|
OBJS-$(CONFIG_MPEGVIDEOENC) += mips/mpegvideoencdsp_init_mips.o
|
|
OBJS-$(CONFIG_ME_CMP) += mips/me_cmp_init_mips.o
|
|
OBJS-$(CONFIG_MPEG4_DECODER) += mips/xvididct_init_mips.o
|
|
OBJS-$(CONFIG_VC1DSP) += mips/vc1dsp_init_mips.o
|
|
OBJS-$(CONFIG_WMV2DSP) += mips/wmv2dsp_init_mips.o
|
|
OBJS-$(CONFIG_VIDEODSP) += mips/videodsp_init.o
|
|
MSA-OBJS-$(CONFIG_HEVC_DECODER) += mips/hevcdsp_msa.o \
|
|
mips/hevc_mc_uni_msa.o \
|
|
mips/hevc_mc_uniw_msa.o \
|
|
mips/hevc_mc_bi_msa.o \
|
|
mips/hevc_mc_biw_msa.o \
|
|
mips/hevc_idct_msa.o \
|
|
mips/hevc_lpf_sao_msa.o \
|
|
mips/hevcpred_msa.o
|
|
MSA-OBJS-$(CONFIG_VP9_DECODER) += mips/vp9_mc_msa.o \
|
|
mips/vp9_lpf_msa.o \
|
|
mips/vp9_idct_msa.o \
|
|
mips/vp9_intra_msa.o
|
|
MSA-OBJS-$(CONFIG_VP8_DECODER) += mips/vp8_mc_msa.o \
|
|
mips/vp8_idct_msa.o \
|
|
mips/vp8_lpf_msa.o
|
|
MSA-OBJS-$(CONFIG_VP3DSP) += mips/vp3dsp_idct_msa.o
|
|
MSA-OBJS-$(CONFIG_H264DSP) += mips/h264dsp_msa.o \
|
|
mips/h264idct_msa.o \
|
|
mips/h264_deblock_msa.o
|
|
MSA-OBJS-$(CONFIG_H264QPEL) += mips/h264qpel_msa.o
|
|
MSA-OBJS-$(CONFIG_H264CHROMA) += mips/h264chroma_msa.o
|
|
MSA-OBJS-$(CONFIG_H264PRED) += mips/h264pred_msa.o
|
|
MSA-OBJS-$(CONFIG_H263DSP) += mips/h263dsp_msa.o
|
|
MSA-OBJS-$(CONFIG_QPELDSP) += mips/qpeldsp_msa.o
|
|
MSA-OBJS-$(CONFIG_HPELDSP) += mips/hpeldsp_msa.o
|
|
MSA-OBJS-$(CONFIG_BLOCKDSP) += mips/blockdsp_msa.o
|
|
MSA-OBJS-$(CONFIG_PIXBLOCKDSP) += mips/pixblockdsp_msa.o
|
|
MSA-OBJS-$(CONFIG_IDCTDSP) += mips/idctdsp_msa.o \
|
|
mips/simple_idct_msa.o
|
|
MSA-OBJS-$(CONFIG_MPEGVIDEO) += mips/mpegvideo_msa.o
|
|
MSA-OBJS-$(CONFIG_MPEGVIDEOENC) += mips/mpegvideoencdsp_msa.o
|
|
MSA-OBJS-$(CONFIG_ME_CMP) += mips/me_cmp_msa.o
|
|
MSA-OBJS-$(CONFIG_VC1_DECODER) += mips/vc1dsp_msa.o
|
|
|
|
MMI-OBJS += mips/constants.o
|
|
MMI-OBJS-$(CONFIG_H264DSP) += mips/h264dsp_mmi.o
|
|
MMI-OBJS-$(CONFIG_H264CHROMA) += mips/h264chroma_mmi.o
|
|
MMI-OBJS-$(CONFIG_H264PRED) += mips/h264pred_mmi.o
|
|
MMI-OBJS-$(CONFIG_MPEGVIDEO) += mips/mpegvideo_mmi.o
|
|
MMI-OBJS-$(CONFIG_IDCTDSP) += mips/idctdsp_mmi.o \
|
|
mips/simple_idct_mmi.o
|
|
MMI-OBJS-$(CONFIG_MPEG4_DECODER) += mips/xvid_idct_mmi.o
|
|
MMI-OBJS-$(CONFIG_BLOCKDSP) += mips/blockdsp_mmi.o
|
|
MMI-OBJS-$(CONFIG_PIXBLOCKDSP) += mips/pixblockdsp_mmi.o
|
|
MMI-OBJS-$(CONFIG_H264QPEL) += mips/h264qpel_mmi.o
|
|
MMI-OBJS-$(CONFIG_VP8_DECODER) += mips/vp8dsp_mmi.o
|
|
MMI-OBJS-$(CONFIG_HPELDSP) += mips/hpeldsp_mmi.o
|
|
MMI-OBJS-$(CONFIG_VC1_DECODER) += mips/vc1dsp_mmi.o
|
|
MMI-OBJS-$(CONFIG_WMV2DSP) += mips/wmv2dsp_mmi.o
|
|
MMI-OBJS-$(CONFIG_HEVC_DECODER) += mips/hevcdsp_mmi.o
|
|
MMI-OBJS-$(CONFIG_VP3DSP) += mips/vp3dsp_idct_mmi.o
|
|
MMI-OBJS-$(CONFIG_VP9_DECODER) += mips/vp9_mc_mmi.o
|