mirror of
https://github.com/FFmpeg/FFmpeg.git
synced 2024-12-02 03:06:28 +02:00
4746653466
Avoids inheritance of file handles on Windows systems similar to the O_CLOEXEC/FD_CLOEXEC flag on Linux. Fixes file lock issues in Windows applications when a child process is started with handle inheritance enabled (standard input/output redirection) while a FFmpeg transcoding is running in the parent process. Links relevant to the subject: https://msdn.microsoft.com/en-us/library/w7sa2b22.aspx Describes the _wsopen() function and the O_NOINHERIT flag. File handles opened by _wsopen() are inheritable by default. https://msdn.microsoft.com/en-us/library/windows/desktop/ms682425%28v=vs.85%29.aspx Describes handle inheritance when creating new processes. Handle inheritance must be enabled (bInheritHandles = TRUE) e.g. when you want to pass handles for stdin/stdout via lpStartupInfo. Signed-off-by: Tobias Rapp <t.rapp@noa-audio.com> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
128 lines
2.9 KiB
C
128 lines
2.9 KiB
C
/*
|
|
* This file is part of FFmpeg.
|
|
*
|
|
* FFmpeg is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* FFmpeg is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with FFmpeg; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
|
|
#include "config.h"
|
|
#include "internal.h"
|
|
#include "mem.h"
|
|
#include <stdarg.h>
|
|
#include <fcntl.h>
|
|
#include <sys/stat.h>
|
|
#if HAVE_UNISTD_H
|
|
#include <unistd.h>
|
|
#endif
|
|
#if HAVE_IO_H
|
|
#include <io.h>
|
|
#endif
|
|
|
|
#if defined(_WIN32) && !defined(__MINGW32CE__)
|
|
#undef open
|
|
#undef lseek
|
|
#undef stat
|
|
#undef fstat
|
|
#include <windows.h>
|
|
#include <share.h>
|
|
#include <errno.h>
|
|
#include "wchar_filename.h"
|
|
|
|
static int win32_open(const char *filename_utf8, int oflag, int pmode)
|
|
{
|
|
int fd;
|
|
wchar_t *filename_w;
|
|
|
|
/* convert UTF-8 to wide chars */
|
|
if (utf8towchar(filename_utf8, &filename_w))
|
|
return -1;
|
|
if (!filename_w)
|
|
goto fallback;
|
|
|
|
fd = _wsopen(filename_w, oflag, SH_DENYNO, pmode);
|
|
av_freep(&filename_w);
|
|
|
|
if (fd != -1 || (oflag & O_CREAT))
|
|
return fd;
|
|
|
|
fallback:
|
|
/* filename may be in CP_ACP */
|
|
return _sopen(filename_utf8, oflag, SH_DENYNO, pmode);
|
|
}
|
|
#define open win32_open
|
|
#endif
|
|
|
|
int avpriv_open(const char *filename, int flags, ...)
|
|
{
|
|
int fd;
|
|
unsigned int mode = 0;
|
|
va_list ap;
|
|
|
|
va_start(ap, flags);
|
|
if (flags & O_CREAT)
|
|
mode = va_arg(ap, unsigned int);
|
|
va_end(ap);
|
|
|
|
#ifdef O_CLOEXEC
|
|
flags |= O_CLOEXEC;
|
|
#endif
|
|
#ifdef O_NOINHERIT
|
|
flags |= O_NOINHERIT;
|
|
#endif
|
|
|
|
fd = open(filename, flags, mode);
|
|
#if HAVE_FCNTL
|
|
if (fd != -1) {
|
|
if (fcntl(fd, F_SETFD, FD_CLOEXEC) == -1)
|
|
av_log(NULL, AV_LOG_DEBUG, "Failed to set close on exec\n");
|
|
}
|
|
#endif
|
|
|
|
return fd;
|
|
}
|
|
|
|
FILE *av_fopen_utf8(const char *path, const char *mode)
|
|
{
|
|
int fd;
|
|
int access;
|
|
const char *m = mode;
|
|
|
|
switch (*m++) {
|
|
case 'r': access = O_RDONLY; break;
|
|
case 'w': access = O_CREAT|O_WRONLY|O_TRUNC; break;
|
|
case 'a': access = O_CREAT|O_WRONLY|O_APPEND; break;
|
|
default :
|
|
errno = EINVAL;
|
|
return NULL;
|
|
}
|
|
while (*m) {
|
|
if (*m == '+') {
|
|
access &= ~(O_RDONLY | O_WRONLY);
|
|
access |= O_RDWR;
|
|
} else if (*m == 'b') {
|
|
#ifdef O_BINARY
|
|
access |= O_BINARY;
|
|
#endif
|
|
} else if (*m) {
|
|
errno = EINVAL;
|
|
return NULL;
|
|
}
|
|
m++;
|
|
}
|
|
fd = avpriv_open(path, access, 0666);
|
|
if (fd == -1)
|
|
return NULL;
|
|
return fdopen(fd, mode);
|
|
}
|