1
0
mirror of https://github.com/FFmpeg/FFmpeg.git synced 2024-11-26 19:01:44 +02:00
Go to file
Andreas Rheinhardt 87b30f8af8 avcodec/flac_parser: Don't modify size of the input buffer
When flushing, MAX_FRAME_HEADER_SIZE bytes (always zero) are supposed to
be written to the fifo buffer in order to be able to check the rest of
the buffer for frame headers. It was intended to write these by writing
a small buffer of size MAX_FRAME_HEADER_SIZE to the buffer. But the way
it was actually done ensured that this did not happen:

First, it would be checked whether the size of the input buffer was zero,
in which case it buf_size would be set to MAX_FRAME_HEADER_SIZE and
read_end would be set to indicate that MAX_FRAME_HEADER_SIZE bytes need
to be written. Then it would be made sure that there is enough space in
the fifo for the data to be written. Afterwards the data is written. The
check used here is for whether buf_size is zero or not. But if it was
zero initially, it is MAX_FRAME_HEADER_SIZE now, so that not the
designated buffer for writing MAX_FRAME_HEADER_SIZE is written; instead
the padded buffer (from the stack of av_parser_parse2()) is used. This
works because AV_INPUT_BUFFER_PADDING_SIZE >= MAX_FRAME_HEADER_SIZE.
Lateron, buf_size is set to zero again.

Given that since 7edbd536, the actual amount of data read is no longer
automatically equal to buf_size, it is completely unnecessary to modify
buf_size at all. Moreover, modifying it is dangerous: Some allocations
can fail and because buf_size is never reset to zero in this codepath,
the parser might return a value > 0 on flushing.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
2019-10-07 22:53:28 +02:00
compat compat/cuda: Change inclusion guards 2019-08-05 12:07:09 +02:00
doc doc/formats: Update documentation for chromaprint 2019-10-08 01:15:10 +05:30
ffbuild build: add support for building CUDA files with clang 2019-08-04 19:08:08 +02:00
fftools cmdutils: trailing options may be ignored 2019-10-01 10:43:37 -08:00
libavcodec avcodec/flac_parser: Don't modify size of the input buffer 2019-10-07 22:53:28 +02:00
libavdevice libavdevice: Update the class name as uniform style 2019-08-15 09:29:55 +08:00
libavfilter avcodec/filter: Remove extra '; ' outside of functions 2019-10-07 21:15:55 +02:00
libavformat avformat/flac_picture: Avoid allocation of AVIOContext 2019-10-07 22:27:17 +02:00
libavresample
libavutil avutil/common: Fix underflow for ROUNDED_DIV with unsigned integer 2019-10-06 17:28:29 +08:00
libpostproc Bump minor versions again on master to keep 4.2 versions separate from master 2019-07-21 18:36:31 +02:00
libswresample swresample/audioconvert: fix invalid left shift for 64bit sample format 2019-09-26 16:22:47 +02:00
libswscale swscale: Fix AltiVec/VSX build with recent GCC 2019-10-04 08:58:17 +03:00
presets
tests avcodec/flac_parser: Fix off-by-one error 2019-10-07 22:27:18 +02:00
tools tools/target_dec_fuzzer: Adjust VP7 threshold 2019-09-29 22:18:58 +02:00
.gitattributes
.gitignore tools/python: add script to convert TensorFlow model (.pb) to native model (.model) 2019-07-01 10:23:47 -03:00
.travis.yml Merge commit '899ee03088d55152a48830df0899887f055da1de' 2019-03-14 15:53:16 -03:00
Changelog avfilter: add anlms filter 2019-10-06 15:09:38 +02:00
configure configure: check for a sufficiently recent enough AMF version 2019-09-09 09:56:12 +02:00
CONTRIBUTING.md
COPYING.GPLv2
COPYING.GPLv3
COPYING.LGPLv2.1
COPYING.LGPLv3
CREDITS
INSTALL.md
LICENSE.md LICENSE: Add missing libraries that need --enable-version3. 2019-08-12 02:25:39 +02:00
MAINTAINERS MAINTAINERS: add myself to OMX 2019-08-23 17:07:05 -07:00
Makefile tools: Add fuzzer for demuxers 2019-05-31 22:44:30 +02:00
README.md
RELEASE RELEASE: Update value for post 4.2 branch 2019-07-21 18:37:32 +02:00

FFmpeg README

FFmpeg is a collection of libraries and tools to process multimedia content such as audio, video, subtitles and related metadata.

Libraries

  • libavcodec provides implementation of a wider range of codecs.
  • libavformat implements streaming protocols, container formats and basic I/O access.
  • libavutil includes hashers, decompressors and miscellaneous utility functions.
  • libavfilter provides a mean to alter decoded Audio and Video through chain of filters.
  • libavdevice provides an abstraction to access capture and playback devices.
  • libswresample implements audio mixing and resampling routines.
  • libswscale implements color conversion and scaling routines.

Tools

  • ffmpeg is a command line toolbox to manipulate, convert and stream multimedia content.
  • ffplay is a minimalistic multimedia player.
  • ffprobe is a simple analysis tool to inspect multimedia content.
  • Additional small tools such as aviocat, ismindex and qt-faststart.

Documentation

The offline documentation is available in the doc/ directory.

The online documentation is available in the main website and in the wiki.

Examples

Coding examples are available in the doc/examples directory.

License

FFmpeg codebase is mainly LGPL-licensed with optional components licensed under GPL. Please refer to the LICENSE file for detailed information.

Contributing

Patches should be submitted to the ffmpeg-devel mailing list using git format-patch or git send-email. Github pull requests should be avoided because they are not part of our review process and will be ignored.